V2 [PATCH] x86: Add tst-get-cpu-features-static to $(tests) [BZ #23458]

Message ID 20180729141956.GA9314@gmail.com
State New
Headers show
Series
  • V2 [PATCH] x86: Add tst-get-cpu-features-static to $(tests) [BZ #23458]
Related show

Commit Message

H.J. Lu July 29, 2018, 2:19 p.m.
On Fri, Jul 27, 2018 at 02:41:23PM -0700, H.J. Lu wrote:
> On Fri, Jul 27, 2018 at 2:14 PM, Florian Weimer <fweimer@redhat.com> wrote:

> > On 07/27/2018 10:38 PM, H.J. Lu wrote:

> >>

> >> -tests += tst-get-cpu-features

> >> +# NB: All tests should be added to $(tests) and all static tests should

> >> +# be added to $(tests-static).

> >> +tests += tst-get-cpu-features tst-get-cpu-features-static

> >

> >

> > Why the comment?  What makes this instance so special to warrant one?

> >

> 

> I can take out the comment.

> 


Here is the updated patch.  OK for master?

Thanks.

H.J.
---
All tests should be added to $(tests).

	[BZ #23458]
	* sysdeps/x86/Makefile (tests): Add tst-get-cpu-features-static.
---
 sysdeps/x86/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

Comments

Carlos O'Donell July 30, 2018, 8:34 p.m. | #1
On 07/29/2018 10:19 AM, H.J. Lu wrote:
> On Fri, Jul 27, 2018 at 02:41:23PM -0700, H.J. Lu wrote:

>> On Fri, Jul 27, 2018 at 2:14 PM, Florian Weimer <fweimer@redhat.com> wrote:

>>> On 07/27/2018 10:38 PM, H.J. Lu wrote:

>>>>

>>>> -tests += tst-get-cpu-features

>>>> +# NB: All tests should be added to $(tests) and all static tests should

>>>> +# be added to $(tests-static).

>>>> +tests += tst-get-cpu-features tst-get-cpu-features-static

>>>

>>>

>>> Why the comment?  What makes this instance so special to warrant one?

>>>

>>

>> I can take out the comment.

>>

> 

> Here is the updated patch.  OK for master?


OK for master.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>


> Thanks.

> 

> H.J.

> ---

> All tests should be added to $(tests).

> 

> 	[BZ #23458]

> 	* sysdeps/x86/Makefile (tests): Add tst-get-cpu-features-static.

> ---

>  sysdeps/x86/Makefile | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/sysdeps/x86/Makefile b/sysdeps/x86/Makefile

> index 672bb19489..337b0b63dc 100644

> --- a/sysdeps/x86/Makefile

> +++ b/sysdeps/x86/Makefile

> @@ -5,7 +5,7 @@ endif

>  ifeq ($(subdir),elf)

>  sysdep-dl-routines += dl-get-cpu-features

>  

> -tests += tst-get-cpu-features

> +tests += tst-get-cpu-features tst-get-cpu-features-static

>  tests-static += tst-get-cpu-features-static

>  endif

>  

> 



-- 
Cheers,
Carlos.

Patch

diff --git a/sysdeps/x86/Makefile b/sysdeps/x86/Makefile
index 672bb19489..337b0b63dc 100644
--- a/sysdeps/x86/Makefile
+++ b/sysdeps/x86/Makefile
@@ -5,7 +5,7 @@  endif
 ifeq ($(subdir),elf)
 sysdep-dl-routines += dl-get-cpu-features
 
-tests += tst-get-cpu-features
+tests += tst-get-cpu-features tst-get-cpu-features-static
 tests-static += tst-get-cpu-features-static
 endif