epiphany: fir -Wformat-diag.

Message ID f2b686ad-3de8-ce0f-6fbc-7cf8225ee1a5@suse.cz
State New
Headers show
Series
  • epiphany: fir -Wformat-diag.
Related show

Commit Message

Martin Liška Jan. 12, 2022, 9:57 a.m.
This fixes -Wformat-diag warnings.

Ready to be installed?
Thanks,
Martin

gcc/ChangeLog:

	* config/epiphany/epiphany.c (epiphany_handle_interrupt_attribute):
	Use %qs format specifier.
	(epiphany_override_options): Wrap keyword in %<, %>.
---
  gcc/config/epiphany/epiphany.c | 10 ++++++----
  1 file changed, 6 insertions(+), 4 deletions(-)

-- 
2.34.1

Comments

Jason Merrill via Gcc-patches Jan. 12, 2022, 4:21 p.m. | #1
On 1/12/2022 2:57 AM, Martin Liška wrote:
> This fixes -Wformat-diag warnings.

>

> Ready to be installed?

> Thanks,

> Martin

>

> gcc/ChangeLog:

>

>     * config/epiphany/epiphany.c (epiphany_handle_interrupt_attribute):

>     Use %qs format specifier.

>     (epiphany_override_options): Wrap keyword in %<, %>.

OK.  And similar changes for other ports are pre-approved.

jeff

Patch

diff --git a/gcc/config/epiphany/epiphany.c b/gcc/config/epiphany/epiphany.c
index 88283419dc1..c9c321560de 100644
--- a/gcc/config/epiphany/epiphany.c
+++ b/gcc/config/epiphany/epiphany.c
@@ -520,8 +520,10 @@  epiphany_handle_interrupt_attribute (tree *node, tree name, tree args,
  	   && strcmp (TREE_STRING_POINTER (value), "swi"))
      {
        warning (OPT_Wattributes,
-	       "argument of %qE attribute is not \"reset\", \"software_exception\", \"page_miss\", \"timer0\", \"timer1\", \"message\", \"dma0\", \"dma1\", \"wand\" or \"swi\"",
-	       name);
+	       "argument of %qE attribute is not %qs, %qs %qs, %qs, %qs, "
+	       "%qs, %qs, %qs, %qs or %qs", name,
+	       "reset", "software_exception", "page_miss", "timer0", "timer1",
+	       "message", "dma0", "dma1", "wand", "swi");
        *no_add_attrs = true;
        return NULL_TREE;
      }
@@ -1538,9 +1540,9 @@  static void
  epiphany_override_options (void)
  {
    if (epiphany_stack_offset < 4)
-    error ("stack_offset must be at least 4");
+    error ("%<stack_offset%> must be at least 4");
    if (epiphany_stack_offset & 3)
-    error ("stack_offset must be a multiple of 4");
+    error ("%<stack_offset%> must be a multiple of 4");
    epiphany_stack_offset = (epiphany_stack_offset + 3) & -4;
   if (!TARGET_SOFT_CMPSF)
     flag_finite_math_only = 1;