timezone: Fix tst-bz28707 Makefile rule

Message ID 20220110131854.3899811-1-adhemerval.zanella@linaro.org
State New
Headers show
Series
  • timezone: Fix tst-bz28707 Makefile rule
Related show

Commit Message

Adhemerval Zanella via Libc-alpha Jan. 10, 2022, 1:18 p.m.
The $(testdata)/XT5 rule is ambiguous and it may not be correct
evaluated.
---
 timezone/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.32.0

Comments

Adhemerval Zanella via Libc-alpha Jan. 12, 2022, 12:51 p.m. | #1
I am seeing make check completion failure without this issue and I 
will install this shortly if no one opposes it.

On 10/01/2022 10:18, Adhemerval Zanella wrote:
> The $(testdata)/XT5 rule is ambiguous and it may not be correct

> evaluated.

> ---

>  timezone/Makefile | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)

> 

> diff --git a/timezone/Makefile b/timezone/Makefile

> index 4e7f68a8fc..a789c22d26 100644

> --- a/timezone/Makefile

> +++ b/timezone/Makefile

> @@ -124,7 +124,8 @@ $(testdata)/XT%: testdata/XT%

>  	$(make-target-directory)

>  	cp $< $@

>  

> -$(testdata)/XT%: testdata/gen-XT%.sh

> +$(testdata)/XT5: testdata/gen-XT5.sh

> +	$(make-target-directory)

>  	$(SHELL) $< > $@.tmp

>  	mv $@.tmp $@

>
Adhemerval Zanella via Libc-alpha Jan. 12, 2022, 1:37 p.m. | #2
* Adhemerval Zanella via Libc-alpha:

> I am seeing make check completion failure without this issue and I 

> will install this shortly if no one opposes it.


Yes, please check it in.

Thanks,
Florian

Patch

diff --git a/timezone/Makefile b/timezone/Makefile
index 4e7f68a8fc..a789c22d26 100644
--- a/timezone/Makefile
+++ b/timezone/Makefile
@@ -124,7 +124,8 @@  $(testdata)/XT%: testdata/XT%
 	$(make-target-directory)
 	cp $< $@
 
-$(testdata)/XT%: testdata/gen-XT%.sh
+$(testdata)/XT5: testdata/gen-XT5.sh
+	$(make-target-directory)
 	$(SHELL) $< > $@.tmp
 	mv $@.tmp $@