gdb fix PowerPC test gdb.arch/ppc-longdouble.exp

Message ID e881de36562dfd581ae9b2f2cf5c54a49d5a76eb.camel@us.ibm.com
State New
Headers show
Series
  • gdb fix PowerPC test gdb.arch/ppc-longdouble.exp
Related show

Commit Message

Mike Frysinger via Gdb-patches Nov. 18, 2021, 12:12 a.m.
GDB maintainers:

The following patch fixes warnings of duplicate tests as described in
the commit log.

Please let me know if this patch is acceptable for mainline.

                   Carl 

----------------------------------------------------
gdb fix PowerPC test gdb.arch/ppc-longdouble.exp

The test complains of duplicate tests.

DUPLICATE: gdb.arch/ppc-longdouble.exp: continue to breakpoint: return

The do_test calls gdb_continue_to_breakpoint "return".  The duplicates
are the result of calling do_test three times with different arguments.

This patch fixes the duplicate tests by adding $name to the
gdb_continue_to_breakpoint argument.

Patch tested on Power 10  ppc64le GNU/Linux, no duplicate tests reported,
no new regression errors.
---
 gdb/testsuite/gdb.arch/ppc-longdouble.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.30.2

Comments

Tom Tromey Nov. 18, 2021, 3:22 p.m. | #1
>>>>> "Carl" == Carl Love via Gdb-patches <gdb-patches@sourceware.org> writes:


Carl> The following patch fixes warnings of duplicate tests as described in
Carl> the commit log.

Carl> Please let me know if this patch is acceptable for mainline.

Thank you for the patch.  This looks good to me.

Tom

Patch

diff --git a/gdb/testsuite/gdb.arch/ppc-longdouble.exp b/gdb/testsuite/gdb.arch/ppc-longdouble.exp
index 6e3b1bda542..2a49e456a68 100644
--- a/gdb/testsuite/gdb.arch/ppc-longdouble.exp
+++ b/gdb/testsuite/gdb.arch/ppc-longdouble.exp
@@ -39,7 +39,7 @@  proc do_test { name {opts {}} } {
 
     # Run to the breakpoint at return.
     gdb_breakpoint [gdb_get_line_number "return"]
-    gdb_continue_to_breakpoint "return"
+    gdb_continue_to_breakpoint "return test: $name"
 
     # Print the value of ld
     gdb_test "print ld" ".* = 1\\.375.*" "the value of ld is 1.375 ($name)"