bfdver.h is not installed

Message ID d0d8883a-c05c-344b-6a9c-378949f495c6@gmail.com
State New
Headers show
Series
  • bfdver.h is not installed
Related show

Commit Message

Mike Frysinger via Binutils Nov. 3, 2021, 7:35 a.m.
Hi all,

I want to use bfdver.h to detect libbfd version like [1], however it would not be provided in `make install`.

I don't know why it is not provided for include dir, but I think it would be useful for developers.
Can you treat this patch?


[1] https://github.com/openjdk/jdk/blob/87b926ebb7f1e341da858f7a9892377586abc026/src/utils/hsdis/hsdis.c#L568-L573


Thanks,

Yasumasa

Patch

diff --git a/bfd/Makefile.am b/bfd/Makefile.am
index 097177bae5c..54d6b615032 100644
--- a/bfd/Makefile.am
+++ b/bfd/Makefile.am
@@ -32,7 +32,7 @@  if INSTALL_LIBBFD
  bfdlibdir = @bfdlibdir@
  bfdincludedir = @bfdincludedir@
  bfdlib_LTLIBRARIES = libbfd.la
-bfdinclude_HEADERS = $(BFD_H) $(INCDIR)/ansidecl.h $(INCDIR)/symcat.h \
+bfdinclude_HEADERS = $(BFD_H) bfdver.h $(INCDIR)/ansidecl.h $(INCDIR)/symcat.h \
                      $(INCDIR)/diagnostics.h $(INCDIR)/bfdlink.h
  else !INSTALL_LIBBFD
  # Empty these so that the respective installation directories will not be created.
diff --git a/bfd/Makefile.in b/bfd/Makefile.in
index a76b653247f..ef4eda844b1 100644
--- a/bfd/Makefile.in
+++ b/bfd/Makefile.in
@@ -468,6 +468,7 @@  libbfd_la_LDFLAGS = $(am__append_1) -release `cat libtool-soversion` \
  @INSTALL_LIBBFD_TRUE@bfdlib_LTLIBRARIES = libbfd.la
  @INSTALL_LIBBFD_FALSE@bfdinclude_HEADERS = $(am__append_2)
  @INSTALL_LIBBFD_TRUE@bfdinclude_HEADERS = $(BFD_H) \
+@INSTALL_LIBBFD_TRUE@  bfdver.h \
  @INSTALL_LIBBFD_TRUE@  $(INCDIR)/ansidecl.h $(INCDIR)/symcat.h \
  @INSTALL_LIBBFD_TRUE@  $(INCDIR)/diagnostics.h \
  @INSTALL_LIBBFD_TRUE@  $(INCDIR)/bfdlink.h $(am__append_2)