[pushed,2/4,gdb/testsuite] Fix gdb.base/batch-exit-status.exp with native-gdbserver

Message ID 20211013090031.21963-2-tdevries@suse.de
State New
Headers show
Series
  • [pushed,1/4,gdb/testsuite] Remove quit in gdb.arch/i386-mpx.exp
Related show

Commit Message

Stafford Horne via Gdb-patches Oct. 13, 2021, 9 a.m.
When running test-case gdb.base/batch-exit-status.exp with target board
native-gdbserver, I run into (added missing double quotes for clarity):
...
builtin_spawn $build/gdb/testsuite/../../gdb/gdb -nw -nx \
  -data-directory $build/gdb/testsuite/../data-directory \
  -iex "set height 0" -iex "set width 0" \
  -ex "set auto-connect-native-target off" \
  -iex "set sysroot" -batch ""^M
: No such file or directory.^M
PASS: gdb.base/batch-exit-status.exp: 1x: \
  No such file or directory: [lindex $result 2] == 0
FAIL: gdb.base/batch-exit-status.exp: 1x: \
  No such file or directory: [lindex $result 3] == $expect_status
...

As in commit a02a90c114c "[gdb/testsuite] Set sysroot earlier in
local-board.exp", the problem is the use of -ex for
"set auto-connect-native-target off", which makes that the last command to
be executed, and consequently determines the return status.

Fix this by using -iex instead.

Tested on x86_64-linux.
---
 gdb/testsuite/boards/gdbserver-base.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.26.2

Patch

diff --git a/gdb/testsuite/boards/gdbserver-base.exp b/gdb/testsuite/boards/gdbserver-base.exp
index 03bdffeb8f8..8939b8c4b12 100644
--- a/gdb/testsuite/boards/gdbserver-base.exp
+++ b/gdb/testsuite/boards/gdbserver-base.exp
@@ -31,4 +31,4 @@  set_board_info gdb,nofileio 1
 # The predefined TSVs in GDBserver.
 set_board_info gdb,predefined_tsv "\\\$trace_timestamp"
 
-set GDBFLAGS "${GDBFLAGS} -ex \"set auto-connect-native-target off\""
+set GDBFLAGS "${GDBFLAGS} -iex \"set auto-connect-native-target off\""