[pushed,1/4,gdb/testsuite] Remove quit in gdb.arch/i386-mpx.exp

Message ID 20211013090031.21963-1-tdevries@suse.de
State New
Headers show
Series
  • [pushed,1/4,gdb/testsuite] Remove quit in gdb.arch/i386-mpx.exp
Related show

Commit Message

Philippe Waroquiers via Gdb-patches Oct. 13, 2021, 9 a.m.
When running test-case gdb.arch/i386-mpx.exp with target board
native-gdbserver, I run into:
...
(gdb) PASS: gdb.arch/i386-mpx.exp: verify size for bnd0
Remote debugging from host ::1, port 42328^M
quit^M
A debugging session is active.^M
^M
        Inferior 1 [process 19679] will be killed.^M
^M
Quit anyway? (y or n) monitor exit^M
Please answer y or n.^M
A debugging session is active.^M
^M
        Inferior 1 [process 19679] will be killed.^M
^M
Quit anyway? (y or n) WARNING: Timed out waiting for EOF in server after monitor exit
...

The problem is that the test-case sends a quit at the end (without verifying
the result of this in any way):
...
send_gdb "quit\n"
...

Fix this by removing the quit.

Tested on x86_64-linux.
---
 gdb/testsuite/gdb.arch/i386-mpx.exp | 2 --
 1 file changed, 2 deletions(-)


base-commit: 777b054cf93ad2525b891ea15bbf8d5cd6a56339
-- 
2.26.2

Patch

diff --git a/gdb/testsuite/gdb.arch/i386-mpx.exp b/gdb/testsuite/gdb.arch/i386-mpx.exp
index 520fd10a240..c50685cc6de 100644
--- a/gdb/testsuite/gdb.arch/i386-mpx.exp
+++ b/gdb/testsuite/gdb.arch/i386-mpx.exp
@@ -134,5 +134,3 @@  if { [skip_python_tests] } { continue }
 # Verify if size is right
 set test_string ".*\\\: size 17.*"
 gdb_test "print /x \$bnd0 = {0x10, 0x20}" "$test_string" "verify size for bnd0"
-
-send_gdb "quit\n"