Change ridiculous section size error

Message ID YV5uCloF3Ks9RZvr@squeak.grove.modra.org
State New
Headers show
Series
  • Change ridiculous section size error
Related show

Commit Message

H.J. Lu via Binutils Oct. 7, 2021, 3:48 a.m.
Rather than reporting "memory exhausted", report "file truncated".
You can hit this error on small fuzzed object files, or on files that
are actually truncated.  In either case sizes can be such that an out
of memory error is a little confusing.

	* compress.c (bfd_get_full_section_contents): Set
	bfd_error_file_truncated rather than bfd_error_no_memory when
	section size exceeds file size.


-- 
Alan Modra
Australia Development Lab, IBM

Patch

diff --git a/bfd/compress.c b/bfd/compress.c
index 6d98aec2d45..4a2ada3e3eb 100644
--- a/bfd/compress.c
+++ b/bfd/compress.c
@@ -264,7 +264,7 @@  bfd_get_full_section_contents (bfd *abfd, sec_ptr sec, bfd_byte **ptr)
 	    {
 	      /* PR 24708: Avoid attempts to allocate a ridiculous amount
 		 of memory.  */
-	      bfd_set_error (bfd_error_no_memory);
+	      bfd_set_error (bfd_error_file_truncated);
 	      _bfd_error_handler
 		/* xgettext:c-format */
 		(_("error: %pB(%pA) section size (%#" PRIx64 " bytes) is larger than file size (%#" PRIx64 " bytes)"),