[committed,gdb/testsuite] Add untested case in gdb.gdb/complaints.exp

Message ID 6428cc1d-0291-72d5-f0d6-bc5b5b7a5b27@suse.de
State New
Headers show
Series
  • [committed,gdb/testsuite] Add untested case in gdb.gdb/complaints.exp
Related show

Commit Message

Tom Tromey via Gdb-patches Sept. 3, 2021, 2:40 p.m.
[ was: re: [PATCH][gdb/testsuite] Add untested case in selftest_setup ]

On 9/3/21 2:24 PM, Simon Marchi wrote:
> On 2021-09-02 2:13 a.m., Tom de Vries via Gdb-patches wrote:

>> Any comments?

> 

> I don't see what else we could do in this case, so LGTM.

> 


Thanks for the review, pushed.

Also pushed a similar fix for a similar problem in gdb.gdb/complaints.exp.

Thanks,
- Tom

Patch

[gdb/testsuite] Add untested case in gdb.gdb/complaints.exp

When building gdb with "-Wall -O2 -g -flto=auto", I run into:
...
(gdb) call clear_complaints()^M
No symbol "clear_complaints" in current context.^M
(gdb) FAIL: gdb.gdb/complaints.exp: clear complaints
...

The problem is that lto has optimized away clear_complaints, and consequently
the selftests cannot run.

Fix this by:
- using info function to detect presence of clear_complaints
- handling the absence of clear_complaints by calling untested
...
(gdb) UNTESTED: gdb.gdb/complaints.exp: \
  Cannot find clear_complaints, skipping test
...

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2021-09-03  Tom de Vries  <tdevries@suse.de>

	* gdb.gdb/complaints.exp: Use untested if clear_complaints cannot
	be found.

---
 gdb/testsuite/gdb.gdb/complaints.exp | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gdb/testsuite/gdb.gdb/complaints.exp b/gdb/testsuite/gdb.gdb/complaints.exp
index c70825b6623..2391d661250 100644
--- a/gdb/testsuite/gdb.gdb/complaints.exp
+++ b/gdb/testsuite/gdb.gdb/complaints.exp
@@ -104,6 +104,26 @@  proc test_empty_complaint { cmd msg } {
 }
 
 proc test_empty_complaints { } {
+    global decimal
+
+    set re [multi_line \
+		"All functions matching regular expression \[^:\]*:" \
+		"" \
+		"File \[^\r\n\]*/complaints\\.c:" \
+		"$decimal:\tvoid clear_complaints\\(\\);"]
+
+    set found 0
+    gdb_test_multiple "info function ^clear_complaints()$" "" {
+	-re -wrap $re {
+	    set found 1
+	}
+	-re -wrap "" {
+	}
+    }
+    if { ! $found } {
+	untested "Cannot find clear_complaints, skipping test"
+	return 0
+    }
 
     test_empty_complaint "call clear_complaints()" \
 	    "clear complaints"