Fixes for the finish-reverse-bkpt.exp test.

Message ID ac30b9acc4e76d6647254c220c62d65432f9c93b.camel@us.ibm.com
State New
Headers show
Series
  • Fixes for the finish-reverse-bkpt.exp test.
Related show

Commit Message

Simon Marchi via Gdb-patches July 21, 2021, 5:31 p.m.
GDB maintainers:

The following patch fixes the expected format for the printing of the
Breakpoint.  The output no longer appears to have a comma before the
function name.  

This patch was tested on Power 9 and Intel without any regression
errors.

Please let me know if it is acceptable.

                            Carl Love
----------------------------------------------------

Fixes for the finish-reverse-bkpt.exp test.

The gdb output format does not have a comma before the function name.

gdb/testsuite/ChangeLog
2021-07-20  Carl Love  <cel@us.ibm.com>
	*gdb.reverse/finish-reverse-bkpt.exp: Fix expected output.
---
 gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.17.1

Comments

Joel Brobecker Aug. 1, 2021, 3:52 p.m. | #1
Hi Carl,

On Wed, Jul 21, 2021 at 10:31:12AM -0700, Carl Love via Gdb-patches wrote:
> GDB maintainers:

> 

> The following patch fixes the expected format for the printing of the

> Breakpoint.  The output no longer appears to have a comma before the

> function name.  


I'd like us to dig a little more about this, as the behavior
you described is not what I would have expected. And looking at
the code, this is not what I see either. But perhaps I'm looking
at the wrong place!

I think it's always useful to copy paste the behavior you are
getting, so others could see it too.

Also, if the behavior changed, can we identify the change that
caused it, and determine whether the change was intentional?

Thank you.

> 

> This patch was tested on Power 9 and Intel without any regression

> errors.

> 

> Please let me know if it is acceptable.

> 

>                             Carl Love

> ----------------------------------------------------

> 

> Fixes for the finish-reverse-bkpt.exp test.

> 

> The gdb output format does not have a comma before the function name.

> 

> gdb/testsuite/ChangeLog

> 2021-07-20  Carl Love  <cel@us.ibm.com>

> 	*gdb.reverse/finish-reverse-bkpt.exp: Fix expected output.

> ---

>  gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp b/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp

> index 5ebc8b5d11b..2b1b2609676 100644

> --- a/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp

> +++ b/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp

> @@ -55,7 +55,7 @@ gdb_test "break \*void_func" \

>      "set breakpoint at void_func's entry"

>  

>  gdb_test "reverse-finish" \

> -    ".*Breakpoint .*, void_func.*" \

> +    ".*Breakpoint .* void_func.*" \

>      "reverse-finish from void_func trips breakpoint at entry"

>  

> -gdb_test "frame" "#0  void_func.*" "no spurious proceed after breakpoint stop"

> +gdb_test "frame" "#0  .*void_func.*" "no spurious proceed after breakpoint stop"

> -- 

> 2.17.1

> 

> 


-- 
Joel

Patch

diff --git a/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp b/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp
index 5ebc8b5d11b..2b1b2609676 100644
--- a/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp
+++ b/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp
@@ -55,7 +55,7 @@  gdb_test "break \*void_func" \
     "set breakpoint at void_func's entry"
 
 gdb_test "reverse-finish" \
-    ".*Breakpoint .*, void_func.*" \
+    ".*Breakpoint .* void_func.*" \
     "reverse-finish from void_func trips breakpoint at entry"
 
-gdb_test "frame" "#0  void_func.*" "no spurious proceed after breakpoint stop"
+gdb_test "frame" "#0  .*void_func.*" "no spurious proceed after breakpoint stop"