[1/3] Fix all DUPLICATE problems in testsuite/gdb.perf/

Message ID 20210706114323.4177388-2-pedro@palves.net
State New
Headers show
Series
  • Fix remainder of "make check-perf" bit rot
Related show

Commit Message

Pedro Alves July 6, 2021, 11:43 a.m.
Currently running "make check-perf" shows:

 ...
 # of duplicate test names       6008
 ...

All those duplicate test names come from gdb.perf/skip-command.exp.
This commit fixes them, using with_test_prefix.

gdb/testsuite/
yyyy-mm-dd  Pedro Alves  <pedro@palves.net>

	* gdb.perf/skip-command.exp (run_skip_bench): Wrap each for
	iteration in with_test_prefix.

Change-Id: I38501cf70bc6b60306ee7228996ee7bcd858dc1b
---
 gdb/testsuite/gdb.perf/skip-command.exp | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

-- 
2.26.2

Patch

diff --git a/gdb/testsuite/gdb.perf/skip-command.exp b/gdb/testsuite/gdb.perf/skip-command.exp
index e396262af06..d9f31a7e8f5 100644
--- a/gdb/testsuite/gdb.perf/skip-command.exp
+++ b/gdb/testsuite/gdb.perf/skip-command.exp
@@ -101,9 +101,12 @@  proc run_skip_bench { kind text } {
     gdb_test_no_output "set variable flag = 1"
 
     for { set i 0 } { $i < 5 } { incr i } {
-	set nr_skips [expr $i * $SKIP_DIRECTIVE_COUNT]
-	install_skips $kind $text $nr_skips
-	gdb_test_python_run "SkipCommand\(\"skip-$kind-$nr_skips\", ${SKIP_STEP_COUNT}\)"
+	with_test_prefix "iter $i" {
+	    set nr_skips [expr $i * $SKIP_DIRECTIVE_COUNT]
+	    install_skips $kind $text $nr_skips
+	    gdb_test_python_run \
+		"SkipCommand\(\"skip-$kind-$nr_skips\", ${SKIP_STEP_COUNT}\)"
+	}
     }
 
     gdb_test "set variable flag = 0"