[RFA] Fix build failure on visium & iq2000

Message ID 18957427-ae98-5e51-37e8-437ffea2419a@gmail.com
State New
Headers show
Series
  • [RFA] Fix build failure on visium & iq2000
Related show

Commit Message

Jeff Law July 2, 2021, 5:23 p.m.
visium and iq2000 have libgloss configure bits that reference 
target_makefile_frag, but it's never set. This leads to failures during 
the configure process and an empty libgloss/<target>/Makefile.  
Naturally bad things happen with an empty Makefile.

This patch initializes target_makefile_frag for both targets in their 
configure.in files and updates the generated configure files.  This 
fixes the build failures.  I've been using it in my tester for about a 
week and both targets have flipped from consistently failing to 
consistently passing.



     * libgloss/visium/configure.in (target_makefile_frag): Define.
     * libgloss/visium/configure: Regenerated.
     * libgloss/iq2000/configure.in (target_makefile_frag): Define.
     * libgloss/iq2000/configure: Regenerated.


OK for the trunk?  I think I've still got commit privs.

Jeff

Comments

Jeff Johnston July 5, 2021, 8:46 p.m. | #1
Hi Jeff,

Go ahead if you have commit privileges.  Otherwise, let me know and I'll
post it for you.

-- Jeff J.

On Fri, Jul 2, 2021 at 1:24 PM Jeff Law <jeffreyalaw@gmail.com> wrote:

> visium and iq2000 have libgloss configure bits that reference

> target_makefile_frag, but it's never set. This leads to failures during

> the configure process and an empty libgloss/<target>/Makefile.

> Naturally bad things happen with an empty Makefile.

>

> This patch initializes target_makefile_frag for both targets in their

> configure.in files and updates the generated configure files.  This

> fixes the build failures.  I've been using it in my tester for about a

> week and both targets have flipped from consistently failing to

> consistently passing.

>

>

>

>      * libgloss/visium/configure.in (target_makefile_frag): Define.

>      * libgloss/visium/configure: Regenerated.

>      * libgloss/iq2000/configure.in (target_makefile_frag): Define.

>      * libgloss/iq2000/configure: Regenerated.

>

>

> OK for the trunk?  I think I've still got commit privs.

>

> Jeff

>
Jeff Law July 6, 2021, 3:15 p.m. | #2
On 7/5/2021 2:46 PM, Jeff Johnston wrote:
> Hi Jeff,

>

> Go ahead if you have commit privileges.  Otherwise, let me know and 

> I'll post it for you.

Thanks.  Done.
jeff

Patch

diff --git a/libgloss/iq2000/configure.in b/libgloss/iq2000/configure.in
index 9cbd7e2ea..754ee3cab 100644
--- a/libgloss/iq2000/configure.in
+++ b/libgloss/iq2000/configure.in
@@ -46,6 +46,7 @@  AC_PROG_RANLIB
 LIB_AM_PROG_AS
 
 host_makefile_frag=${srcdir}/../config/default.mh
+target_makefile_frag=${srcdir}/../config/default.mt
 
 if test "${with_multisubdir}" = "m32"; then
   LD_TYPE="m32"
diff --git a/libgloss/visium/configure.in b/libgloss/visium/configure.in
index 33c1872c7..5274ba668 100644
--- a/libgloss/visium/configure.in
+++ b/libgloss/visium/configure.in
@@ -33,6 +33,7 @@  AC_PROG_RANLIB
 LIB_AM_PROG_AS
 
 host_makefile_frag=${srcdir}/../config/default.mh
+target_makefile_frag=${srcdir}/../config/default.mt
 
 dnl We have to assign the same value to other variables because autoconf
 dnl doesn't provide a mechanism to substitute a replacement keyword with
diff --git a/libgloss/iq2000/configure b/libgloss/iq2000/configure
index 66a533bc8..4411837d4 100755
--- a/libgloss/iq2000/configure
+++ b/libgloss/iq2000/configure
@@ -2520,6 +2520,7 @@  test "${CCASFLAGS+set}" = set || CCASFLAGS=$CFLAGS
 
 
 host_makefile_frag=${srcdir}/../config/default.mh
+target_makefile_frag=${srcdir}/../config/default.mt
 
 if test "${with_multisubdir}" = "m32"; then
   LD_TYPE="m32"
diff --git a/libgloss/visium/configure b/libgloss/visium/configure
index f1bb39a11..abd6f5b92 100755
--- a/libgloss/visium/configure
+++ b/libgloss/visium/configure
@@ -1946,6 +1946,7 @@  test "${CCASFLAGS+set}" = set || CCASFLAGS=$CFLAGS
 
 
 host_makefile_frag=${srcdir}/../config/default.mh
+target_makefile_frag=${srcdir}/../config/default.mt
 
 host_makefile_frag_path=$host_makefile_frag