PR28048, heap-buffer-overflow on readelf -Ww

Message ID YN8Zwo42HQepeN8d@squeak.grove.modra.org
State New
Headers show
Series
  • PR28048, heap-buffer-overflow on readelf -Ww
Related show

Commit Message

H.J. Lu via Binutils July 2, 2021, 1:50 p.m.
PR 28048
	* dwarf.c (get_type_signedness): Don't run off end of buffer
	printing DW_FORM_string attribute.


-- 
Alan Modra
Australia Development Lab, IBM

Patch

diff --git a/binutils/dwarf.c b/binutils/dwarf.c
index de9d2b8c8f5..1e7f4db7b7c 100644
--- a/binutils/dwarf.c
+++ b/binutils/dwarf.c
@@ -2211,7 +2211,7 @@  get_type_signedness (abbrev_entry *entry,
 	      if (attr->form == DW_FORM_strp)
 		printf (", %s", fetch_indirect_string (uvalue));
 	      else if (attr->form == DW_FORM_string)
-		printf (", %s", orig_data);
+		printf (", %.*s", (int) (end - orig_data), orig_data);
 	    }
 	  break;