[1/2] gdb: remove gdbarch_info::tdep_info

Message ID 20210623192717.3460363-1-simon.marchi@polymtl.ca
State New
Headers show
Series
  • [1/2] gdb: remove gdbarch_info::tdep_info
Related show

Commit Message

Eli Zaretskii via Gdb-patches June 23, 2021, 7:27 p.m.
This field is not actually used, remove it.

gdb/ChangeLog:

	* gdbarch.sh (struct gdbarch_info) <tdep_info>: Remove.
	(gdbarch_find_by_info): Remove print.

Change-Id: I00af4681b8e1a27727441cbadc3827f5914bd8eb
---
 gdb/gdbarch.c  | 3 ---
 gdb/gdbarch.h  | 4 ----
 gdb/gdbarch.sh | 7 -------
 3 files changed, 14 deletions(-)

-- 
2.32.0

Comments

Andrew Burgess June 25, 2021, 8:24 p.m. | #1
* Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> [2021-06-23 15:27:16 -0400]:

> This field is not actually used, remove it.

> 

> gdb/ChangeLog:

> 

> 	* gdbarch.sh (struct gdbarch_info) <tdep_info>: Remove.

> 	(gdbarch_find_by_info): Remove print.


Shouldn't this ChangeLog have 'gdbarch.{ch}: Regenerate.' too?

Otherwise, LGTM.

thanks,
Andrew


> 

> Change-Id: I00af4681b8e1a27727441cbadc3827f5914bd8eb

> ---

>  gdb/gdbarch.c  | 3 ---

>  gdb/gdbarch.h  | 4 ----

>  gdb/gdbarch.sh | 7 -------

>  3 files changed, 14 deletions(-)

> 

> diff --git a/gdb/gdbarch.c b/gdb/gdbarch.c

> index 208cf4b5aaab..830a86df89f3 100644

> --- a/gdb/gdbarch.c

> +++ b/gdb/gdbarch.c

> @@ -5695,9 +5695,6 @@ gdbarch_find_by_info (struct gdbarch_info info)

>        fprintf_unfiltered (gdb_stdlog,

>  			  "gdbarch_find_by_info: info.abfd %s\n",

>  			  host_address_to_string (info.abfd));

> -      fprintf_unfiltered (gdb_stdlog,

> -			  "gdbarch_find_by_info: info.tdep_info %s\n",

> -			  host_address_to_string (info.tdep_info));

>      }

>  

>    /* Find the tdep code that knows about this architecture.  */

> diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h

> index 7157e5596fd3..36ea4de17c8c 100644

> --- a/gdb/gdbarch.h

> +++ b/gdb/gdbarch.h

> @@ -1795,10 +1795,6 @@ struct gdbarch_info

>    /* Use default: NULL (ZERO).  */

>    union

>      {

> -      /* Architecture-specific information.  The generic form for targets

> -	 that have extra requirements.  */

> -      struct gdbarch_tdep_info *tdep_info;

> -

>        /* Architecture-specific target description data.  Numerous targets

>  	 need only this, so give them an easy way to hold it.  */

>        struct tdesc_arch_data *tdesc_data;

> diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh

> index 43e51341f97b..01a5ac88219d 100755

> --- a/gdb/gdbarch.sh

> +++ b/gdb/gdbarch.sh

> @@ -1547,10 +1547,6 @@ struct gdbarch_info

>    /* Use default: NULL (ZERO).  */

>    union

>      {

> -      /* Architecture-specific information.  The generic form for targets

> -	 that have extra requirements.  */

> -      struct gdbarch_tdep_info *tdep_info;

> -

>        /* Architecture-specific target description data.  Numerous targets

>  	 need only this, so give them an easy way to hold it.  */

>        struct tdesc_arch_data *tdesc_data;

> @@ -2479,9 +2475,6 @@ gdbarch_find_by_info (struct gdbarch_info info)

>        fprintf_unfiltered (gdb_stdlog,

>  			  "gdbarch_find_by_info: info.abfd %s\n",

>  			  host_address_to_string (info.abfd));

> -      fprintf_unfiltered (gdb_stdlog,

> -			  "gdbarch_find_by_info: info.tdep_info %s\n",

> -			  host_address_to_string (info.tdep_info));

>      }

>  

>    /* Find the tdep code that knows about this architecture.  */

> -- 

> 2.32.0

>
Eli Zaretskii via Gdb-patches June 25, 2021, 8:37 p.m. | #2
On 2021-06-25 4:24 p.m., Andrew Burgess wrote:
> * Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> [2021-06-23 15:27:16 -0400]:

> 

>> This field is not actually used, remove it.

>>

>> gdb/ChangeLog:

>>

>> 	* gdbarch.sh (struct gdbarch_info) <tdep_info>: Remove.

>> 	(gdbarch_find_by_info): Remove print.

> 

> Shouldn't this ChangeLog have 'gdbarch.{ch}: Regenerate.' too?

> 

> Otherwise, LGTM.

> 

> thanks,

> Andrew


Oh, yes, will add.  Thanks!

Simon

Patch

diff --git a/gdb/gdbarch.c b/gdb/gdbarch.c
index 208cf4b5aaab..830a86df89f3 100644
--- a/gdb/gdbarch.c
+++ b/gdb/gdbarch.c
@@ -5695,9 +5695,6 @@  gdbarch_find_by_info (struct gdbarch_info info)
       fprintf_unfiltered (gdb_stdlog,
 			  "gdbarch_find_by_info: info.abfd %s\n",
 			  host_address_to_string (info.abfd));
-      fprintf_unfiltered (gdb_stdlog,
-			  "gdbarch_find_by_info: info.tdep_info %s\n",
-			  host_address_to_string (info.tdep_info));
     }
 
   /* Find the tdep code that knows about this architecture.  */
diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h
index 7157e5596fd3..36ea4de17c8c 100644
--- a/gdb/gdbarch.h
+++ b/gdb/gdbarch.h
@@ -1795,10 +1795,6 @@  struct gdbarch_info
   /* Use default: NULL (ZERO).  */
   union
     {
-      /* Architecture-specific information.  The generic form for targets
-	 that have extra requirements.  */
-      struct gdbarch_tdep_info *tdep_info;
-
       /* Architecture-specific target description data.  Numerous targets
 	 need only this, so give them an easy way to hold it.  */
       struct tdesc_arch_data *tdesc_data;
diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh
index 43e51341f97b..01a5ac88219d 100755
--- a/gdb/gdbarch.sh
+++ b/gdb/gdbarch.sh
@@ -1547,10 +1547,6 @@  struct gdbarch_info
   /* Use default: NULL (ZERO).  */
   union
     {
-      /* Architecture-specific information.  The generic form for targets
-	 that have extra requirements.  */
-      struct gdbarch_tdep_info *tdep_info;
-
       /* Architecture-specific target description data.  Numerous targets
 	 need only this, so give them an easy way to hold it.  */
       struct tdesc_arch_data *tdesc_data;
@@ -2479,9 +2475,6 @@  gdbarch_find_by_info (struct gdbarch_info info)
       fprintf_unfiltered (gdb_stdlog,
 			  "gdbarch_find_by_info: info.abfd %s\n",
 			  host_address_to_string (info.abfd));
-      fprintf_unfiltered (gdb_stdlog,
-			  "gdbarch_find_by_info: info.tdep_info %s\n",
-			  host_address_to_string (info.tdep_info));
     }
 
   /* Find the tdep code that knows about this architecture.  */