[committed,gdb/testsuite] Fix gdb.threads/multi-create-ns-info-thr.exp

Message ID 20210608080628.GA14656@delia
State New
Headers show
Series
  • [committed,gdb/testsuite] Fix gdb.threads/multi-create-ns-info-thr.exp
Related show

Commit Message

Tom de Vries June 8, 2021, 8:06 a.m.
Hi,

With a testsuite setup modified to make expect wait a little bit longer for
gdb output (see PR27957), I reliably run into:
...
PASS: gdb.threads/multi-create-ns-info-thr.exp: continue to breakpoint 1
FAIL: gdb.threads/multi-create-ns-info-thr.exp: continue to breakpoint 2 \
  (timeout)
...

This is due to this regexp:
...
       -re "Breakpoint $decimal,.*$srcfile:$bp_location1" {
...
consuming several lines using the ".*" part, while it's intended to match one
line looking like this:
...
Thread 1 "multi-create-ns" hit Breakpoint 2, create_function () \
  at multi-create.c:45^M
...

Fix this by limiting the regexp to one line.

Committed to trunk.

Thanks,
- Tom

[gdb/testsuite] Fix gdb.threads/multi-create-ns-info-thr.exp

gdb/testsuite/ChangeLog:

2021-06-08  Tom de Vries  <tdevries@suse.de>

	* gdb.threads/multi-create-ns-info-thr.exp: Limit breakpoint regexp to
	one line.

---
 gdb/testsuite/gdb.threads/multi-create-ns-info-thr.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/gdb/testsuite/gdb.threads/multi-create-ns-info-thr.exp b/gdb/testsuite/gdb.threads/multi-create-ns-info-thr.exp
index 2fb52238798..1b32637e877 100644
--- a/gdb/testsuite/gdb.threads/multi-create-ns-info-thr.exp
+++ b/gdb/testsuite/gdb.threads/multi-create-ns-info-thr.exp
@@ -45,7 +45,7 @@  gdb_test_multiple $test $test {
 for {set i 0} {$i < 32} {incr i} {
     set test "continue to breakpoint $i"
     gdb_test_multiple "" $test {
-	-re "Breakpoint $decimal,.*$srcfile:$bp_location1" {
+	-re "Breakpoint $decimal,\[^\r\n\]*$srcfile:$bp_location1" {
 	    pass $test
 	}
     }