[2/8] x86: remove pointless 2nd parameter from check_VecOperations()

Message ID fe6e0f76-19f8-a4b7-5cef-82ae8620e7a4@suse.com
State New
Headers show
Series
  • x86: some tidying and quoted symbols fixes
Related show

Commit Message

Alan Modra via Binutils June 4, 2021, 1:39 p.m.
In the one case where non-NULL gets passed, passing NULL has the same
effect. Hence the parameter is not needed at all.

gas/
2021-06-XX  Jan Beulich  <jbeulich@suse.com>

	* config/tc-i386.c (check_VecOperations): Remove 2nd parameter.
	(i386_att_operand): Adjust calls to check_VecOperations.
	* config/tc-i386-intel.c (i386_intel_operand): Likewise.

Patch

--- a/gas/config/tc-i386-intel.c
+++ b/gas/config/tc-i386-intel.c
@@ -606,7 +606,7 @@  i386_intel_operand (char *operand_string
   /* Handle vector operations.  */
   if (*input_line_pointer == '{')
     {
-      char *end = check_VecOperations (input_line_pointer, NULL);
+      char *end = check_VecOperations (input_line_pointer);
       if (end)
 	input_line_pointer = end;
       else
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -10510,14 +10510,13 @@  pe_directive_secrel (int dummy ATTRIBUTE
 /* Handle Vector operations.  */
 
 static char *
-check_VecOperations (char *op_string, char *op_end)
+check_VecOperations (char *op_string)
 {
   const reg_entry *mask;
   const char *saved;
   char *end_op;
 
-  while (*op_string
-	 && (op_end == NULL || op_string < op_end))
+  while (*op_string)
     {
       saved = op_string;
       if (*op_string == '{')
@@ -11446,7 +11445,7 @@  i386_att_operand (char *operand_string)
       /* Handle vector operations.  */
       if (*op_string == '{')
 	{
-	  op_string = check_VecOperations (op_string, NULL);
+	  op_string = check_VecOperations (op_string);
 	  if (op_string == NULL)
 	    return 0;
 	}
@@ -11520,7 +11519,7 @@  i386_att_operand (char *operand_string)
       vop_start = strchr (op_string, '{');
       if (vop_start && vop_start < base_string)
 	{
-	  if (check_VecOperations (vop_start, base_string) == NULL)
+	  if (check_VecOperations (vop_start) == NULL)
 	    return 0;
 	  base_string = vop_start;
 	}