[committed,01/18] MIPS/GAS: Use FCSR rather than RA with CFC1/CTC1

Message ID alpine.DEB.2.21.2105271502310.11113@angie.orcam.me.uk
State New
Headers show
  • MIPS coprocessor opcodes handling fixes
Related show

Commit Message

Maciej W. Rozycki May 29, 2021, 1:36 a.m.
Fix an issue caused by commit f9419b056fe2 ("MIPS gas: code cleanup"), 
<https://sourceware.org/ml/binutils/2002-05/msg00192.html>, and replace 
the incorrect use of RA with the CFC1 and CTC1 instructions with FCSR.  
While the register referred by its number is $31 in both cases, these 
instructions operate on the floating-point control register file rather 
than general-purpose registers.

	* config/tc-mips.c (FCSR): New macro.
	(macro) <M_TRUNCWS, M_TRUNCWD>: Use it in place of RA.
 gas/config/tc-mips.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)



Index: binutils-gdb/gas/config/tc-mips.c
--- binutils-gdb.orig/gas/config/tc-mips.c
+++ binutils-gdb/gas/config/tc-mips.c
@@ -104,6 +104,8 @@  static char *mips_flags_frag;
 #define FP  30
 #define RA  31
+#define FCSR 31
 #define ILLEGAL_REG (32)
 #define AT  mips_opts.at
@@ -13835,18 +13837,18 @@  macro (struct mips_cl_insn *ip, char *st
        * or is there a reason for it?
       start_noreorder ();
-      macro_build (NULL, "cfc1", "t,G", op[2], RA);
-      macro_build (NULL, "cfc1", "t,G", op[2], RA);
+      macro_build (NULL, "cfc1", "t,G", op[2], FCSR);
+      macro_build (NULL, "cfc1", "t,G", op[2], FCSR);
       macro_build (NULL, "nop", "");
       expr1.X_add_number = 3;
       macro_build (&expr1, "ori", "t,r,i", AT, op[2], BFD_RELOC_LO16);
       expr1.X_add_number = 2;
       macro_build (&expr1, "xori", "t,r,i", AT, AT, BFD_RELOC_LO16);
-      macro_build (NULL, "ctc1", "t,G", AT, RA);
+      macro_build (NULL, "ctc1", "t,G", AT, FCSR);
       macro_build (NULL, "nop", "");
       macro_build (NULL, mask == M_TRUNCWD ? "cvt.w.d" : "cvt.w.s", "D,S",
 		   op[0], op[1]);
-      macro_build (NULL, "ctc1", "t,G", op[2], RA);
+      macro_build (NULL, "ctc1", "t,G", op[2], FCSR);
       macro_build (NULL, "nop", "");
       end_noreorder ();