PR27858, global-buffer-overflow

Message ID 20210513005134.GS25246@bubble.grove.modra.org
State New
Headers show
Series
  • PR27858, global-buffer-overflow
Related show

Commit Message

H.J. Lu via Binutils May 13, 2021, 12:51 a.m.
elf32-sh-relocs.h maxes out before R_SH_max.

	PR 27858
	* elf32-sh.c (sh_elf_info_to_howto): Correct check for last valid
	reloc howto.


-- 
Alan Modra
Australia Development Lab, IBM

Patch

diff --git a/bfd/elf32-sh.c b/bfd/elf32-sh.c
index dae248f50e6..fe2ffc9cb19 100644
--- a/bfd/elf32-sh.c
+++ b/bfd/elf32-sh.c
@@ -426,13 +426,12 @@  sh_elf_info_to_howto (bfd *abfd, arelent *cache_ptr, Elf_Internal_Rela *dst)
 
   r = ELF32_R_TYPE (dst->r_info);
 
-  if (r >= R_SH_max
+  if (r >= R_SH_FIRST_INVALID_RELOC_6
       || (r >= R_SH_FIRST_INVALID_RELOC   && r <= R_SH_LAST_INVALID_RELOC)
       || (r >= R_SH_FIRST_INVALID_RELOC_2 && r <= R_SH_LAST_INVALID_RELOC_2)
       || (r >= R_SH_FIRST_INVALID_RELOC_3 && r <= R_SH_LAST_INVALID_RELOC_3)
       || (r >= R_SH_FIRST_INVALID_RELOC_4 && r <= R_SH_LAST_INVALID_RELOC_4)
-      || (r >= R_SH_FIRST_INVALID_RELOC_5 && r <= R_SH_LAST_INVALID_RELOC_5)
-      || (r >= R_SH_FIRST_INVALID_RELOC_6 && r <= R_SH_LAST_INVALID_RELOC_6))
+      || (r >= R_SH_FIRST_INVALID_RELOC_5 && r <= R_SH_LAST_INVALID_RELOC_5))
     {
       /* xgettext:c-format */
       _bfd_error_handler (_("%pB: unsupported relocation type %#x"),