[PATCH/committed] sim: riscv: switch MIN/MAX to common min/max

Message ID 20210427032933.22872-1-vapier@gentoo.org
State New
Headers show
Series
  • [PATCH/committed] sim: riscv: switch MIN/MAX to common min/max
Related show

Commit Message

Pedro Franco de Carvalho via Gdb-patches April 27, 2021, 3:29 a.m.
The common sim-basics.h defines min/max already, so use them.
---
 sim/riscv/ChangeLog  |  5 +++++
 sim/riscv/sim-main.c | 11 ++++-------
 2 files changed, 9 insertions(+), 7 deletions(-)

-- 
2.30.2

Patch

diff --git a/sim/riscv/ChangeLog b/sim/riscv/ChangeLog
index 099391332151..37284a982a9b 100644
--- a/sim/riscv/ChangeLog
+++ b/sim/riscv/ChangeLog
@@ -1,3 +1,8 @@ 
+2021-04-26  Mike Frysinger  <vapier@gentoo.org>
+
+	* sim-main.c (MAX, MIN): Delete.
+	(execute_a): Change MAX/MIN to max/min.
+
 2021-04-26  Mike Frysinger  <vapier@gentoo.org>
 
 	* aclocal.m4, config.in, configure: Regenerate.
diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c
index ff328a0dc204..a80dc6838260 100644
--- a/sim/riscv/sim-main.c
+++ b/sim/riscv/sim-main.c
@@ -789,9 +789,6 @@  execute_m (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op)
   return pc;
 }
 
-#define MAX(a, b) ((a) > (b) ? (a) : (b))
-#define MIN(a, b) ((a) < (b) ? (a) : (b))
-
 static sim_cia
 execute_a (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op)
 {
@@ -881,19 +878,19 @@  execute_a (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op)
       break;
     case MATCH_AMOMAX_D:
     case MATCH_AMOMAX_W:
-      tmp = MAX ((signed_word) cpu->regs[rd], (signed_word) cpu->regs[rs2]);
+      tmp = max ((signed_word) cpu->regs[rd], (signed_word) cpu->regs[rs2]);
       break;
     case MATCH_AMOMAXU_D:
     case MATCH_AMOMAXU_W:
-      tmp = MAX ((unsigned_word) cpu->regs[rd], (unsigned_word) cpu->regs[rs2]);
+      tmp = max ((unsigned_word) cpu->regs[rd], (unsigned_word) cpu->regs[rs2]);
       break;
     case MATCH_AMOMIN_D:
     case MATCH_AMOMIN_W:
-      tmp = MIN ((signed_word) cpu->regs[rd], (signed_word) cpu->regs[rs2]);
+      tmp = min ((signed_word) cpu->regs[rd], (signed_word) cpu->regs[rs2]);
       break;
     case MATCH_AMOMINU_D:
     case MATCH_AMOMINU_W:
-      tmp = MIN ((unsigned_word) cpu->regs[rd], (unsigned_word) cpu->regs[rs2]);
+      tmp = min ((unsigned_word) cpu->regs[rd], (unsigned_word) cpu->regs[rs2]);
       break;
     case MATCH_AMOOR_D:
     case MATCH_AMOOR_W: