[v2,2/3] Guile: add {r,}value-reference-value

Message ID reqd6q2z&r_q0mzf/m.83tdzy10exnscw_y3dtc0burkjr24kk7_@mail.bob131.so
State Superseded
Headers show
Series
  • Guile: add value-{reference,const}-value
Related show

Commit Message

Simon Marchi via Gdb-patches April 26, 2021, 7:36 p.m.
The Guile API doesn't currently have an equivalent to the Python API's
Value.reference_value() or Value.rvalue_reference_value(). This commit
adds a procedure with equivalent semantics to the Guile API.

gdb/ChangeLog:

2021-04-27  George Barrett  <bob@bob131.so>

	* guile/scm-value.c (gdbscm_reference_value): Add helper
	function for reference value creation.
	(gdbscm_value_reference_value): Add implementation of
	value-reference-value procedure.
	(gdbscm_rvalue_reference_value): Add implementation of
	rvalue-reference-value procedure.
	(value_functions): Add value-reference-value procedure.
	Add rvalue-reference-value procedure.

gdb/doc/ChangeLog:

2021-04-27  George Barrett  <bob@bob131.so>

	* guile.texi (Values From Inferior In Guile): Add
	documentation for value-reference-value.
	Add documentation for rvalue-reference-value.

gdb/testsuite/ChangeLog:

2021-04-27  George Barrett  <bob@bob131.so>

	* gdb.guile/scm-value.exp (test_value_in_inferior): Add test
	for value-reference-value.
	Add test for rvalue-reference-value.
---
 gdb/doc/guile.texi                    | 10 +++++++
 gdb/guile/scm-value.c                 | 42 +++++++++++++++++++++++++++
 gdb/testsuite/gdb.guile/scm-value.exp | 10 +++++++
 3 files changed, 62 insertions(+)

-- 
2.30.2

Comments

Simon Marchi via Gdb-patches April 27, 2021, 1:59 p.m. | #1
> Date: Tue, 27 Apr 2021 05:36:15 +1000

> From: George Barrett via Gdb-patches <gdb-patches@sourceware.org>

> Cc: George Barrett <bob@bob131.so>

> 

> The Guile API doesn't currently have an equivalent to the Python API's

> Value.reference_value() or Value.rvalue_reference_value(). This commit

> adds a procedure with equivalent semantics to the Guile API.

> 

> gdb/ChangeLog:

> 

> 2021-04-27  George Barrett  <bob@bob131.so>

> 

> 	* guile/scm-value.c (gdbscm_reference_value): Add helper

> 	function for reference value creation.

> 	(gdbscm_value_reference_value): Add implementation of

> 	value-reference-value procedure.

> 	(gdbscm_rvalue_reference_value): Add implementation of

> 	rvalue-reference-value procedure.

> 	(value_functions): Add value-reference-value procedure.

> 	Add rvalue-reference-value procedure.

> 

> gdb/doc/ChangeLog:

> 

> 2021-04-27  George Barrett  <bob@bob131.so>

> 

> 	* guile.texi (Values From Inferior In Guile): Add

> 	documentation for value-reference-value.

> 	Add documentation for rvalue-reference-value.

> 

> gdb/testsuite/ChangeLog:

> 

> 2021-04-27  George Barrett  <bob@bob131.so>

> 

> 	* gdb.guile/scm-value.exp (test_value_in_inferior): Add test

> 	for value-reference-value.

> 	Add test for rvalue-reference-value.


OK for the guile.texi part.

Should this change have a NEWS entry as well?
Simon Marchi via Gdb-patches April 27, 2021, 3:51 p.m. | #2
On Tue, Apr 27, 2021 at 04:59:21PM +0300, Eli Zaretskii wrote:
> OK for the guile.texi part.

> 

> Should this change have a NEWS entry as well?


I'm not sure, I'm not familiar with the rules around that. I'm guessing you
think there ought to be? If so, would you mind giving me a rough sample diff
indicating how the change should look? There appears to only be ten commits
touching both gdb/NEWS and gdb/guile and they all seem to be considerably
larger in scope than this patch series, so I'm not clear on the appropriate
formatting.

Thanks
Simon Marchi via Gdb-patches April 27, 2021, 4:06 p.m. | #3
> Date: Wed, 28 Apr 2021 01:51:50 +1000

> From: George Barrett <bob@bob131.so>

> Cc: gdb-patches@sourceware.org

> 

> On Tue, Apr 27, 2021 at 04:59:21PM +0300, Eli Zaretskii wrote:

> > OK for the guile.texi part.

> > 

> > Should this change have a NEWS entry as well?

> 

> I'm not sure, I'm not familiar with the rules around that. I'm guessing you

> think there ought to be?


I tend to think so, but I'm also asking others what do they think.

> If so, would you mind giving me a rough sample diff

> indicating how the change should look? There appears to only be ten commits

> touching both gdb/NEWS and gdb/guile and they all seem to be considerably

> larger in scope than this patch series, so I'm not clear on the appropriate

> formatting.


Look in the existing NEWS file in the "Python" section, I think you
will find there enough examples of the style and formatting.

Thanks.

Patch

diff --git a/gdb/doc/guile.texi b/gdb/doc/guile.texi
index 7f3aa2df5aa..843858ffb31 100644
--- a/gdb/doc/guile.texi
+++ b/gdb/doc/guile.texi
@@ -801,6 +801,16 @@  The @code{<gdb:value>} object @code{scm-val} is identical to that
 corresponding to @code{val}.
 @end deffn
 
+@deffn {Scheme Procedure} value-reference-value value
+Return a new @code{<gdb:value>} object which is a reference to the value
+encapsulated by @code{<gdb:value>} object @var{value}.
+@end deffn
+
+@deffn {Scheme Procedure} rvalue-reference-value value
+Return a new @code{<gdb:value>} object which is an rvalue reference to
+the value encapsulated by @code{<gdb:value>} object @var{value}.
+@end deffn
+
 @deffn {Scheme Procedure} value-field value field-name
 Return field @var{field-name} from @code{<gdb:value>} object @var{value}.
 @end deffn
diff --git a/gdb/guile/scm-value.c b/gdb/guile/scm-value.c
index f50e8b5b46c..2ab193f044a 100644
--- a/gdb/guile/scm-value.c
+++ b/gdb/guile/scm-value.c
@@ -488,6 +488,38 @@  gdbscm_value_referenced_value (SCM self)
     });
 }
 
+static SCM
+gdbscm_reference_value (SCM self, enum type_code refcode)
+{
+  value_smob *v_smob
+    = vlscm_get_value_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME);
+  struct value *value = v_smob->value;
+
+  return gdbscm_wrap ([=]
+    {
+      scoped_value_mark free_values;
+
+      struct value *res_val = value_ref (value, refcode);
+      return vlscm_scm_from_value (res_val);
+    });
+}
+
+/* (value-reference-value <gdb:value>) -> <gdb:value> */
+
+static SCM
+gdbscm_value_reference_value (SCM self)
+{
+  return gdbscm_reference_value (self, TYPE_CODE_REF);
+}
+
+/* (rvalue-reference-value <gdb:value>) -> <gdb:value> */
+
+static SCM
+gdbscm_rvalue_reference_value (SCM self)
+{
+  return gdbscm_reference_value (self, TYPE_CODE_RVALUE_REF);
+}
+
 /* (value-type <gdb:value>) -> <gdb:type> */
 
 static SCM
@@ -1352,6 +1384,16 @@  For example, for a value which is a reference to an 'int' pointer ('int *'),\n\
 value-dereference will result in a value of type 'int' while\n\
 value-referenced-value will result in a value of type 'int *'." },
 
+  { "value-reference-value", 1, 0, 0,
+    as_a_scm_t_subr (gdbscm_value_reference_value),
+    "\
+Return a <gdb:value> object which is a reference to the given value." },
+
+  { "rvalue-reference-value", 1, 0, 0,
+    as_a_scm_t_subr (gdbscm_rvalue_reference_value),
+    "\
+Return a <gdb:value> object which is an rvalue reference to the given value." },
+
   { "value-field", 2, 0, 0, as_a_scm_t_subr (gdbscm_value_field),
     "\
 Return the specified field of the value.\n\
diff --git a/gdb/testsuite/gdb.guile/scm-value.exp b/gdb/testsuite/gdb.guile/scm-value.exp
index 191af1d71a6..883c4bea72e 100644
--- a/gdb/testsuite/gdb.guile/scm-value.exp
+++ b/gdb/testsuite/gdb.guile/scm-value.exp
@@ -173,6 +173,16 @@  proc test_value_in_inferior {} {
 	"get string beyond null"
     gdb_test "gu (print nullst)" \
 	"= divide\\\\000et"
+
+    gdb_scm_test_silent_cmd "gu (define argv-ref (value-reference-value argv))" \
+	"test value-reference-value"
+    gdb_test "gu (equal? argv (value-referenced-value argv-ref))" "#t"
+    gdb_test "gu (eqv? (type-code (value-type argv-ref)) TYPE_CODE_REF)" "#t"
+
+    gdb_scm_test_silent_cmd "gu (define argv-rref (rvalue-reference-value argv))" \
+	"test rvalue-reference-value"
+    gdb_test "gu (equal? argv (value-referenced-value argv-rref))" "#t"
+    gdb_test "gu (eqv? (type-code (value-type argv-rref)) TYPE_CODE_RVALUE_REF)" "#t"
 }
 
 proc test_strings {} {