[2/2] Guile: add value-const-value

Message ID icrj1al7yts/o/f12h.ag.44l89yov1xz56rcgx&2q_3g0o09qac@mail.bob131.so
State New
Headers show
Series
  • Guile: add value-{reference,const}-value
Related show

Commit Message

Pedro Franco de Carvalho via Gdb-patches April 26, 2021, 12:49 a.m.
The Guile API doesn't currently have an equivalent to the Python API's
gdb.Value.const_value(). This commit adds a procedure with equivalent
semantics to the Guile API.

gdb/ChangeLog:

2021-04-26  George Barrett  <bob@bob131.so>

	guile/scm-value.c (gdbscm_value_const_value): Add
	implementation of value-const-value procedure.
	(value_functions): Add value-const-value procedure.

gdb/doc/ChangeLog:

2021-04-26  George Barrett  <bob@bob131.so>

	guile.texi (Values From Inferior In Guile): Add documentation
	for value-const-value.

gdb/testsuite/ChangeLog:

2021-04-26  George Barrett  <bob@bob131.so>

	gdb.guile/scm-value.exp (test_value_in_inferior): Add test
	for value-const-value.
---
 gdb/doc/guile.texi                    |  5 +++++
 gdb/guile/scm-value.c                 | 23 +++++++++++++++++++++++
 gdb/testsuite/gdb.guile/scm-value.exp |  3 +++
 3 files changed, 31 insertions(+)

-- 
2.30.2

Comments

Andrew Burgess April 26, 2021, 10:07 a.m. | #1
* George Barrett via Gdb-patches <gdb-patches@sourceware.org> [2021-04-26 10:49:56 +1000]:

> The Guile API doesn't currently have an equivalent to the Python API's

> gdb.Value.const_value(). This commit adds a procedure with equivalent

> semantics to the Guile API.

> 

> gdb/ChangeLog:

> 

> 2021-04-26  George Barrett  <bob@bob131.so>

> 

> 	guile/scm-value.c (gdbscm_value_const_value): Add

> 	implementation of value-const-value procedure.

> 	(value_functions): Add value-const-value procedure.

> 

> gdb/doc/ChangeLog:

> 

> 2021-04-26  George Barrett  <bob@bob131.so>

> 

> 	guile.texi (Values From Inferior In Guile): Add documentation

> 	for value-const-value.

> 

> gdb/testsuite/ChangeLog:

> 

> 2021-04-26  George Barrett  <bob@bob131.so>

> 

> 	gdb.guile/scm-value.exp (test_value_in_inferior): Add test

> 	for value-const-value.


The code parts of this look good to me.  Eli will usually review the
doc part.

Thanks,
Andrew


> ---

>  gdb/doc/guile.texi                    |  5 +++++

>  gdb/guile/scm-value.c                 | 23 +++++++++++++++++++++++

>  gdb/testsuite/gdb.guile/scm-value.exp |  3 +++

>  3 files changed, 31 insertions(+)

> 

> diff --git a/gdb/doc/guile.texi b/gdb/doc/guile.texi

> index eed94366027..8ad9bb8f82e 100644

> --- a/gdb/doc/guile.texi

> +++ b/gdb/doc/guile.texi

> @@ -806,6 +806,11 @@ Return a new @code{<gdb:value>} object which is a reference to the value

>  encapsulated by @code{<gdb:value>} object @var{value}.

>  @end deffn

>  

> +@deffn {Scheme Procedure} value-const-value value

> +Return a new @code{<gdb:value>} object which is a 'const' version of

> +@code{<gdb:value>} object @var{value}.

> +@end deffn

> +

>  @deffn {Scheme Procedure} value-field value field-name

>  Return field @var{field-name} from @code{<gdb:value>} object @var{value}.

>  @end deffn

> diff --git a/gdb/guile/scm-value.c b/gdb/guile/scm-value.c

> index dc59633ec6f..22a9902317c 100644

> --- a/gdb/guile/scm-value.c

> +++ b/gdb/guile/scm-value.c

> @@ -505,6 +505,24 @@ gdbscm_value_reference_value (SCM self)

>      });

>  }

>  

> +/* (value-const-value <gdb:value>) -> <gdb:value> */

> +

> +static SCM

> +gdbscm_value_const_value (SCM self)

> +{

> +  value_smob *v_smob

> +    = vlscm_get_value_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME);

> +  struct value *value = v_smob->value;

> +

> +  return gdbscm_wrap ([=]

> +    {

> +      scoped_value_mark free_values;

> +

> +      struct value *res_val = make_cv_value (1, 0, value);

> +      return vlscm_scm_from_value (res_val);

> +    });

> +}

> +

>  /* (value-type <gdb:value>) -> <gdb:type> */

>  

>  static SCM

> @@ -1374,6 +1392,11 @@ value-referenced-value will result in a value of type 'int *'." },

>      "\

>  Return a <gdb:value> object which is a reference to the given value." },

>  

> +  { "value-const-value", 1, 0, 0,

> +    as_a_scm_t_subr (gdbscm_value_const_value),

> +    "\

> +Return a <gdb:value> object which is a 'const' version of the given value." },

> +

>    { "value-field", 2, 0, 0, as_a_scm_t_subr (gdbscm_value_field),

>      "\

>  Return the specified field of the value.\n\

> diff --git a/gdb/testsuite/gdb.guile/scm-value.exp b/gdb/testsuite/gdb.guile/scm-value.exp

> index 83399f32103..e001ae12ae7 100644

> --- a/gdb/testsuite/gdb.guile/scm-value.exp

> +++ b/gdb/testsuite/gdb.guile/scm-value.exp

> @@ -176,6 +176,9 @@ proc test_value_in_inferior {} {

>  

>      gdb_test "gu (equal? argv (value-referenced-value (value-reference-value argv)))" \

>  	"#t"

> +

> +    gdb_test "gu (equal? (value-type (value-const-value argv)) (type-const (value-type argv)))" \

> +	"#t"

>  }

>  

>  proc test_strings {} {

> -- 

> 2.30.2

Patch

diff --git a/gdb/doc/guile.texi b/gdb/doc/guile.texi
index eed94366027..8ad9bb8f82e 100644
--- a/gdb/doc/guile.texi
+++ b/gdb/doc/guile.texi
@@ -806,6 +806,11 @@  Return a new @code{<gdb:value>} object which is a reference to the value
 encapsulated by @code{<gdb:value>} object @var{value}.
 @end deffn
 
+@deffn {Scheme Procedure} value-const-value value
+Return a new @code{<gdb:value>} object which is a 'const' version of
+@code{<gdb:value>} object @var{value}.
+@end deffn
+
 @deffn {Scheme Procedure} value-field value field-name
 Return field @var{field-name} from @code{<gdb:value>} object @var{value}.
 @end deffn
diff --git a/gdb/guile/scm-value.c b/gdb/guile/scm-value.c
index dc59633ec6f..22a9902317c 100644
--- a/gdb/guile/scm-value.c
+++ b/gdb/guile/scm-value.c
@@ -505,6 +505,24 @@  gdbscm_value_reference_value (SCM self)
     });
 }
 
+/* (value-const-value <gdb:value>) -> <gdb:value> */
+
+static SCM
+gdbscm_value_const_value (SCM self)
+{
+  value_smob *v_smob
+    = vlscm_get_value_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME);
+  struct value *value = v_smob->value;
+
+  return gdbscm_wrap ([=]
+    {
+      scoped_value_mark free_values;
+
+      struct value *res_val = make_cv_value (1, 0, value);
+      return vlscm_scm_from_value (res_val);
+    });
+}
+
 /* (value-type <gdb:value>) -> <gdb:type> */
 
 static SCM
@@ -1374,6 +1392,11 @@  value-referenced-value will result in a value of type 'int *'." },
     "\
 Return a <gdb:value> object which is a reference to the given value." },
 
+  { "value-const-value", 1, 0, 0,
+    as_a_scm_t_subr (gdbscm_value_const_value),
+    "\
+Return a <gdb:value> object which is a 'const' version of the given value." },
+
   { "value-field", 2, 0, 0, as_a_scm_t_subr (gdbscm_value_field),
     "\
 Return the specified field of the value.\n\
diff --git a/gdb/testsuite/gdb.guile/scm-value.exp b/gdb/testsuite/gdb.guile/scm-value.exp
index 83399f32103..e001ae12ae7 100644
--- a/gdb/testsuite/gdb.guile/scm-value.exp
+++ b/gdb/testsuite/gdb.guile/scm-value.exp
@@ -176,6 +176,9 @@  proc test_value_in_inferior {} {
 
     gdb_test "gu (equal? argv (value-referenced-value (value-reference-value argv)))" \
 	"#t"
+
+    gdb_test "gu (equal? (value-type (value-const-value argv)) (type-const (value-type argv)))" \
+	"#t"
 }
 
 proc test_strings {} {