[04/15] io: Add basic tests for utimensat

Message ID 20210323134458.2563022-5-adhemerval.zanella@linaro.org
State New
Headers show
Series
  • Add some tests and infra changes
Related show

Commit Message

Checked on x86_64-linux-gnu and i686-linux-gnu
---
 io/Makefile        |  1 +
 io/tst-utimensat.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 71 insertions(+)
 create mode 100644 io/tst-utimensat.c

-- 
2.27.0

Comments

Siddhesh Poyarekar April 15, 2021, 5:33 a.m. | #1
On 3/23/21 7:14 PM, Adhemerval Zanella via Libc-alpha wrote:
> Checked on x86_64-linux-gnu and i686-linux-gnu


LGTM.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

Patch

diff --git a/io/Makefile b/io/Makefile
index bec0e5871e..0903804dfd 100644
--- a/io/Makefile
+++ b/io/Makefile
@@ -74,6 +74,7 @@  tests		:= test-utime test-stat test-stat2 test-lfs tst-getcwd \
 		   tst-futimes \
 		   tst-lutimes \
 		   tst-futimens \
+		   tst-utimensat \
 
 # Likewise for statx, but we do not need static linking here.
 tests-internal += tst-statx
diff --git a/io/tst-utimensat.c b/io/tst-utimensat.c
new file mode 100644
index 0000000000..0c7c8470bc
--- /dev/null
+++ b/io/tst-utimensat.c
@@ -0,0 +1,70 @@ 
+/* Test for utimensat.
+   Copyright (C) 2021 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include <fcntl.h>
+#include <support/check.h>
+#include <support/xunistd.h>
+#include <sys/stat.h>
+#include <sys/time.h>
+
+static int
+test_utimesat_helper (const char *testfile, int fd, const char *testlink,
+                      const struct timespec *ts)
+{
+  {
+    TEST_VERIFY_EXIT (utimensat (fd, testfile, ts, 0) == 0);
+
+    struct stat64 st;
+    xfstat (fd, &st);
+
+    /* Check if seconds for atime match */
+    TEST_COMPARE (st.st_atime, ts[0].tv_sec);
+
+    /* Check if seconds for mtime match */
+    TEST_COMPARE (st.st_mtime, ts[1].tv_sec);
+  }
+
+  {
+    struct stat64 stfile_orig;
+    xlstat (testfile, &stfile_orig);
+
+    TEST_VERIFY_EXIT (utimensat (0 /* ignored  */, testlink, ts,
+				 AT_SYMLINK_NOFOLLOW)
+		       == 0);
+    struct stat64 stlink;
+    xlstat (testlink, &stlink);
+
+    TEST_COMPARE (stlink.st_atime, ts[0].tv_sec);
+    TEST_COMPARE (stlink.st_mtime, ts[1].tv_sec);
+
+    /* Check if the timestamp from original file is not changed.  */
+    struct stat64 stfile;
+    xlstat (testfile, &stfile);
+
+    TEST_COMPARE (stfile_orig.st_atime, stfile.st_atime);
+    TEST_COMPARE (stfile_orig.st_mtime, stfile.st_mtime);
+  }
+
+  return 0;
+}
+
+#define TEST_CALL(fname, fd, lname, v1, v2) \
+  test_utimesat_helper (fname, fd, lname, (struct timespec[]) { { v1, 0 }, \
+                                                                { v2, 0 } })
+
+#include "tst-utimensat-skeleton.c"