[02/15] linux: Add futimes test

Message ID 20210323134458.2563022-3-adhemerval.zanella@linaro.org
State New
Headers show
Series
  • Add some tests and infra changes
Related show

Commit Message

naohirot--- via Libc-alpha March 23, 2021, 1:44 p.m.
It uses stat to compare against the values set by futimes.

Checked on x86_64-linux-gnu and i686-linux-gnu.
---
 io/Makefile      |  1 +
 io/tst-futimes.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 47 insertions(+)
 create mode 100644 io/tst-futimes.c

-- 
2.27.0

Comments

Siddhesh Poyarekar April 15, 2021, 5:07 a.m. | #1
On 3/23/21 7:14 PM, Adhemerval Zanella via Libc-alpha wrote:
> It uses stat to compare against the values set by futimes.

> 

> Checked on x86_64-linux-gnu and i686-linux-gnu.


OK.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

Patch

diff --git a/io/Makefile b/io/Makefile
index 3411573cf3..0002e108a6 100644
--- a/io/Makefile
+++ b/io/Makefile
@@ -71,6 +71,7 @@  tests		:= test-utime test-stat test-stat2 test-lfs tst-getcwd \
 		   tst-ftw-bz26353 tst-stat tst-stat-lfs \
 		   tst-utime \
 		   tst-utimes \
+		   tst-futimes \
 		   tst-futimens \
 
 # Likewise for statx, but we do not need static linking here.
diff --git a/io/tst-futimes.c b/io/tst-futimes.c
new file mode 100644
index 0000000000..ea7ac7d5f8
--- /dev/null
+++ b/io/tst-futimes.c
@@ -0,0 +1,46 @@ 
+/* Test for futimes.
+   Copyright (C) 2021 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include <support/check.h>
+#include <support/xunistd.h>
+#include <sys/stat.h>
+#include <sys/time.h>
+
+static int
+test_futimens_helper (const char *file, int fd, const struct timeval *tv)
+{
+  int r = futimes (fd, tv);
+  TEST_VERIFY_EXIT (r == 0);
+
+  struct stat64 st;
+  xfstat (fd, &st);
+
+  /* Check if seconds for atime match */
+  TEST_COMPARE (st.st_atime, tv[0].tv_sec);
+
+  /* Check if seconds for mtime match */
+  TEST_COMPARE (st.st_mtime, tv[1].tv_sec);
+
+  return 0;
+}
+
+#define TEST_CALL(fname, fd, v1, v2) \
+  test_futimens_helper (fname, fd, (struct timeval[]) { { v1, 0 }, \
+							{ v2, 0 } })
+
+#include "tst-utimensat-skeleton.c"