[3/3] Removed obsolete AC_CHECK_TOOL_PREFIX

Message ID 20210216120100.213653-1-naohirot@fujitsu.com
State New
Headers show
Series
  • [1/3] Replaced obsolete AC_TRY_COMPILE to AC_COMPILE_IFELSE
Related show

Commit Message

naohirot@fujitsu.com Feb. 16, 2021, 12:01 p.m.
This patch removed obsolete AC_CHECK_TOOL_PREFIX.
It has been confirmed that AC_CHECK_TOOL_PREFIX is defined as NOP in
GNU 'autoconf' 2.69 [1], so we can safely remove it.
The 'configure' file has been deleted one blank line by the 'autoconf'
2.69 command .

   [1] autoconf-2.69/share/autoconf/autoconf/programs.m4
   181 # AC_CHECK_TOOL_PREFIX
   182 # --------------------
   183 AU_DEFUN([AC_CHECK_TOOL_PREFIX])
---
 configure    | 1 -
 configure.ac | 1 -
 2 files changed, 2 deletions(-)

-- 
2.17.1

Comments

Zack Weinberg Feb. 16, 2021, 4:41 p.m. | #1
On Tue, Feb 16, 2021 at 7:02 AM Naohiro Tamura <naohirot@fujitsu.com> wrote:
> This patch removed obsolete AC_CHECK_TOOL_PREFIX.

> It has been confirmed that AC_CHECK_TOOL_PREFIX is defined as NOP in

> GNU 'autoconf' 2.69 [1], so we can safely remove it.

> The 'configure' file has been deleted one blank line by the 'autoconf'

> 2.69 command .


OK, please commit.

zw
naohirot@fujitsu.com Feb. 17, 2021, 1:25 a.m. | #2
Zack-san,

Thanks!
Naohiro
> -----Original Message-----

> From: Zack Weinberg <zackw@panix.com>

> Sent: Wednesday, February 17, 2021 1:42 AM

> To: Tamura, Naohiro/田村 直広 <naohirot@fujitsu.com>

> Cc: GNU C Library <libc-alpha@sourceware.org>

> Subject: Re: [PATCH 3/3] Removed obsolete AC_CHECK_TOOL_PREFIX

> 

> On Tue, Feb 16, 2021 at 7:02 AM Naohiro Tamura <naohirot@fujitsu.com> wrote:

> > This patch removed obsolete AC_CHECK_TOOL_PREFIX.

> > It has been confirmed that AC_CHECK_TOOL_PREFIX is defined as NOP in

> > GNU 'autoconf' 2.69 [1], so we can safely remove it.

> > The 'configure' file has been deleted one blank line by the 'autoconf'

> > 2.69 command .

> 

> OK, please commit.

> 

> zw
Wei-Lun Chao via Libc-alpha Feb. 21, 2021, 11:36 p.m. | #3
On 16 Feb 2021 12:01, Naohiro Tamura wrote:
> This patch removed obsolete AC_CHECK_TOOL_PREFIX.


i've merged this now, thanks!
-mike
naohirot@fujitsu.com Feb. 22, 2021, 1:48 a.m. | #4
Mike-san,

Thanks for updating the first line and merging it!
Naohiro

Patch

diff --git a/configure b/configure
index 1dc3af60b4..37cef37413 100755
--- a/configure
+++ b/configure
@@ -4732,7 +4732,6 @@  fi
 fi
 
 # These programs are version sensitive.
-
 for ac_prog in gnumake gmake make
 do
   # Extract the first word of "$ac_prog", so it can be a program name with args.
diff --git a/configure.ac b/configure.ac
index b7f6f8f008..a20c759241 100644
--- a/configure.ac
+++ b/configure.ac
@@ -993,7 +993,6 @@  else
 fi
 
 # These programs are version sensitive.
-AC_CHECK_TOOL_PREFIX
 AC_CHECK_PROG_VER(MAKE, gnumake gmake make, --version,
   [GNU Make[^0-9]*\([0-9][0-9.]*\)],
   [[4-9].* | [1-9][0-9]*], critic_missing="$critic_missing make")