[pushed] Ada : Fix bootstrap after r11-4793.

Message ID 4D238281-1EE1-46D8-881A-0E7EC41100F7@sandoe.co.uk
State New
Headers show
Series
  • [pushed] Ada : Fix bootstrap after r11-4793.
Related show

Commit Message

Iain Sandoe Nov. 7, 2020, 9:10 a.m.
Hi

The patch omitted a change for Ada, fixed thus.

tested on x86_64-darwin,
pushed to master as obvious/bootstrap fix.
thanks
Iain

gcc/ada/ChangeLog:

	* gcc-interface/misc.c (gnat_printable_name): Change
	DECL_IS_BUILTIN -> DECL_IS_UNDECLARED_BUILTIN.
---
 gcc/ada/gcc-interface/misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.24.1

Comments

Eric Botcazou Nov. 7, 2020, 9:54 a.m. | #1
> The patch omitted a change for Ada, fixed thus.

> 

> tested on x86_64-darwin,

> pushed to master as obvious/bootstrap fix.

> thanks

> Iain

> 

> gcc/ada/ChangeLog:

> 

> 	* gcc-interface/misc.c (gnat_printable_name): Change

> 	DECL_IS_BUILTIN -> DECL_IS_UNDECLARED_BUILTIN.


Thanks for fixing this!

-- 
Eric Botcazou
Nathan Sidwell Nov. 9, 2020, 12:41 p.m. | #2
On 11/7/20 4:10 AM, Iain Sandoe wrote:
> Hi

> 

> The patch omitted a change for Ada, fixed thus.

>


Iain, thank you for catching and fixing this.  As you know (but others 
don't), ada is harder for me as I can't build that on my usual machine.

Eric, Iain does bootstraps of the modules branch on darwin include Ada, 
and I have done so for linux (a few months back).  I will make sure to 
check that more regularly during the modules merge.

nathan

-- 
Nathan Sidwell
Arnaud Charlet Nov. 9, 2020, 12:58 p.m. | #3
> Iain, thank you for catching and fixing this.  As you know (but

> others don't), ada is harder for me as I can't build that on my

> usual machine.

> 

> Eric, Iain does bootstraps of the modules branch on darwin include

> Ada, and I have done so for linux (a few months back).  I will make

> sure to check that more regularly during the modules merge.


Thanks Nathan and Iain, much appreciated!

Patch

diff --git a/gcc/ada/gcc-interface/misc.c b/gcc/ada/gcc-interface/misc.c
index 781868e2ad3..87724af814e 100644
--- a/gcc/ada/gcc-interface/misc.c
+++ b/gcc/ada/gcc-interface/misc.c
@@ -559,7 +559,7 @@  gnat_printable_name (tree decl, int verbosity)
 
   __gnat_decode (coded_name, ada_name, 0);
 
-  if (verbosity == 2 && !DECL_IS_BUILTIN (decl))
+  if (verbosity == 2 && !DECL_IS_UNDECLARED_BUILTIN (decl))
     {
       Set_Identifier_Casing (ada_name, DECL_SOURCE_FILE (decl));
       return ggc_strdup (Name_Buffer);