[1/3] libc/include/inttypes.h: Remove parameter name

Message ID 20201001141753.6657-2-torbjorn.svensson@st.com
State New
Headers show
Series
  • libc: Comply with the libstdc++ test case names.cc
Related show

Commit Message

R. Diez via Newlib Oct. 1, 2020, 2:17 p.m.
As discussed in GCC bug 97088
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in
prototypes of library functions should use reserved names, or no name
at all.

This patch removes the 'j' parameter name from
extern intmax_t  imaxabs(intmax_t);

to avoid possible clashes with user code in case someone uses
before including Newlib's inttypes.h (or uses some other conflicting
definition)

Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@st.com>

---
 newlib/libc/include/inttypes.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.18.0

Comments

R. Diez via Newlib Oct. 1, 2020, 11:22 p.m. | #1
Looks fine.  Could you please resend the patch as an attachment?

Thanks,

-- Jeff J.

On Thu, Oct 1, 2020 at 10:19 AM Torbjörn SVENSSON via Newlib <
newlib@sourceware.org> wrote:

> As discussed in GCC bug 97088

> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in

> prototypes of library functions should use reserved names, or no name

> at all.

>

> This patch removes the 'j' parameter name from

> extern intmax_t  imaxabs(intmax_t);

>

> to avoid possible clashes with user code in case someone uses

> before including Newlib's inttypes.h (or uses some other conflicting

> definition)

>

> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@st.com>

> ---

>  newlib/libc/include/inttypes.h | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/newlib/libc/include/inttypes.h

> b/newlib/libc/include/inttypes.h

> index 073215476..570ed0481 100644

> --- a/newlib/libc/include/inttypes.h

> +++ b/newlib/libc/include/inttypes.h

> @@ -320,7 +320,7 @@ struct _reent;

>  extern "C" {

>  #endif

>

> -extern intmax_t  imaxabs(intmax_t j);

> +extern intmax_t  imaxabs(intmax_t);

>  extern imaxdiv_t imaxdiv(intmax_t numer, intmax_t denomer);

>  extern intmax_t  strtoimax(const char *__restrict, char **__restrict,

> int);

>  extern intmax_t  _strtoimax_r(struct _reent *, const char *__restrict,

> char **__restrict, int);

> --

> 2.18.0

>

>
R. Diez via Newlib Oct. 2, 2020, 6:52 a.m. | #2
Patch attached.

From: Jeff Johnston <jjohnstn@redhat.com>

Sent: den 2 oktober 2020 01:23
To: Torbjorn SVENSSON <torbjorn.svensson@st.com>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: [PATCH 1/3] libc/include/inttypes.h: Remove parameter name

Looks fine.  Could you please resend the patch as an attachment?

Thanks,

-- Jeff J.

On Thu, Oct 1, 2020 at 10:19 AM Torbjörn SVENSSON via Newlib <newlib@sourceware.org<mailto:newlib@sourceware.org>> wrote:
As discussed in GCC bug 97088
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in
prototypes of library functions should use reserved names, or no name
at all.

This patch removes the 'j' parameter name from
extern intmax_t  imaxabs(intmax_t);

to avoid possible clashes with user code in case someone uses
before including Newlib's inttypes.h (or uses some other conflicting
definition)

Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@st.com<mailto:torbjorn.svensson@st.com>>

---
 newlib/libc/include/inttypes.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/newlib/libc/include/inttypes.h b/newlib/libc/include/inttypes.h
index 073215476..570ed0481 100644
--- a/newlib/libc/include/inttypes.h
+++ b/newlib/libc/include/inttypes.h
@@ -320,7 +320,7 @@ struct _reent;
 extern "C" {
 #endif

-extern intmax_t  imaxabs(intmax_t j);
+extern intmax_t  imaxabs(intmax_t);
 extern imaxdiv_t imaxdiv(intmax_t numer, intmax_t denomer);
 extern intmax_t  strtoimax(const char *__restrict, char **__restrict, int);
 extern intmax_t  _strtoimax_r(struct _reent *, const char *__restrict, char **__restrict, int);
--
2.18.0
nrupp Oct. 2, 2020, 6:53 a.m. | #3
<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head><body ><div>Ja</div><br><br><br><br><div>-------- Ursprüngliche Nachricht --------</div><div>Von: Torbjorn SVENSSON via Newlib &lt;newlib@sourceware.org&gt; </div><div>Datum: 02.10.20  08:52  (GMT+01:00) </div><div>An: Jeff Johnston &lt;jjohnstn@redhat.com&gt; </div><div>Cc: Newlib &lt;newlib@sourceware.org&gt; </div><div>Betreff: RE: [PATCH 1/3] libc/include/inttypes.h: Remove parameter name </div><div><br></div>null
null
R. Diez via Newlib Oct. 2, 2020, 9:01 p.m. | #4
Patch applied.  Thanks.

-- Jeff J.

On Fri, Oct 2, 2020 at 2:52 AM Torbjorn SVENSSON <torbjorn.svensson@st.com>
wrote:

> Patch attached.

>

>

>

> *From:* Jeff Johnston <jjohnstn@redhat.com>

> *Sent:* den 2 oktober 2020 01:23

> *To:* Torbjorn SVENSSON <torbjorn.svensson@st.com>

> *Cc:* Newlib <newlib@sourceware.org>

> *Subject:* Re: [PATCH 1/3] libc/include/inttypes.h: Remove parameter name

>

>

>

> Looks fine.  Could you please resend the patch as an attachment?

>

>

>

> Thanks,

>

>

>

> -- Jeff J.

>

>

>

> On Thu, Oct 1, 2020 at 10:19 AM Torbjörn SVENSSON via Newlib <

> newlib@sourceware.org> wrote:

>

> As discussed in GCC bug 97088

> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in

> prototypes of library functions should use reserved names, or no name

> at all.

>

> This patch removes the 'j' parameter name from

> extern intmax_t  imaxabs(intmax_t);

>

> to avoid possible clashes with user code in case someone uses

> before including Newlib's inttypes.h (or uses some other conflicting

> definition)

>

> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@st.com>

> ---

>  newlib/libc/include/inttypes.h | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/newlib/libc/include/inttypes.h

> b/newlib/libc/include/inttypes.h

> index 073215476..570ed0481 100644

> --- a/newlib/libc/include/inttypes.h

> +++ b/newlib/libc/include/inttypes.h

> @@ -320,7 +320,7 @@ struct _reent;

>  extern "C" {

>  #endif

>

> -extern intmax_t  imaxabs(intmax_t j);

> +extern intmax_t  imaxabs(intmax_t);

>  extern imaxdiv_t imaxdiv(intmax_t numer, intmax_t denomer);

>  extern intmax_t  strtoimax(const char *__restrict, char **__restrict,

> int);

>  extern intmax_t  _strtoimax_r(struct _reent *, const char *__restrict,

> char **__restrict, int);

> --

> 2.18.0

>

>

Patch

diff --git a/newlib/libc/include/inttypes.h b/newlib/libc/include/inttypes.h
index 073215476..570ed0481 100644
--- a/newlib/libc/include/inttypes.h
+++ b/newlib/libc/include/inttypes.h
@@ -320,7 +320,7 @@  struct _reent;
 extern "C" {
 #endif
 
-extern intmax_t  imaxabs(intmax_t j);
+extern intmax_t  imaxabs(intmax_t);
 extern imaxdiv_t imaxdiv(intmax_t numer, intmax_t denomer);
 extern intmax_t  strtoimax(const char *__restrict, char **__restrict, int);
 extern intmax_t  _strtoimax_r(struct _reent *, const char *__restrict, char **__restrict, int);