Fix handling of collating symbols in fnmatch (bug 26620)

Message ID mvmsgbiq9ny.fsf@suse.de
State New
Headers show
Series
  • Fix handling of collating symbols in fnmatch (bug 26620)
Related show

Commit Message

Andreas Schwab Sept. 16, 2020, 10:48 a.m.
The variable idx contains the index into the extra array, whereas wextra
points into the extra array at this index, containing the length of the
following collating sequence in the wide character representation.
---
 posix/Makefile       |  3 ++-
 posix/fnmatch_loop.c |  4 ++--
 posix/tst-fnmatch6.c | 36 ++++++++++++++++++++++++++++++++++++
 3 files changed, 40 insertions(+), 3 deletions(-)
 create mode 100644 posix/tst-fnmatch6.c

-- 
2.28.0


-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Comments

Adhemerval Zanella via Libc-alpha Sept. 16, 2020, 11:59 a.m. | #1
* Andreas Schwab:

> The variable idx contains the index into the extra array, whereas wextra

> points into the extra array at this index, containing the length of the

> following collating sequence in the wide character representation.


Based on the surrounding code, the change looks correct to me.  Thanks
for fixing this.

The test case could use xsetlocale, I think.

Florian
-- 
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
Andreas Schwab Sept. 16, 2020, 12:46 p.m. | #2
On Sep 16 2020, Florian Weimer wrote:

> The test case could use xsetlocale, I think.


Installed with that change.

Thanks, Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Patch

diff --git a/posix/Makefile b/posix/Makefile
index c52645c5f4..19a890742a 100644
--- a/posix/Makefile
+++ b/posix/Makefile
@@ -96,7 +96,7 @@  tests		:= test-errno tstgetopt testfnm runtests runptests \
 		   bug-getopt5 tst-getopt_long1 bug-regex34 bug-regex35 \
 		   tst-pathconf tst-rxspencer-no-utf8 \
 		   tst-fnmatch3 bug-regex36 \
-		   tst-fnmatch4 tst-fnmatch5 \
+		   tst-fnmatch4 tst-fnmatch5 tst-fnmatch6 \
 		   tst-posix_spawn-fd tst-posix_spawn-setsid \
 		   tst-posix_fadvise tst-posix_fadvise64 \
 		   tst-sysconf-empty-chroot tst-glob_symlinks tst-fexecve \
@@ -197,6 +197,7 @@  $(objpfx)bug-regex35.out: $(gen-locales)
 $(objpfx)tst-fnmatch.out: $(gen-locales)
 $(objpfx)tst-fnmatch4.out: $(gen-locales)
 $(objpfx)tst-fnmatch5.out: $(gen-locales)
+$(objpfx)tst-fnmatch6.out: $(gen-locales)
 $(objpfx)tst-regex.out: $(gen-locales)
 $(objpfx)tst-regex2.out: $(gen-locales)
 $(objpfx)tst-regexloc.out: $(gen-locales)
diff --git a/posix/fnmatch_loop.c b/posix/fnmatch_loop.c
index 8ead4dc7b9..0f890d4782 100644
--- a/posix/fnmatch_loop.c
+++ b/posix/fnmatch_loop.c
@@ -564,7 +564,7 @@  FCT (const CHAR *pattern, const CHAR *string, const CHAR *string_end,
 				/* Get the collation sequence value.  */
 				is_seqval = 1;
 # if WIDE_CHAR_VERSION
-				cold = wextra[1 + wextra[idx]];
+				cold = wextra[1 + wextra[0]];
 # else
 				idx += 1 + extra[idx];
 				/* Adjust for the alignment.  */
@@ -738,7 +738,7 @@  FCT (const CHAR *pattern, const CHAR *string, const CHAR *string_end,
 				    /* Get the collation sequence value.  */
 				    is_seqval = 1;
 # if WIDE_CHAR_VERSION
-				    cend = wextra[1 + wextra[idx]];
+				    cend = wextra[1 + wextra[0]];
 # else
 				    idx += 1 + extra[idx];
 				    /* Adjust for the alignment.  */
diff --git a/posix/tst-fnmatch6.c b/posix/tst-fnmatch6.c
new file mode 100644
index 0000000000..070df69a2c
--- /dev/null
+++ b/posix/tst-fnmatch6.c
@@ -0,0 +1,36 @@ 
+/* Test for fnmatch handling of collating symbols (bug 26620)
+   Copyright (C) 2020 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include <fnmatch.h>
+#include <locale.h>
+#include <support/check.h>
+
+static int
+do_test (void)
+{
+  TEST_VERIFY_EXIT (setlocale (LC_ALL, "en_US.UTF-8") != NULL);
+  /* From iso14651_t1_common:
+     collating-element <U004C_00B7> from "<U004C><U00B7>"
+     % decomposition of LATIN CAPITAL LETTER L WITH MIDDLE DOT */
+  TEST_VERIFY (fnmatch ("[[.L\xc2\xb7.]]", ".", 0) != 0);
+  TEST_VERIFY (fnmatch ("[[.L\xc2\xb7.]]", "L\xc2\xb7", 0) == 0);
+
+  return 0;
+}
+
+#include <support/test-driver.c>