"gdb --config" to show the xxHash option

Message ID 83pngl36rn.fsf@gnu.org
State New
Headers show
Series
  • "gdb --config" to show the xxHash option
Related show

Commit Message

Eli Zaretskii Dec. 18, 2019, 5:03 p.m.
I've noticed that HAVE_LIBXXHASH is not reflected in the --config
output.  Okay to commit the below? including to the GDB 9 branch?

Comments

Lancelot SIX via Gdb-patches Dec. 18, 2019, 5:57 p.m. | #1
On Wed, Dec 18, 2019 at 11:04 AM Eli Zaretskii <eliz@gnu.org> wrote:
>

> I've noticed that HAVE_LIBXXHASH is not reflected in the --config

> output.  Okay to commit the below? including to the GDB 9 branch?


As the person who added this flag, this sounds reasonable to me. What
are the criteria for adding stuff to this list? I didn't add it
because there's no user-visible effect other than performance.

Christian

> diff --git a/gdb/ChangeLog b/gdb/ChangeLog

> index 91b81f2..98c9361 100644

> --- a/gdb/ChangeLog

> +++ b/gdb/ChangeLog

> @@ -1,3 +1,8 @@

> +2019-12-18  Eli Zaretskii  <eliz@gnu.org>

> +

> +       * top.c (print_gdb_configuration): Print "--with-xxhash" or

> +       "--without-xxhash" according to HAVE_LIBXXHASH.

> +

>  2019-12-17  Christian Biesinger  <cbiesinger@google.com>

>

>         * bsd-kvm.c: Include gdbsupport/pathstuff.h.

> diff --git a/gdb/top.c b/gdb/top.c

> index bc300e4..796a423 100644

> --- a/gdb/top.c

> +++ b/gdb/top.c

> @@ -1496,6 +1496,15 @@ This GDB was configured as follows:\n\

>               --without-mpfr\n\

>  "));

>  #endif

> +#if HAVE_LIBXXHASH

> +    fprintf_filtered (stream, _("\

> +             --with-xxhash\n\

> +"));

> +#else

> +    fprintf_filtered (stream, _("\

> +             --without-xxhash\n\

> +"));

> +#endif

>  #ifdef WITH_PYTHON_PATH

>    fprintf_filtered (stream, _("\

>               --with-python=%s%s\n\
Eli Zaretskii Dec. 18, 2019, 6:34 p.m. | #2
> From: Christian Biesinger <cbiesinger@google.com>

> Date: Wed, 18 Dec 2019 11:57:18 -0600

> Cc: gdb-patches <gdb-patches@sourceware.org>

> 

> On Wed, Dec 18, 2019 at 11:04 AM Eli Zaretskii <eliz@gnu.org> wrote:

> >

> > I've noticed that HAVE_LIBXXHASH is not reflected in the --config

> > output.  Okay to commit the below? including to the GDB 9 branch?

> 

> As the person who added this flag, this sounds reasonable to me. What

> are the criteria for adding stuff to this list? I didn't add it

> because there's no user-visible effect other than performance.


The original idea was to provide a means for end-users to report to us
how their GDB was configured, to facilitate investigation of issues.
So I think any optional feature should be reflected in the output of
"gdb --config".
Tom Tromey Dec. 19, 2019, 6:15 p.m. | #3
>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:


Eli> I've noticed that HAVE_LIBXXHASH is not reflected in the --config
Eli> output.  Okay to commit the below? including to the GDB 9 branch?

This is ok.  Thanks.
I think it's fine for the gdb 9 branch as well.

Tom
Eli Zaretskii Dec. 21, 2019, 7:41 a.m. | #4
> From: Tom Tromey <tom@tromey.com>

> Cc: gdb-patches@sourceware.org

> Date: Thu, 19 Dec 2019 11:15:26 -0700

> 

> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

> 

> Eli> I've noticed that HAVE_LIBXXHASH is not reflected in the --config

> Eli> output.  Okay to commit the below? including to the GDB 9 branch?

> 

> This is ok.  Thanks.

> I think it's fine for the gdb 9 branch as well.


Thanks, pushed the changes below (which also fix the indentation in
the vicinity):

commit 15b07e4f5672cf02487a26305ac3b2ddd0aec68e
Author:     Eli Zaretskii <eliz@gnu.org>
AuthorDate: Sat Dec 21 09:23:44 2019 +0200
Commit:     Eli Zaretskii <eliz@gnu.org>
CommitDate: Sat Dec 21 09:23:44 2019 +0200

    Include xxHash support status in GDB configuration report
    
    gdb/ChangeLog
    2019-12-21  Eli Zaretskii  <eliz@gnu.org>
    
            * top.c (print_gdb_configuration): Print "--with-xxhash" or
            "--without-xxhash" according to HAVE_LIBXXHASH.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b58e4f5..0ba175a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-12-21  Eli Zaretskii  <eliz@gnu.org>
+
+	* top.c (print_gdb_configuration): Print "--with-xxhash" or
+	"--without-xxhash" according to HAVE_LIBXXHASH.
+
 2019-12-20  Weimin Pan  <weimin.pan@oracle.com>
 	* ctfread.c (ctf_file_key): Change type to objfile_key.
 	(struct ctf_context): Remove typedef.
diff --git a/gdb/top.c b/gdb/top.c
index 6f366ff..15bbe30 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -1478,35 +1478,43 @@ This GDB was configured as follows:\n\
 #endif
 
 #if HAVE_LIBBABELTRACE
-    fprintf_filtered (stream, _("\
+  fprintf_filtered (stream, _("\
              --with-babeltrace\n\
 "));
 #else
-    fprintf_filtered (stream, _("\
-             --without-babeltrace\n\
+  fprintf_filtered (stream, _("\
+             --without-babeltrace\n		\
 "));
 #endif
 
 #if HAVE_LIBIPT
-    fprintf_filtered (stream, _("\
+  fprintf_filtered (stream, _("\
              --with-intel-pt\n\
 "));
 #else
-    fprintf_filtered (stream, _("\
+  fprintf_filtered (stream, _("\
              --without-intel-pt\n\
 "));
 #endif
 
 #if HAVE_LIBMPFR
-    fprintf_filtered (stream, _("\
+  fprintf_filtered (stream, _("\
              --with-mpfr\n\
 "));
 #else
-    fprintf_filtered (stream, _("\
+  fprintf_filtered (stream, _("\
              --without-mpfr\n\
 "));
 #endif
-
+#if HAVE_LIBXXHASH
+  fprintf_filtered (stream, _("\
+             --with-xxhash\n\
+"));
+#else
+  fprintf_filtered (stream, _("\
+             --without-xxhash\n\
+"));
+#endif
 #ifdef WITH_PYTHON_PATH
   fprintf_filtered (stream, _("\
              --with-python=%s%s\n\

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 91b81f2..98c9361 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2019-12-18  Eli Zaretskii  <eliz@gnu.org>
+
+	* top.c (print_gdb_configuration): Print "--with-xxhash" or
+	"--without-xxhash" according to HAVE_LIBXXHASH.
+
 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
 
 	* bsd-kvm.c: Include gdbsupport/pathstuff.h.
diff --git a/gdb/top.c b/gdb/top.c
index bc300e4..796a423 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -1496,6 +1496,15 @@  This GDB was configured as follows:\n\
              --without-mpfr\n\
 "));
 #endif
+#if HAVE_LIBXXHASH
+    fprintf_filtered (stream, _("\
+             --with-xxhash\n\
+"));
+#else
+    fprintf_filtered (stream, _("\
+             --without-xxhash\n\
+"));
+#endif
 #ifdef WITH_PYTHON_PATH
   fprintf_filtered (stream, _("\
              --with-python=%s%s\n\