Remove sysdeps/x86/fpu/bits/mathinline.h __finite inline [committed]

Message ID alpine.DEB.2.20.1803161837130.20069@digraph.polyomino.org.uk
State New
Headers show
Series
  • Remove sysdeps/x86/fpu/bits/mathinline.h __finite inline [committed]
Related show

Commit Message

Joseph Myers March 16, 2018, 6:37 p.m.
Continuing the removals of inline functions from the x86
bits/mathinline.h, this patch removes an inline of __finite (which was
not actually architecture-specific at all beyond its
endianness-dependence).

This inline is not normally used with GCC 4.4 or later, because
isfinite now uses __builtin_isfinite except for -fsignaling-nans.
Allowing __builtin_isfinite etc. to work properly even for
-fsignaling-nans, by implementing versions of those built-in functions
that use integer arithmetic in GCC, is
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66462> (a patch was
committed but had to be reverted because it caused problems, and that
patch didn't address all formats for all architectures, only some, so
by itself would not have been sufficient to allow glibc to use
__builtin_isfinite unconditionally for new-enough GCC).

Tested for x86_64 and x86.  Committed.

2018-03-16  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/x86/fpu/bits/mathinline.h [__USE_MISC] (__finite):
	Remove inline function.


-- 
Joseph S. Myers
joseph@codesourcery.com

Patch

diff --git a/sysdeps/x86/fpu/bits/mathinline.h b/sysdeps/x86/fpu/bits/mathinline.h
index d7fa384..91ece8d 100644
--- a/sysdeps/x86/fpu/bits/mathinline.h
+++ b/sysdeps/x86/fpu/bits/mathinline.h
@@ -306,19 +306,6 @@  __inline_mathcodeNP2 (hypot, __x, __y,
 #  endif
 
 
-#  ifdef __USE_MISC
-
-/* This function is used in the `isfinite' macro.  */
-__MATH_INLINE int
-__NTH (__finite (double __x))
-{
-  return (__extension__
-	  (((((union { double __d; int __i[2]; }) {__d: __x}).__i[1]
-	     | 0x800fffffu) + 1) >> 31));
-}
-
-#  endif /* __USE_MISC  */
-
 /* Undefine some of the large macros which are not used anymore.  */
 #  ifdef __FAST_MATH__
 #   undef __expm1_code