[0/3] Improved string comparison routines for aarch64

Message ID 20180629123822.14533-1-siddhesh@sourceware.org
Headers show
Series
  • Improved string comparison routines for aarch64
Related show

Message

Siddhesh Poyarekar June 29, 2018, 12:38 p.m.
Hi,

Following patches improve performance of comparing mutually misaligned
strings by up to 3.5x on aarch64 and up to 2x for memcmp.

Siddhesh

Siddhesh Poyarekar (3):
  [aarch64] Improve strncmp for mutually misaligned inputs
  [aarch64] memcmp.S: optimize for medium to large sizes
  [aarch64] strcmp.S: Improve performance for misaligned strings

 newlib/libc/machine/aarch64/memcmp.S  | 142 ++++++++++++++++++--------
 newlib/libc/machine/aarch64/strcmp.S  |  51 +++++++--
 newlib/libc/machine/aarch64/strncmp.S |  96 ++++++++++++++---
 3 files changed, 218 insertions(+), 71 deletions(-)

-- 
2.17.1

Comments

Corinna Vinschen July 2, 2018, 10:33 a.m. | #1
On Jun 29 18:08, Siddhesh Poyarekar wrote:
> Hi,

> 

> Following patches improve performance of comparing mutually misaligned

> strings by up to 3.5x on aarch64 and up to 2x for memcmp.

> 

> Siddhesh

> 

> Siddhesh Poyarekar (3):

>   [aarch64] Improve strncmp for mutually misaligned inputs

>   [aarch64] memcmp.S: optimize for medium to large sizes

>   [aarch64] strcmp.S: Improve performance for misaligned strings

> 

>  newlib/libc/machine/aarch64/memcmp.S  | 142 ++++++++++++++++++--------

>  newlib/libc/machine/aarch64/strcmp.S  |  51 +++++++--

>  newlib/libc/machine/aarch64/strncmp.S |  96 ++++++++++++++---

>  3 files changed, 218 insertions(+), 71 deletions(-)

> 

> -- 

> 2.17.1


A review from the ARM guys here, please?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat
Corinna Vinschen July 13, 2018, 11:28 a.m. | #2
On Jun 29 18:08, Siddhesh Poyarekar wrote:
> Hi,

> 

> Following patches improve performance of comparing mutually misaligned

> strings by up to 3.5x on aarch64 and up to 2x for memcmp.

> 

> Siddhesh

> 

> Siddhesh Poyarekar (3):

>   [aarch64] Improve strncmp for mutually misaligned inputs

>   [aarch64] memcmp.S: optimize for medium to large sizes

>   [aarch64] strcmp.S: Improve performance for misaligned strings

> 

>  newlib/libc/machine/aarch64/memcmp.S  | 142 ++++++++++++++++++--------

>  newlib/libc/machine/aarch64/strcmp.S  |  51 +++++++--

>  newlib/libc/machine/aarch64/strncmp.S |  96 ++++++++++++++---

>  3 files changed, 218 insertions(+), 71 deletions(-)

> 

> -- 

> 2.17.1


Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat
Siddhesh Poyarekar July 13, 2018, 12:14 p.m. | #3
On 07/13/2018 04:58 PM, Corinna Vinschen wrote:
> On Jun 29 18:08, Siddhesh Poyarekar wrote:

>> Hi,

>>

>> Following patches improve performance of comparing mutually misaligned

>> strings by up to 3.5x on aarch64 and up to 2x for memcmp.

>>

>> Siddhesh

>>

>> Siddhesh Poyarekar (3):

>>    [aarch64] Improve strncmp for mutually misaligned inputs

>>    [aarch64] memcmp.S: optimize for medium to large sizes

>>    [aarch64] strcmp.S: Improve performance for misaligned strings

>>

>>   newlib/libc/machine/aarch64/memcmp.S  | 142 ++++++++++++++++++--------

>>   newlib/libc/machine/aarch64/strcmp.S  |  51 +++++++--

>>   newlib/libc/machine/aarch64/strncmp.S |  96 ++++++++++++++---

>>   3 files changed, 218 insertions(+), 71 deletions(-)

>>

>> -- 

>> 2.17.1

> 

> Pushed.


Thank you!

Siddhesh