[v4,0/3] Guile: add value-{reference,const}-value

Message ID 1zv32w4yse9hwl6xu_qdp4c.-3tadj6st/rv1umu8uf/ys5xwod6@mail.bob131.so
Headers show
Series
  • Guile: add value-{reference,const}-value
Related show

Message

Simon Marchi via Gdb-patches April 28, 2021, 5:32 p.m.
A couple of simple patches implementing functions missing from the
Guile API (relative to the Python API). Both are straight-forward
translations of the Python implementations.

Feedback on the original series pointed out that the Python API also
has a Value.rvalue_reference_value() method and that a matching
Guile procedure should be introduced alongside value-reference-value,
owing to their similarity. The v2 series updates the patch as
indicated; an additional patch improving the Guile support for rvalue
reference types is included to allow for writing an appropriate test.

Feedback on the v2 series pointed out mistaken quoting in the texinfo
manual diff and suggested that API changes be listed in the NEWS
file. The v3 series includes improvements as suggested.

Feedback on v3 suggested that rvalue-reference-value should probably
be named value-rvalue-reference-value instead. This has been
incorporated into v4.

George Barrett (3):
  Guile: improved rvalue reference support
  Guile: add value-{rvalue-,}reference-value
  Guile: add value-const-value

 gdb/NEWS                              | 11 +++++
 gdb/doc/guile.texi                    | 18 ++++++++
 gdb/guile/scm-type.c                  |  1 +
 gdb/guile/scm-value.c                 | 66 +++++++++++++++++++++++++++
 gdb/testsuite/gdb.guile/scm-value.exp | 13 ++++++
 5 files changed, 109 insertions(+)

-- 
2.30.2

Comments

Andrew Burgess April 30, 2021, 12:19 p.m. | #1
* George Barrett via Gdb-patches <gdb-patches@sourceware.org> [2021-04-29 03:32:27 +1000]:

> A couple of simple patches implementing functions missing from the

> Guile API (relative to the Python API). Both are straight-forward

> translations of the Python implementations.

> 

> Feedback on the original series pointed out that the Python API also

> has a Value.rvalue_reference_value() method and that a matching

> Guile procedure should be introduced alongside value-reference-value,

> owing to their similarity. The v2 series updates the patch as

> indicated; an additional patch improving the Guile support for rvalue

> reference types is included to allow for writing an appropriate test.

> 

> Feedback on the v2 series pointed out mistaken quoting in the texinfo

> manual diff and suggested that API changes be listed in the NEWS

> file. The v3 series includes improvements as suggested.

> 

> Feedback on v3 suggested that rvalue-reference-value should probably

> be named value-rvalue-reference-value instead. This has been

> incorporated into v4.


I looked through all 3 patches, and they all look good to me.  I think
Eli approved the docs in v3, so you're probably OK to merge these now.

Thanks,
Andrew
Simon Marchi via Gdb-patches April 30, 2021, 4:37 p.m. | #2
On Fri, Apr 30, 2021 at 01:19:21PM +0100, Andrew Burgess wrote:
> I looked through all 3 patches, and they all look good to me.  I think

> Eli approved the docs in v3, so you're probably OK to merge these now.


I don't have commit access to the repo. Might someone be able to push these on
my behalf?

Thanks.