[PATCHv3,0/2] Add directory containing executable to relative search paths for .dwo files.

Message ID cover.1616781092.git.andrew.burgess@embecosm.com
Headers show
Series
  • Add directory containing executable to relative search paths for .dwo files.
Related show

Message

Andrew Burgess March 26, 2021, 5:54 p.m.
Caroline,

I split the testsuite changes out into a separate patch (#1), this
makes the patch containing your change (#2) much smaller, and more
focused.

If there's no feedback I'll push this early next week.

Thanks,
Andrew

---

Andrew Burgess (2):
  gdb/testsuite: fix fission support in the Dwarf assembler
  gdb: handle relative paths to DWO files

 gdb/ChangeLog                                 |   5 +
 gdb/dwarf2/read.c                             |   7 +
 gdb/testsuite/ChangeLog                       |  31 +++
 .../gdb.dwarf2/fission-absolute-dwo.c         |  28 ++
 .../gdb.dwarf2/fission-absolute-dwo.exp       | 132 ++++++++++
 gdb/testsuite/gdb.dwarf2/fission-base.exp     |  11 +-
 .../gdb.dwarf2/fission-loclists-pie.exp       |  11 +-
 gdb/testsuite/gdb.dwarf2/fission-loclists.exp |  11 +-
 gdb/testsuite/gdb.dwarf2/fission-multi-cu.exp |  11 +-
 .../gdb.dwarf2/fission-relative-dwo.c         |  28 ++
 .../gdb.dwarf2/fission-relative-dwo.exp       | 130 +++++++++
 gdb/testsuite/gdb.dwarf2/fission-reread.exp   |  15 +-
 gdb/testsuite/lib/dwarf.exp                   | 248 ++++++++++++++----
 13 files changed, 598 insertions(+), 70 deletions(-)
 create mode 100644 gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.c
 create mode 100644 gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp
 create mode 100644 gdb/testsuite/gdb.dwarf2/fission-relative-dwo.c
 create mode 100644 gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp

-- 
2.25.4

Comments

Mike Frysinger via Gdb-patches March 31, 2021, 3:57 p.m. | #1
Hi Andrew,

Just checking:  When do you expect to push this?

-- Caroline
cmtice@google.com


On Fri, Mar 26, 2021 at 10:54 AM Andrew Burgess <andrew.burgess@embecosm.com>
wrote:

> Caroline,

>

> I split the testsuite changes out into a separate patch (#1), this

> makes the patch containing your change (#2) much smaller, and more

> focused.

>

> If there's no feedback I'll push this early next week.

>

> Thanks,

> Andrew

>

> ---

>

> Andrew Burgess (2):

>   gdb/testsuite: fix fission support in the Dwarf assembler

>   gdb: handle relative paths to DWO files

>

>  gdb/ChangeLog                                 |   5 +

>  gdb/dwarf2/read.c                             |   7 +

>  gdb/testsuite/ChangeLog                       |  31 +++

>  .../gdb.dwarf2/fission-absolute-dwo.c         |  28 ++

>  .../gdb.dwarf2/fission-absolute-dwo.exp       | 132 ++++++++++

>  gdb/testsuite/gdb.dwarf2/fission-base.exp     |  11 +-

>  .../gdb.dwarf2/fission-loclists-pie.exp       |  11 +-

>  gdb/testsuite/gdb.dwarf2/fission-loclists.exp |  11 +-

>  gdb/testsuite/gdb.dwarf2/fission-multi-cu.exp |  11 +-

>  .../gdb.dwarf2/fission-relative-dwo.c         |  28 ++

>  .../gdb.dwarf2/fission-relative-dwo.exp       | 130 +++++++++

>  gdb/testsuite/gdb.dwarf2/fission-reread.exp   |  15 +-

>  gdb/testsuite/lib/dwarf.exp                   | 248 ++++++++++++++----

>  13 files changed, 598 insertions(+), 70 deletions(-)

>  create mode 100644 gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.c

>  create mode 100644 gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp

>  create mode 100644 gdb/testsuite/gdb.dwarf2/fission-relative-dwo.c

>  create mode 100644 gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp

>

> --

> 2.25.4

>

>
Andrew Burgess March 31, 2021, 8:04 p.m. | #2
* Caroline Tice <cmtice@google.com> [2021-03-31 08:57:02 -0700]:

> Hi Andrew,

> 

> Just checking:  When do you expect to push this?


Caroline,

If you've been following the thread you'll see that Simon gave some
feedback here:

  https://sourceware.org/pipermail/gdb-patches/2021-March/177342.html

And I replied here:

  https://sourceware.org/pipermail/gdb-patches/2021-March/177360.html

Which was yesterday.  I think we should probably allow a little more
time before we start chasing things.

I would probably be chasing this up in a week or so if there's been no
further follow up, then if there's no more feedback after that I'd be
happy to merge this.

Are you in a rush to get this patch merged?  Or just worried it will
get forgotten?

Thanks,
Andrew

> 

> -- Caroline

> cmtice@google.com

> 

> 

> On Fri, Mar 26, 2021 at 10:54 AM Andrew Burgess <andrew.burgess@embecosm.com>

> wrote:

> 

> > Caroline,

> >

> > I split the testsuite changes out into a separate patch (#1), this

> > makes the patch containing your change (#2) much smaller, and more

> > focused.

> >

> > If there's no feedback I'll push this early next week.

> >

> > Thanks,

> > Andrew

> >

> > ---

> >

> > Andrew Burgess (2):

> >   gdb/testsuite: fix fission support in the Dwarf assembler

> >   gdb: handle relative paths to DWO files

> >

> >  gdb/ChangeLog                                 |   5 +

> >  gdb/dwarf2/read.c                             |   7 +

> >  gdb/testsuite/ChangeLog                       |  31 +++

> >  .../gdb.dwarf2/fission-absolute-dwo.c         |  28 ++

> >  .../gdb.dwarf2/fission-absolute-dwo.exp       | 132 ++++++++++

> >  gdb/testsuite/gdb.dwarf2/fission-base.exp     |  11 +-

> >  .../gdb.dwarf2/fission-loclists-pie.exp       |  11 +-

> >  gdb/testsuite/gdb.dwarf2/fission-loclists.exp |  11 +-

> >  gdb/testsuite/gdb.dwarf2/fission-multi-cu.exp |  11 +-

> >  .../gdb.dwarf2/fission-relative-dwo.c         |  28 ++

> >  .../gdb.dwarf2/fission-relative-dwo.exp       | 130 +++++++++

> >  gdb/testsuite/gdb.dwarf2/fission-reread.exp   |  15 +-

> >  gdb/testsuite/lib/dwarf.exp                   | 248 ++++++++++++++----

> >  13 files changed, 598 insertions(+), 70 deletions(-)

> >  create mode 100644 gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.c

> >  create mode 100644 gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp

> >  create mode 100644 gdb/testsuite/gdb.dwarf2/fission-relative-dwo.c

> >  create mode 100644 gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp

> >

> > --

> > 2.25.4

> >

> >