[0/4] Changes around calendar time [BZ #24293][BZ #22964]

Message ID 201904010352.AA04315@tamuki.linet.gr.jp
Headers show
Series
  • Changes around calendar time [BZ #24293][BZ #22964]
Related show

Message

TAMUKI Shoichi April 1, 2019, 3:52 a.m.
Hello,

This is the new set of patches.  There are 4 patches.

Changes include:

Patch 1: NEWS: Mention Minguo calendar support added [BZ #24293]
Patch 2: time/tst-strftime2.c: Make the file easier to maintain
Patch 3: time: Add tests for Minguo calendar [BZ #24293]
Patch 4: ja_JP locale: Add entry for the new Japanese era [BZ #22964]

Regards,
TAMUKI Shoichi

Comments

Carlos O'Donell April 1, 2019, 8:39 p.m. | #1
On 3/31/19 11:52 PM, TAMUKI Shoichi wrote:
> Hello,

> 

> This is the new set of patches.  There are 4 patches.

> 

> Changes include:

> 

> Patch 1: NEWS: Mention Minguo calendar support added [BZ #24293]

> Patch 2: time/tst-strftime2.c: Make the file easier to maintain

> Patch 3: time: Add tests for Minguo calendar [BZ #24293]

> Patch 4: ja_JP locale: Add entry for the new Japanese era [BZ #22964]


I have reviewed all 4 patches.

They are OK to commit to master if you fix the requested changes in each
of the patches, and even then they are just cosmetic changes I'd like to
see.

I would like to see your patches go in ASAP.

We do not need to wait for Rafal for review, between a native language
speaker, and my review, this is sufficient for consensus.

-- 
Cheers,
Carlos.
Rafal Luzynski April 1, 2019, 10:48 p.m. | #2
Carlos,

1.04.2019 22:39 Carlos O'Donell <codonell@redhat.com> wrote:
> [...]

> I have reviewed all 4 patches.


Thank you for all your reviews.

> They are OK to commit to master if you fix the requested changes in each

> of the patches, and even then they are just cosmetic changes I'd like to

> see.

> 

> I would like to see your patches go in ASAP.


TAMUKI-san, one last remark: please use the format [PATCH v2 0/4]
or [PATCH v3 0/4] when you post a new version of the same patch set.
"git format-patch -v 3" will do it automatically for you.

> We do not need to wait for Rafal for review, between a native language

> speaker, and my review, this is sufficient for consensus.


I also confirm that I saw these patches and provided my limited feedback.
I have nothing more to add here.  I have just expressed one more minor
suggestion but even if it is rejected I am fine with these patches.

Regards,

Rafal
TAMUKI Shoichi April 2, 2019, 9:16 a.m. | #3
Hello Carlos-san,

From: Carlos O'Donell <codonell@redhat.com>

Subject: Re: [PATCH 0/4] Changes around calendar time [BZ #24293][BZ #22964]
Date: Mon, 1 Apr 2019 16:39:14 -0400

> > This is the new set of patches.  There are 4 patches.

> > 

> > Changes include:

> > 

> > Patch 1: NEWS: Mention Minguo calendar support added [BZ #24293]

> > Patch 2: time/tst-strftime2.c: Make the file easier to maintain

> > Patch 3: time: Add tests for Minguo calendar [BZ #24293]

> > Patch 4: ja_JP locale: Add entry for the new Japanese era [BZ #22964]

> 

> I have reviewed all 4 patches.

> 

> They are OK to commit to master if you fix the requested changes in each

> of the patches, and even then they are just cosmetic changes I'd like to

> see.

> 

> I would like to see your patches go in ASAP.


I fixed the parts you requested changes and then committed them to
master.

Regards,
TAMUKI Shoichi
Rafal Luzynski April 2, 2019, 8:45 p.m. | #4
2.04.2019 11:16 TAMUKI Shoichi <tamuki@linet.gr.jp> wrote:
> [...]

> I fixed the parts you requested changes and then committed them to

> master.


Thank you TAMUKI-san and everyone else for working on this.  Now
I think this work would be incomplete if it is not backported to
old stable branches, at least few of them.  Otherwise Japanese users
will have to wait until later this year for the patches to land in
their computers.  The backport will not be a trivial task, probably
we don't want to backport all patches from this series (do we need
test cases?)  Any thoughts?  Carlos?

Regards,

Rafal
Carlos O'Donell April 3, 2019, 3:49 a.m. | #5
On 4/2/19 4:45 PM, Rafal Luzynski wrote:
> 2.04.2019 11:16 TAMUKI Shoichi <tamuki@linet.gr.jp> wrote:

>> [...]

>> I fixed the parts you requested changes and then committed them to

>> master.

> 

> Thank you TAMUKI-san and everyone else for working on this.  Now

> I think this work would be incomplete if it is not backported to

> old stable branches, at least few of them.  Otherwise Japanese users

> will have to wait until later this year for the patches to land in

> their computers.  The backport will not be a trivial task, probably

> we don't want to backport all patches from this series (do we need

> test cases?)  Any thoughts?  Carlos?


Yes, we should backport just the ja_JP era update.

I've spoken to the Fedora glibc team about this and we're going to
do the backports for Fedora.

Arjun is doing the 2.29 backport so that we can update F30.

DJ is doing the 2.28 backport so that we can update F29.

I'm doing the 2.27 backport so that we can update F28.

-- 
Cheers,
Carlos.