[0/2] Fix memory leaks in create_ada_exception_catchpoint

Message ID 20190213134505.20005-1-tromey@adacore.com
Headers show
Series
  • Fix memory leaks in create_ada_exception_catchpoint
Related show

Message

Tom Tromey Feb. 13, 2019, 1:45 p.m.
These patches fix a couple of memory leaks in
create_ada_exception_catchpoint.  This is based on Philippe's patch
and analysis.

Tested on x86-64 Fedora 29.  I also tried "catch exception" under
valgrind to verify the fix.

Tom

Comments

Philippe Waroquiers Feb. 13, 2019, 9:23 p.m. | #1
I have read the patches and they look ok to me.
IMO, citing me as having done an analysis is largely
good enough (as you have written the patches).

Thanks for doing this,

Philippe



On Wed, 2019-02-13 at 06:45 -0700, Tom Tromey wrote:
> These patches fix a couple of memory leaks in

> create_ada_exception_catchpoint.  This is based on Philippe's patch

> and analysis.

> 

> Tested on x86-64 Fedora 29.  I also tried "catch exception" under

> valgrind to verify the fix.

> 

> Tom

> 

>
Tom Tromey Feb. 15, 2019, 8:20 p.m. | #2
>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:


Philippe> I have read the patches and they look ok to me.
Philippe> IMO, citing me as having done an analysis is largely
Philippe> good enough (as you have written the patches).

Philippe> Thanks for doing this,

Thanks.  I'm going to check these in shortly.

Tom