[v9,0/2] strftime: Improve the width of alternative representation for year [BZ #23758][BZ #24096]

Message ID 201901220144.AA04206@tamuki.linet.gr.jp
Headers show
Series
  • strftime: Improve the width of alternative representation for year [BZ #23758][BZ #24096]
Related show

Message

TAMUKI Shoichi Jan. 22, 2019, 1:44 a.m.
Hello,

This is the new set of patches.  I have split the patch into 2 parts.

Note, Patch 1 is same as v8.

Changes include:

Patch 1: strftime: Set the default width of "%Ey" to 2
Patch 2: strftime: Pass the additional flags from "%EY" to "%Ey"

Regards,
TAMUKI Shoichi

Comments

Rafal Luzynski Jan. 22, 2019, 11:43 p.m. | #1
22.01.2019 02:44 TAMUKI Shoichi <tamuki@linet.gr.jp> wrote:
> 

> Hello,

> 

> This is the new set of patches.  I have split the patch into 2 parts.

> 

> Note, Patch 1 is same as v8.

> 

> Changes include:

> 

> Patch 1: strftime: Set the default width of "%Ey" to 2

> Patch 2: strftime: Pass the additional flags from "%EY" to "%Ey"


Both patches look good to me.  Especially the first one since it
is the same as the previous version which I already said was OK,
and since this patch actually changes only one line of the code
and other lines change just the documentation.

My suggestion: please wait a while to let the other maintainers
express their final opinion and push them to the repository if
nobody replies or if anybody asks you to push immediately.

I think that waiting 24 hours from now or maximum 48 hours is enough.

Please remember to update the ChangeLog when pushing and to close
the bug reports.  And then please port these changes to Gnulib.

Again thank you for working on this.

Regards,

Rafal
TAMUKI Shoichi Jan. 25, 2019, 9:08 a.m. | #2
Hello all,

Late last night in Japan time, I have commited both patches and push
them to master.  Thank you Florian, Rafal, Paul, Siddhesh, Carlos,
Joseph, Andreas, Zack, and everyone else for your reviews,
documentation updates, assistance, etc.

From: Rafal Luzynski <digitalfreak@lingonborough.com>

Subject: Re: [PATCH v9 0/2] strftime: Improve the width of alternative representation for year [BZ #23758][BZ #24096]
Date: Wed, 23 Jan 2019 00:43:22 +0100 (CET)

> Please remember to update the ChangeLog when pushing and to close

> the bug reports.  And then please port these changes to Gnulib.


I set both bugs to be RESOLVED as FIXED in Bugzilla, but I could not
change the target milestone to 2.29 (Joseph did it).  Parhaps, it
seems I do not have the editbugs group access. [1]

[1] https://sourceware.org/glibc/wiki/Bugzilla%20Procedures

Can I get the ability to edit bugs?

Thank you again for your help.

Regards,
TAMUKI Shoichi
Florian Weimer Jan. 25, 2019, 10:57 a.m. | #3
* TAMUKI Shoichi:

> I set both bugs to be RESOLVED as FIXED in Bugzilla, but I could not

> change the target milestone to 2.29 (Joseph did it).  Parhaps, it

> seems I do not have the editbugs group access. [1]

>

> [1] https://sourceware.org/glibc/wiki/Bugzilla%20Procedures

>

> Can I get the ability to edit bugs?


I have assigned editbugs privileges to you.

Thanks,
Florian