From patchwork Sat Feb 20 07:59:29 2021
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Fail run_dump_test when an error is expected but not seen
X-Patchwork-Submitter: Alan Modra via Binutils <binutils@sourceware.org>
X-Patchwork-Id: 49381
Message-Id: <20210220075929.GG17920@bubble.grove.modra.org>
To: binutils@sourceware.org
Date: Sat, 20 Feb 2021 18:29:29 +1030
From: Alan Modra via Binutils <binutils@sourceware.org>
List-Id: Binutils mailing list <binutils.sourceware.org>

This is a -w diff.

	* testsuite/lib/binutils-common.exp: Whitespace fixes throughout.
	(run_dump_test): Fail if expecting errors from a file like we do
	for error strings, if no error is seen.


-- 
Alan Modra
Australia Development Lab, IBM

diff --git a/binutils/testsuite/lib/binutils-common.exp b/binutils/testsuite/lib/binutils-common.exp
index 029284167a..59e25df99b 100644
--- a/binutils/testsuite/lib/binutils-common.exp
+++ b/binutils/testsuite/lib/binutils-common.exp
@@ -1438,7 +1438,7 @@ proc run_dump_test { name {extra_options {}} } {
 	}
 
 	# We must not have expected failure if we get here.
-        if { $opts(error) != "" } {
+	if { $want_out(terminal) } {
 	    fail $testname
 	    continue
 	}