[testsuite] Minor tweak to 4 Aarch64 testcases

Message ID 9173498.03PerbReGJ@polaris
State New
Headers show
Series
  • [testsuite] Minor tweak to 4 Aarch64 testcases
Related show

Commit Message

Eric Botcazou July 13, 2018, 8:23 a.m.
These 4 Aarch64 testcases use dg-xfail-if to disable themselves on ARM, while 
all the other equivalent testcases use dg-skip-if.  The latter form is better 
because it doesn't unnecessarily pollute the testsuite report.

Tested on arm-eabi, OK for the mainline?


2018-07-13  Eric Botcazou  <ebotcazou@adacore.com>

	* gcc.target/aarch64/advsimd-intrinsics/vld1x2.c: Replace dg-xfail-if
	with dg-skip-if for ARM targets.
	* gcc.target/aarch64/advsimd-intrinsics/vld1x3.c: Likewise.
	* gcc.target/aarch64/advsimd-intrinsics/vst1x2.c: Likewise.
	* gcc.target/aarch64/advsimd-intrinsics/vst1x3.c: Likewise.

-- 
Eric Botcazou

Comments

Kyrill Tkachov July 13, 2018, 8:52 a.m. | #1
Hi Eric,

On 13/07/18 09:23, Eric Botcazou wrote:
> These 4 Aarch64 testcases use dg-xfail-if to disable themselves on ARM, while

> all the other equivalent testcases use dg-skip-if.  The latter form is better

> because it doesn't unnecessarily pollute the testsuite report.

>

> Tested on arm-eabi, OK for the mainline?

>

>


I used xfail for these testcases in particular because the intrinsics that they test
should be available for both arm and aarch64.
They are currently not implemented on arm, even though they should be.
The other tests that are skipped instead of xfailed test intrinsics that should
only be available on aarch64 and not arm.

Cheers,
Kyrill

> 2018-07-13  Eric Botcazou  <ebotcazou@adacore.com>

>

>         * gcc.target/aarch64/advsimd-intrinsics/vld1x2.c: Replace dg-xfail-if

>         with dg-skip-if for ARM targets.

>         * gcc.target/aarch64/advsimd-intrinsics/vld1x3.c: Likewise.

>         * gcc.target/aarch64/advsimd-intrinsics/vst1x2.c: Likewise.

>         * gcc.target/aarch64/advsimd-intrinsics/vst1x3.c: Likewise.

>

> -- 

> Eric Botcazou
Eric Botcazou July 13, 2018, 9:57 a.m. | #2
> I used xfail for these testcases in particular because the intrinsics that

> they test should be available for both arm and aarch64.

> They are currently not implemented on arm, even though they should be.

> The other tests that are skipped instead of xfailed test intrinsics that

> should only be available on aarch64 and not arm.


OK, thanks for the explanation.

-- 
Eric Botcazou

Patch

Index: gcc.target/aarch64/advsimd-intrinsics/vld1x2.c
===================================================================
--- gcc.target/aarch64/advsimd-intrinsics/vld1x2.c	(revision 262551)
+++ gcc.target/aarch64/advsimd-intrinsics/vld1x2.c	(working copy)
@@ -1,7 +1,7 @@ 
 /* We haven't implemented these intrinsics for arm yet.  */
-/* { dg-xfail-if "" { arm*-*-* } } */
 /* { dg-do run } */
 /* { dg-options "-O3" } */
+/* { dg-skip-if "" { arm*-*-* } } */
 
 #include <arm_neon.h>
 
Index: gcc.target/aarch64/advsimd-intrinsics/vld1x3.c
===================================================================
--- gcc.target/aarch64/advsimd-intrinsics/vld1x3.c	(revision 262551)
+++ gcc.target/aarch64/advsimd-intrinsics/vld1x3.c	(working copy)
@@ -1,7 +1,7 @@ 
 /* We haven't implemented these intrinsics for arm yet.  */
-/* { dg-xfail-if "" { arm*-*-* } } */
 /* { dg-do run } */
 /* { dg-options "-O3" } */
+/* { dg-skip-if "" { arm*-*-* } } */
 
 #include <arm_neon.h>
 #include "arm-neon-ref.h"
Index: gcc.target/aarch64/advsimd-intrinsics/vst1x2.c
===================================================================
--- gcc.target/aarch64/advsimd-intrinsics/vst1x2.c	(revision 262551)
+++ gcc.target/aarch64/advsimd-intrinsics/vst1x2.c	(working copy)
@@ -1,7 +1,7 @@ 
 /* We haven't implemented these intrinsics for arm yet.  */
-/* { dg-xfail-if "" { arm*-*-* } } */
 /* { dg-do run } */
 /* { dg-options "-O3" } */
+/* { dg-skip-if "" { arm*-*-* } } */
 
 #include <arm_neon.h>
 #include "arm-neon-ref.h"
Index: gcc.target/aarch64/advsimd-intrinsics/vst1x3.c
===================================================================
--- gcc.target/aarch64/advsimd-intrinsics/vst1x3.c	(revision 262551)
+++ gcc.target/aarch64/advsimd-intrinsics/vst1x3.c	(working copy)
@@ -1,7 +1,7 @@ 
 /* We haven't implemented these intrinsics for arm yet.  */
-/* { dg-xfail-if "" { arm*-*-* } } */
 /* { dg-do run } */
 /* { dg-options "-O3" } */
+/* { dg-skip-if "" { arm*-*-* } } */
 
 #include <arm_neon.h>
 #include "arm-neon-ref.h"