[11/12] ldbl-128ibm-compat: Redirect complex math functions

Message ID 20180620020426.20372-12-tuliom@linux.ibm.com
State New
Headers show
Series
  • Introduce ieee128 symbols and redirections
Related show

Commit Message

Tulio Magno Quites Machado Filho June 20, 2018, 2:04 a.m.
From: Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>


The API doesn't change, i.e. compilers using a long double format compatible
with the IEEE 128-bit extended precision format are redirected from *l
functions to __*ieee128 symbols using the same mechanism already
used with -mlong-double-64 for complex math functions.

2018-06-19  Rajalakshmi Srinivasaraghavan  <raji@linux.vnet.ibm.com>

	* math/complex.h [__HAVE_DISTINCT_FLOAT128 &&
	!__HAVE_FLOAT128_UNLIKE_LDBL]: 	Redirect long double functions
	to __*ieee128.
---
 math/complex.h | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

-- 
2.14.4

Comments

Joseph Myers June 20, 2018, 9 p.m. | #1
I don't see any test infrastructure in this patch series for either the 
math.h or complex.h functions.  Is that to be added separately?

Principles include:

* As ulps are currently identified as "ldouble" and "float128", those need 
to be appropriately associated with the correct formats in testing (which 
the testing already handles for getting _FloatN tests using the 
appropriate ulps, whatever type name those ulps may be listed with).

* The libm functions built for each format should be tested.  While most 
of the functions built for float128 are at least tested under their *f128 
names, you have those such as __significandieee128 which don't have such a 
name and so need testing added for the code to get tested at all.

* There should be at least some test coverage that the redirection works, 
i.e. tests built and run with binary128 long double.

-- 
Joseph S. Myers
joseph@codesourcery.com
Tulio Magno Quites Machado Filho June 21, 2018, 7:05 p.m. | #2
Joseph Myers <joseph@codesourcery.com> writes:

> I don't see any test infrastructure in this patch series for either the 

> math.h or complex.h functions.  Is that to be added separately?


Yes.  I was planning to send it with the last patch set as it depends on
other changes to sysdeps/powerpc/powerpc64/le/Makefile.

> Principles include:

>

> * As ulps are currently identified as "ldouble" and "float128", those need 

> to be appropriately associated with the correct formats in testing (which 

> the testing already handles for getting _FloatN tests using the 

> appropriate ulps, whatever type name those ulps may be listed with).


OK.

> * The libm functions built for each format should be tested.  While most 

> of the functions built for float128 are at least tested under their *f128 

> names, you have those such as __significandieee128 which don't have such a 

> name and so need testing added for the code to get tested at all.

>

> * There should be at least some test coverage that the redirection works, 

> i.e. tests built and run with binary128 long double.


The proposal is to build all ldouble tests twice: one for -mabi=ieeelongdouble
and another for -mabi=ibmlongdouble.
So, I think both of these concerns are covered.

-- 
Tulio Magno

Patch

diff --git a/math/complex.h b/math/complex.h
index 40cf8e0705..8e917105bc 100644
--- a/math/complex.h
+++ b/math/complex.h
@@ -95,9 +95,11 @@  __BEGIN_DECLS
 
 #define __MATHCALL(function, args)	\
   __MATHDECL (_Mdouble_complex_,function, args)
-#define __MATHDECL(type, function, args) \
+#define __MATHDECL_IMPL(type, function, args) \
   __MATHDECL_1(type, function, args); \
   __MATHDECL_1(type, __CONCAT(__,function), args)
+#define __MATHDECL(type, function, args) \
+  __MATHDECL_IMPL(type, function, args)
 #define __MATHDECL_1_IMPL(type, function, args) \
   extern type __MATH_PRECNAME(function) args __THROW
 #define __MATHDECL_1(type, function, args) \
@@ -124,13 +126,28 @@  __BEGIN_DECLS
 #  undef __MATHDECL_1
 #  define __MATHDECL_1(type, function, args) \
   extern type __REDIRECT_NTH(__MATH_PRECNAME(function), args, function)
+# elif __HAVE_DISTINCT_FLOAT128 && !__HAVE_FLOAT128_UNLIKE_LDBL
+#  undef __MATHDECL_1
+#  undef __MATHDECL
+#  define __REDIR_TO(function) \
+  __ ## function ## ieee128
+#  define __MATHDECL_1(type, function, alias, args) \
+  extern type __REDIRECT_NTH(__MATH_PRECNAME(function), args, alias)
+#define __MATHDECL(type, function, args) \
+  __MATHDECL_1(type, function, __REDIR_TO(function), args); \
+  __MATHDECL_1(type, __CONCAT(__,function), __REDIR_TO(function), args)
 # endif
 
 # define _Mdouble_ 		long double
 # define __MATH_PRECNAME(name)	name##l
 # include <bits/cmathcalls.h>
-# if defined __LDBL_COMPAT
+# if defined __LDBL_COMPAT \
+     || (__HAVE_DISTINCT_FLOAT128 && !__HAVE_FLOAT128_UNLIKE_LDBL)
+#  undef __REDIR_TO
 #  undef __MATHDECL_1
+#  undef __MATHDECL
+#define __MATHDECL(type, function, args) \
+  __MATHDECL_IMPL(type, function, args)
 #  define __MATHDECL_1(type, function, args) \
   __MATHDECL_1_IMPL(type, function, args)
 # endif