[v3,2/2] ada: add 128bit operation to MIPS N32 and N64

Message ID 20210223030604.15924-2-yunqiang.su@cipunited.com
State New
Headers show
Series
  • [v3,1/2] MIPS: unaligned load: use SImode for SUBREG if OK (PR98996)
Related show

Commit Message

YunQiang Su Feb. 23, 2021, 3:06 a.m.
For MIPS N64 and N32:
  add GNATRTL_128BIT_PAIRS to LIBGNAT_TARGET_PAIRS
  add GNATRTL_128BIT_OBJS to EXTRA_GNATRTL_NONTASKING_OBJS

gcc/ada/ChangeLog:
	PR ada/98996
	* Makefile.rtl: <mips*-*-linux*> add 128Bit operation file to MIPS
	N64 and N32 (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS).
---
 gcc/ada/ChangeLog    |  6 ++++++
 gcc/ada/Makefile.rtl | 12 ++++++++++++
 2 files changed, 18 insertions(+)

-- 
2.20.1

Comments

Arnaud Charlet Feb. 23, 2021, 9:07 a.m. | #1
> For MIPS N64 and N32:

>   add GNATRTL_128BIT_PAIRS to LIBGNAT_TARGET_PAIRS

>   add GNATRTL_128BIT_OBJS to EXTRA_GNATRTL_NONTASKING_OBJS

> 

> gcc/ada/ChangeLog:

> 	PR ada/98996

> 	* Makefile.rtl: <mips*-*-linux*> add 128Bit operation file to MIPS

> 	N64 and N32 (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS).


As for the other recent submit, the ChangeLog file is now generated
automatically.

The Makefile.rtl change is OK.

Arno
Kewen.Lin via Gcc-patches Feb. 23, 2021, 9:27 a.m. | #2
Arnaud Charlet <charlet@adacore.com> 于2021年2月23日周二 下午5:07写道:
>

> > For MIPS N64 and N32:

> >   add GNATRTL_128BIT_PAIRS to LIBGNAT_TARGET_PAIRS

> >   add GNATRTL_128BIT_OBJS to EXTRA_GNATRTL_NONTASKING_OBJS

> >

> > gcc/ada/ChangeLog:

> >       PR ada/98996

> >       * Makefile.rtl: <mips*-*-linux*> add 128Bit operation file to MIPS

> >       N64 and N32 (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS).

>

> As for the other recent submit, the ChangeLog file is now generated

> automatically.


I did generate the ChangeLog by contrib/mklog.py by:
     contrib/mklog.py 0002_MY_PATCH.patch
and get an empty ChangeLog template.

gcc/ada/ChangeLog:

        * ChangeLog:
        * Makefile.rtl:

So, should I keep it as is?




>

> The Makefile.rtl change is OK.

>

> Arno




--
YunQiang Su
Arnaud Charlet Feb. 23, 2021, 9:33 a.m. | #3
> > > For MIPS N64 and N32:

> > >   add GNATRTL_128BIT_PAIRS to LIBGNAT_TARGET_PAIRS

> > >   add GNATRTL_128BIT_OBJS to EXTRA_GNATRTL_NONTASKING_OBJS

> > >

> > > gcc/ada/ChangeLog:

> > >       PR ada/98996

> > >       * Makefile.rtl: <mips*-*-linux*> add 128Bit operation file to MIPS

> > >       N64 and N32 (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS).

> >

> > As for the other recent submit, the ChangeLog file is now generated

> > automatically.

> 

> I did generate the ChangeLog by contrib/mklog.py by:

>      contrib/mklog.py 0002_MY_PATCH.patch

> and get an empty ChangeLog template.

> 

> gcc/ada/ChangeLog:

> 

>         * ChangeLog:

>         * Makefile.rtl:

> 

> So, should I keep it as is?


The ChangeLog file is generated automatically, so you should not touch it.

Arno
Kewen.Lin via Gcc-patches Feb. 23, 2021, 9:53 a.m. | #4
Arnaud Charlet <charlet@adacore.com> 于2021年2月23日周二 下午5:33写道:
>

> > > > For MIPS N64 and N32:

> > > >   add GNATRTL_128BIT_PAIRS to LIBGNAT_TARGET_PAIRS

> > > >   add GNATRTL_128BIT_OBJS to EXTRA_GNATRTL_NONTASKING_OBJS

> > > >

> > > > gcc/ada/ChangeLog:

> > > >       PR ada/98996

> > > >       * Makefile.rtl: <mips*-*-linux*> add 128Bit operation file to MIPS

> > > >       N64 and N32 (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS).

> > >

> > > As for the other recent submit, the ChangeLog file is now generated

> > > automatically.

> >

> > I did generate the ChangeLog by contrib/mklog.py by:

> >      contrib/mklog.py 0002_MY_PATCH.patch

> > and get an empty ChangeLog template.

> >

> > gcc/ada/ChangeLog:

> >

> >         * ChangeLog:

> >         * Makefile.rtl:

> >

> > So, should I keep it as is?

>

> The ChangeLog file is generated automatically, so you should not touch it.


Thank you. I got it. so the the ChangeLog file is generated for the
ChangeLog section of commit msg?

>

> Arno




-- 
YunQiang Su
Arnaud Charlet Feb. 23, 2021, 11:21 a.m. | #5
>>> I did generate the ChangeLog by contrib/mklog.py by:

>>>     contrib/mklog.py 0002_MY_PATCH.patch

>>> and get an empty ChangeLog template.

>>> 

>>> gcc/ada/ChangeLog:

>>> 

>>>        * ChangeLog:

>>>        * Makefile.rtl:

>>> 

>>> So, should I keep it as is?

>> 

>> The ChangeLog file is generated automatically, so you should not touch it.

> 

> Thank you. I got it. so the the ChangeLog file is generated for the

> ChangeLog section of commit msg?


It’s generated from the commit log, yes.

Arno

Patch

diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog
index 52faefaa2ae..fb09986bde0 100644
--- a/gcc/ada/ChangeLog
+++ b/gcc/ada/ChangeLog
@@ -1,3 +1,9 @@ 
+2021-02-23  YunQiang Su  <yunqiang.su@cipunited.com>
+
+	PR ada/98996
+	* Makefile.rtl: <mips*-*-linux*> add 128Bit operation file to MIPS
+	N64 and N32 (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS).
+
 2021-02-12  Arnaud Charlet  <charlet@adacore.com>
 
 	* repinfo.ads, repinfo.adb (*SO_Ref*): Restore.
diff --git a/gcc/ada/Makefile.rtl b/gcc/ada/Makefile.rtl
index 35faf13ea46..987eff0abba 100644
--- a/gcc/ada/Makefile.rtl
+++ b/gcc/ada/Makefile.rtl
@@ -2311,6 +2311,18 @@  ifeq ($(strip $(filter-out mips% linux%,$(target_cpu) $(target_os))),)
   s-tpopsp.adb<libgnarl/s-tpopsp__posix-foreign.adb \
   system.ads<libgnat/system-linux-mips.ads
 
+  ifeq ($(strip $(filter-out mips64% mipsisa64%,$(target_cpu))),)
+    ifneq ($(strip $(MULTISUBDIR)),/32)
+      LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)
+      EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)
+    endif
+  else
+    ifneq ($(strip $(filter /64 /n32,$(MULTISUBDIR))),)
+      LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)
+      EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)
+    endif
+  endif
+
   TOOLS_TARGET_PAIRS = indepsw.adb<indepsw-gnu.adb
 
   EXTRA_GNATRTL_TASKING_OBJS=s-linux.o