[RFA,1/9] Remove internal_complaint

Message ID 20180522050704.10845-2-tom@tromey.com
State New
Headers show
Series
  • Radically simplify the complaint system
Related show

Commit Message

Tom Tromey May 22, 2018, 5:06 a.m.
I happened to notice that gdb has both complaint_internal and
internal_complaint.  The latter is unused, so this patch removes it.

gdb/ChangeLog
2018-05-21  Tom Tromey  <tom@tromey.com>

	* complaints.c (internal_complaint): Remove.
	* complaints.h (internal_complaint): Remove.
---
 gdb/ChangeLog    |  5 +++++
 gdb/complaints.c | 10 ----------
 gdb/complaints.h |  5 -----
 3 files changed, 5 insertions(+), 15 deletions(-)

-- 
2.13.6

Patch

diff --git a/gdb/complaints.c b/gdb/complaints.c
index 44e98f8dad..9e5df396eb 100644
--- a/gdb/complaints.c
+++ b/gdb/complaints.c
@@ -245,16 +245,6 @@  complaint_internal (struct complaints **complaints, const char *fmt, ...)
   va_end (args);
 }
 
-void
-internal_complaint (struct complaints **complaints, const char *file,
-		    int line, const char *fmt, ...)
-{
-  va_list args;
-  va_start (args, fmt);
-  vcomplaint (complaints, file, line, fmt, args);
-  va_end (args);
-}
-
 /* Clear out / initialize all complaint counters that have ever been
    incremented.  If LESS_VERBOSE is 1, be less verbose about
    successive complaints, since the messages are appearing all
diff --git a/gdb/complaints.h b/gdb/complaints.h
index 3c1b3c5c6b..37648fb525 100644
--- a/gdb/complaints.h
+++ b/gdb/complaints.h
@@ -47,11 +47,6 @@  extern void complaint_internal (struct complaints **complaints,
     }								\
   while (0)
 
-extern void internal_complaint (struct complaints **complaints,
-				const char *file, int line,
-				const char *fmt,
-				...) ATTRIBUTE_PRINTF (4, 5);
-
 /* Clear out / initialize all complaint counters that have ever been
    incremented.  If LESS_VERBOSE is 1, be less verbose about
    successive complaints, since the messages are appearing all