[v3,150/206] Introduce opencl_notequal_operation

Message ID 20210220201609.838264-151-tom@tromey.com
State New
Headers show
Series
  • Refactor expressions
Related show

Commit Message

Tom Tromey Feb. 20, 2021, 8:15 p.m.
This adds the opencl_notequal_operation typedef, implementing "!=" for
OpenCL.

gdb/ChangeLog
2021-02-20  Tom Tromey  <tom@tromey.com>

	* opencl-lang.c (opencl_logical_not): No longer static.  Change
	parameters.
	(evaluate_subexp_opencl): Update.
	* c-exp.h (opencl_notequal_operation): New typedef.
---
 gdb/ChangeLog     | 7 +++++++
 gdb/c-exp.h       | 8 ++++++++
 gdb/opencl-lang.c | 8 +++++---
 3 files changed, 20 insertions(+), 3 deletions(-)

-- 
2.26.2

Patch

diff --git a/gdb/c-exp.h b/gdb/c-exp.h
index dc92e7a49a8..1afe2d2fbee 100644
--- a/gdb/c-exp.h
+++ b/gdb/c-exp.h
@@ -38,6 +38,11 @@  extern struct value *opencl_relop (struct type *expect_type,
 				   struct expression *exp,
 				   enum noside noside, enum exp_opcode op,
 				   struct value *arg1, struct value *arg2);
+extern struct value *opencl_logical_not (struct type *expect_type,
+					 struct expression *exp,
+					 enum noside noside,
+					 enum exp_opcode op,
+					 struct value *arg);
 
 namespace expr
 {
@@ -162,6 +167,9 @@  using opencl_geq_operation = opencl_binop_operation<BINOP_GEQ,
 using opencl_leq_operation = opencl_binop_operation<BINOP_LEQ,
 						    opencl_relop>;
 
+using opencl_not_operation = unop_operation<UNOP_LOGICAL_NOT,
+					    opencl_logical_not>;
+
 }/* namespace expr */
 
 #endif /* C_EXP_H */
diff --git a/gdb/opencl-lang.c b/gdb/opencl-lang.c
index 01456055015..8ddcd76c589 100644
--- a/gdb/opencl-lang.c
+++ b/gdb/opencl-lang.c
@@ -441,8 +441,10 @@  opencl_component_ref (struct expression *exp, struct value *val,
 
 /* Perform the unary logical not (!) operation.  */
 
-static struct value *
-opencl_logical_not (struct expression *exp, struct value *arg)
+struct value *
+opencl_logical_not (struct type *expect_type, struct expression *exp,
+		    enum noside noside, enum exp_opcode op,
+		    struct value *arg)
 {
   struct type *type = check_typedef (value_type (arg));
   struct type *rettype;
@@ -765,7 +767,7 @@  evaluate_subexp_opencl (struct type *expect_type, struct expression *exp,
 	return value_from_longest (builtin_type (exp->gdbarch)->
 				   builtin_int, 1);
 
-      return opencl_logical_not (exp, arg1);
+      return opencl_logical_not (expect_type, exp, noside, op, arg1);
 
     /* Handle the logical operator and(&&) and or(||).  */
     case BINOP_LOGICAL_AND: