string: Work around GCC PR 98512 in rawmemchr

Message ID 87a6s0azr6.fsf@oldenburg.str.redhat.com
State New
Headers show
Series
  • string: Work around GCC PR 98512 in rawmemchr
Related show

Commit Message

DJ Delorie via Libc-alpha Feb. 19, 2021, 2:38 p.m.
The GCC fix is not likely to land in GCC 11.

Thanks,
Florian
---
 string/rawmemchr.c | 26 +++++++++++++++-----------
 1 file changed, 15 insertions(+), 11 deletions(-)

Comments

Siddhesh Poyarekar Feb. 19, 2021, 3:08 p.m. | #1
On 2/19/21 8:08 PM, Florian Weimer via Libc-alpha wrote:
> The GCC fix is not likely to land in GCC 11.

> 


This is fine.

Thanks,
Siddhesh

Patch

diff --git a/string/rawmemchr.c b/string/rawmemchr.c
index 59bbeeaa42..b8523118e5 100644
--- a/string/rawmemchr.c
+++ b/string/rawmemchr.c
@@ -22,24 +22,28 @@ 
 # define RAWMEMCHR __rawmemchr
 #endif
 
+/* The pragmata should be nested inside RAWMEMCHR below, but that
+   triggers GCC PR 98512.  */
+DIAG_PUSH_NEEDS_COMMENT;
+#if __GNUC_PREREQ (7, 0)
+/* GCC 8 warns about the size passed to memchr being larger than
+   PTRDIFF_MAX; the use of SIZE_MAX is deliberate here.  */
+DIAG_IGNORE_NEEDS_COMMENT (8, "-Wstringop-overflow=");
+#endif
+#if __GNUC_PREREQ (11, 0)
+/* Likewise GCC 11, with a different warning option.  */
+DIAG_IGNORE_NEEDS_COMMENT (11, "-Wstringop-overread");
+#endif
+
 /* Find the first occurrence of C in S.  */
 void *
 RAWMEMCHR (const void *s, int c)
 {
-  DIAG_PUSH_NEEDS_COMMENT;
-#if __GNUC_PREREQ (7, 0)
-  /* GCC 8 warns about the size passed to memchr being larger than
-     PTRDIFF_MAX; the use of SIZE_MAX is deliberate here.  */
-  DIAG_IGNORE_NEEDS_COMMENT (8, "-Wstringop-overflow=");
-#endif
-#if __GNUC_PREREQ (11, 0)
-  /* Likewise GCC 11, with a different warning option.  */
-  DIAG_IGNORE_NEEDS_COMMENT (11, "-Wstringop-overread");
-#endif
   if (c != '\0')
     return memchr (s, c, (size_t)-1);
-  DIAG_POP_NEEDS_COMMENT;
   return (char *)s + strlen (s);
 }
 libc_hidden_def (__rawmemchr)
 weak_alias (__rawmemchr, rawmemchr)
+
+DIAG_POP_NEEDS_COMMENT;