[v2,2/2] ada: add 128bit operation to MIPS N32 and N64

Message ID 20210218023844.6929-2-yunqiang.su@cipunited.com
State Superseded
Headers show
Series
  • [v2,1/2] MIPS: unaligned load: use SImode for SUBREG if OK (PR98996)
Related show

Commit Message

YunQiang Su Feb. 18, 2021, 2:38 a.m.
For MIPS N64 and N32:
  add GNATRTL_128BIT_PAIRS to LIBGNAT_TARGET_PAIRS
  add GNATRTL_128BIT_OBJS to EXTRA_GNATRTL_NONTASKING_OBJS

gcc/ada/ChangeLog:
	PR ada/98996
	* Makefile.rtl (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS)
	<mips*-*-linux*>: add 128Bit operation file to MIPS N64 and N32.
---
 gcc/ada/ChangeLog    |  6 ++++++
 gcc/ada/Makefile.rtl | 12 ++++++++++++
 2 files changed, 18 insertions(+)

-- 
2.20.1

Comments

Arnaud Charlet Feb. 18, 2021, 7:29 a.m. | #1
> For MIPS N64 and N32:

>   add GNATRTL_128BIT_PAIRS to LIBGNAT_TARGET_PAIRS

>   add GNATRTL_128BIT_OBJS to EXTRA_GNATRTL_NONTASKING_OBJS

> 

> gcc/ada/ChangeLog:

> 	PR ada/98996

> 	* Makefile.rtl (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS)

> 	<mips*-*-linux*>: add 128Bit operation file to MIPS N64 and N32.


Note that the ChangeLog is generated automatically these days.

The change is OK, thanks.

> ---

>  gcc/ada/ChangeLog    |  6 ++++++

>  gcc/ada/Makefile.rtl | 12 ++++++++++++

>  2 files changed, 18 insertions(+)

> 

> diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog

> index 52faefaa2ae..3565a32c5ac 100644

> --- a/gcc/ada/ChangeLog

> +++ b/gcc/ada/ChangeLog

> @@ -1,3 +1,9 @@

> +2021-02-18  YunQiang Su  <yunqiang.su@cipunited.com>

> +

> +	PR ada/98996

> +	* Makefile.rtl (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS)

> +	<mips*-*-linux*>: add 128Bit operation file to MIPS N64 and N32.

> +

>  2021-02-12  Arnaud Charlet  <charlet@adacore.com>

>  

>  	* repinfo.ads, repinfo.adb (*SO_Ref*): Restore.

> diff --git a/gcc/ada/Makefile.rtl b/gcc/ada/Makefile.rtl

> index 35faf13ea46..d86eb8acbf3 100644

> --- a/gcc/ada/Makefile.rtl

> +++ b/gcc/ada/Makefile.rtl

> @@ -2311,6 +2311,18 @@ ifeq ($(strip $(filter-out mips% linux%,$(target_cpu) $(target_os))),)

>    s-tpopsp.adb<libgnarl/s-tpopsp__posix-foreign.adb \

>    system.ads<libgnat/system-linux-mips.ads

>  

> +  ifeq ($(strip $(filter-out mips64% mipsisa64%,$(target_cpu))),)

> +    ifneq ($(strip $(MULTISUBDIR)),/32)

> +      LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)

> +      EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)

> +    endif

> +  else

> +    ifeq ($(strip $(filter-out /64 /n32,$(MULTISUBDIR))),)

> +      LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)

> +      EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)

> +    endif

> +  endif

> +

>    TOOLS_TARGET_PAIRS = indepsw.adb<indepsw-gnu.adb

>  

>    EXTRA_GNATRTL_TASKING_OBJS=s-linux.o

> -- 

> 2.20.1
YunQiang Su Feb. 18, 2021, 8:46 a.m. | #2
Arnaud Charlet <charlet@adacore.com> 于2021年2月18日周四 下午3:38写道:
>

> > For MIPS N64 and N32:

> >   add GNATRTL_128BIT_PAIRS to LIBGNAT_TARGET_PAIRS

> >   add GNATRTL_128BIT_OBJS to EXTRA_GNATRTL_NONTASKING_OBJS

> >

> > gcc/ada/ChangeLog:

> >       PR ada/98996

> >       * Makefile.rtl (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS)

> >       <mips*-*-linux*>: add 128Bit operation file to MIPS N64 and N32.

>

> Note that the ChangeLog is generated automatically these days.


Thank you for your instruction. I noticed the contrib/mklog.py.
It generate the template of ChangeLog.
Should I resend a new version of patch?

>

> The change is OK, thanks.

>

> > ---

> >  gcc/ada/ChangeLog    |  6 ++++++

> >  gcc/ada/Makefile.rtl | 12 ++++++++++++

> >  2 files changed, 18 insertions(+)

> >

> > diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog

> > index 52faefaa2ae..3565a32c5ac 100644

> > --- a/gcc/ada/ChangeLog

> > +++ b/gcc/ada/ChangeLog

> > @@ -1,3 +1,9 @@

> > +2021-02-18  YunQiang Su  <yunqiang.su@cipunited.com>

> > +

> > +     PR ada/98996

> > +     * Makefile.rtl (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS)

> > +     <mips*-*-linux*>: add 128Bit operation file to MIPS N64 and N32.

> > +

> >  2021-02-12  Arnaud Charlet  <charlet@adacore.com>

> >

> >       * repinfo.ads, repinfo.adb (*SO_Ref*): Restore.

> > diff --git a/gcc/ada/Makefile.rtl b/gcc/ada/Makefile.rtl

> > index 35faf13ea46..d86eb8acbf3 100644

> > --- a/gcc/ada/Makefile.rtl

> > +++ b/gcc/ada/Makefile.rtl

> > @@ -2311,6 +2311,18 @@ ifeq ($(strip $(filter-out mips% linux%,$(target_cpu) $(target_os))),)

> >    s-tpopsp.adb<libgnarl/s-tpopsp__posix-foreign.adb \

> >    system.ads<libgnat/system-linux-mips.ads

> >

> > +  ifeq ($(strip $(filter-out mips64% mipsisa64%,$(target_cpu))),)

> > +    ifneq ($(strip $(MULTISUBDIR)),/32)

> > +      LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)

> > +      EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)

> > +    endif

> > +  else

> > +    ifeq ($(strip $(filter-out /64 /n32,$(MULTISUBDIR))),)

> > +      LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)

> > +      EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)

> > +    endif

> > +  endif

> > +

> >    TOOLS_TARGET_PAIRS = indepsw.adb<indepsw-gnu.adb

> >

> >    EXTRA_GNATRTL_TASKING_OBJS=s-linux.o

> > --

> > 2.20.1
Arnaud Charlet Feb. 18, 2021, 8:51 a.m. | #3
> > > For MIPS N64 and N32:

> > >   add GNATRTL_128BIT_PAIRS to LIBGNAT_TARGET_PAIRS

> > >   add GNATRTL_128BIT_OBJS to EXTRA_GNATRTL_NONTASKING_OBJS

> > >

> > > gcc/ada/ChangeLog:

> > >       PR ada/98996

> > >       * Makefile.rtl (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS)

> > >       <mips*-*-linux*>: add 128Bit operation file to MIPS N64 and N32.

> >

> > Note that the ChangeLog is generated automatically these days.

> 

> Thank you for your instruction. I noticed the contrib/mklog.py.

> It generate the template of ChangeLog.

> Should I resend a new version of patch?


No need to as far as I'm concerned, you can go ahead and commit your change.
There are commit hooks checking the proper format of the commit log these
days anyway.

Arno
YunQiang Su Feb. 20, 2021, 8:24 a.m. | #4
Arnaud Charlet <charlet@adacore.com> 于2021年2月18日周四 下午4:51写道:
>

> > > > For MIPS N64 and N32:

> > > >   add GNATRTL_128BIT_PAIRS to LIBGNAT_TARGET_PAIRS

> > > >   add GNATRTL_128BIT_OBJS to EXTRA_GNATRTL_NONTASKING_OBJS

> > > >

> > > > gcc/ada/ChangeLog:

> > > >       PR ada/98996

> > > >       * Makefile.rtl (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS)

> > > >       <mips*-*-linux*>: add 128Bit operation file to MIPS N64 and N32.

> > >

> > > Note that the ChangeLog is generated automatically these days.

> >

> > Thank you for your instruction. I noticed the contrib/mklog.py.

> > It generate the template of ChangeLog.

> > Should I resend a new version of patch?

>

> No need to as far as I'm concerned, you can go ahead and commit your change.


I have no permission to do so.

> There are commit hooks checking the proper format of the commit log these

> days anyway.

>

> Arno
YunQiang Su Feb. 22, 2021, 12:18 p.m. | #5
Arnaud Charlet <charlet@adacore.com> 于2021年2月18日周四 下午3:38写道:
>

> > For MIPS N64 and N32:

> >   add GNATRTL_128BIT_PAIRS to LIBGNAT_TARGET_PAIRS

> >   add GNATRTL_128BIT_OBJS to EXTRA_GNATRTL_NONTASKING_OBJS

> >

> > gcc/ada/ChangeLog:

> >       PR ada/98996

> >       * Makefile.rtl (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS)

> >       <mips*-*-linux*>: add 128Bit operation file to MIPS N64 and N32.

>

> Note that the ChangeLog is generated automatically these days.

>

> The change is OK, thanks.


can you help me to commit this patchset?

>

> > ---

> >  gcc/ada/ChangeLog    |  6 ++++++

> >  gcc/ada/Makefile.rtl | 12 ++++++++++++

> >  2 files changed, 18 insertions(+)

> >

> > diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog

> > index 52faefaa2ae..3565a32c5ac 100644

> > --- a/gcc/ada/ChangeLog

> > +++ b/gcc/ada/ChangeLog

> > @@ -1,3 +1,9 @@

> > +2021-02-18  YunQiang Su  <yunqiang.su@cipunited.com>

> > +

> > +     PR ada/98996

> > +     * Makefile.rtl (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS)

> > +     <mips*-*-linux*>: add 128Bit operation file to MIPS N64 and N32.

> > +

> >  2021-02-12  Arnaud Charlet  <charlet@adacore.com>

> >

> >       * repinfo.ads, repinfo.adb (*SO_Ref*): Restore.

> > diff --git a/gcc/ada/Makefile.rtl b/gcc/ada/Makefile.rtl

> > index 35faf13ea46..d86eb8acbf3 100644

> > --- a/gcc/ada/Makefile.rtl

> > +++ b/gcc/ada/Makefile.rtl

> > @@ -2311,6 +2311,18 @@ ifeq ($(strip $(filter-out mips% linux%,$(target_cpu) $(target_os))),)

> >    s-tpopsp.adb<libgnarl/s-tpopsp__posix-foreign.adb \

> >    system.ads<libgnat/system-linux-mips.ads

> >

> > +  ifeq ($(strip $(filter-out mips64% mipsisa64%,$(target_cpu))),)

> > +    ifneq ($(strip $(MULTISUBDIR)),/32)

> > +      LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)

> > +      EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)

> > +    endif

> > +  else

> > +    ifeq ($(strip $(filter-out /64 /n32,$(MULTISUBDIR))),)

> > +      LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)

> > +      EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)

> > +    endif

> > +  endif

> > +

> >    TOOLS_TARGET_PAIRS = indepsw.adb<indepsw-gnu.adb

> >

> >    EXTRA_GNATRTL_TASKING_OBJS=s-linux.o

> > --

> > 2.20.1

Patch

diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog
index 52faefaa2ae..3565a32c5ac 100644
--- a/gcc/ada/ChangeLog
+++ b/gcc/ada/ChangeLog
@@ -1,3 +1,9 @@ 
+2021-02-18  YunQiang Su  <yunqiang.su@cipunited.com>
+
+	PR ada/98996
+	* Makefile.rtl (LIBGNAT_TARGET_PAIRS, EXTRA_GNATRTL_NONTASKING_OBJS)
+	<mips*-*-linux*>: add 128Bit operation file to MIPS N64 and N32.
+
 2021-02-12  Arnaud Charlet  <charlet@adacore.com>
 
 	* repinfo.ads, repinfo.adb (*SO_Ref*): Restore.
diff --git a/gcc/ada/Makefile.rtl b/gcc/ada/Makefile.rtl
index 35faf13ea46..d86eb8acbf3 100644
--- a/gcc/ada/Makefile.rtl
+++ b/gcc/ada/Makefile.rtl
@@ -2311,6 +2311,18 @@  ifeq ($(strip $(filter-out mips% linux%,$(target_cpu) $(target_os))),)
   s-tpopsp.adb<libgnarl/s-tpopsp__posix-foreign.adb \
   system.ads<libgnat/system-linux-mips.ads
 
+  ifeq ($(strip $(filter-out mips64% mipsisa64%,$(target_cpu))),)
+    ifneq ($(strip $(MULTISUBDIR)),/32)
+      LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)
+      EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)
+    endif
+  else
+    ifeq ($(strip $(filter-out /64 /n32,$(MULTISUBDIR))),)
+      LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)
+      EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)
+    endif
+  endif
+
   TOOLS_TARGET_PAIRS = indepsw.adb<indepsw-gnu.adb
 
   EXTRA_GNATRTL_TASKING_OBJS=s-linux.o