| Message ID | 20210217021427.172DC203B5@pchp3.se.axis.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
On Feb 17 03:14, Hans-Peter Nilsson via Newlib wrote: > Ok to commit? Yes. Thanks, Corinna > Noticed by build-scripts diffing warnings at build-time, > that noticed a regression with my "import" of yesterday's > newlib, compared to the previous newlib from May 2019, > i.e. before the "Reimplement aligned_alloc" rewrite. > > Without this, for a bare-iron/simulator target such as cris-elf, > you'll see, at newlib build time: > > /x/gccobj/./gcc/xgcc -B/x/gccobj/./gcc/ <many options elided> -c -o lib_a-aligned_alloc.o \ > `test -f 'aligned_alloc.c' || echo '/y/newlib/libc/stdlib/'`aligned_alloc.c > /y/newlib/libc/stdlib/aligned_alloc.c: In function 'aligned_alloc': > /y/newlib/libc/stdlib/aligned_alloc.c:35:10: warning: implicit declaration of function \ > '_memalign_r' [-Wimplicit-function-declaration] > 35 | return _memalign_r (_REENT, align, size); > | ^~~~~~~~~~~ > --- > newlib/libc/stdlib/aligned_alloc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/newlib/libc/stdlib/aligned_alloc.c b/newlib/libc/stdlib/aligned_alloc.c > index feb22c24b947..06b3883cfb00 100644 > --- a/newlib/libc/stdlib/aligned_alloc.c > +++ b/newlib/libc/stdlib/aligned_alloc.c > @@ -28,6 +28,7 @@ > > #include <reent.h> > #include <stdlib.h> > +#include <malloc.h> > > void * > aligned_alloc (size_t align, size_t size) > -- > 2.11.0 > > brgds, H-P
diff --git a/newlib/libc/stdlib/aligned_alloc.c b/newlib/libc/stdlib/aligned_alloc.c index feb22c24b947..06b3883cfb00 100644 --- a/newlib/libc/stdlib/aligned_alloc.c +++ b/newlib/libc/stdlib/aligned_alloc.c @@ -28,6 +28,7 @@ #include <reent.h> #include <stdlib.h> +#include <malloc.h> void * aligned_alloc (size_t align, size_t size)
Ok to commit? Noticed by build-scripts diffing warnings at build-time, that noticed a regression with my "import" of yesterday's newlib, compared to the previous newlib from May 2019, i.e. before the "Reimplement aligned_alloc" rewrite. Without this, for a bare-iron/simulator target such as cris-elf, you'll see, at newlib build time: /x/gccobj/./gcc/xgcc -B/x/gccobj/./gcc/ <many options elided> -c -o lib_a-aligned_alloc.o \ `test -f 'aligned_alloc.c' || echo '/y/newlib/libc/stdlib/'`aligned_alloc.c /y/newlib/libc/stdlib/aligned_alloc.c: In function 'aligned_alloc': /y/newlib/libc/stdlib/aligned_alloc.c:35:10: warning: implicit declaration of function \ '_memalign_r' [-Wimplicit-function-declaration] 35 | return _memalign_r (_REENT, align, size); | ^~~~~~~~~~~ --- newlib/libc/stdlib/aligned_alloc.c | 1 + 1 file changed, 1 insertion(+) -- 2.11.0 brgds, H-P