ATTRIBUTE_HIDDEN for libbfd.h

Message ID 20180518034729.GP23663@bubble.grove.modra.org
State New
Headers show
Series
  • ATTRIBUTE_HIDDEN for libbfd.h
Related show

Commit Message

Alan Modra May 18, 2018, 3:47 a.m.
* libbfd-in.h (ATTRIBUTE_HIDDEN): Define and use throughout.
	* configure.ac (HAVE_HIDDEN): Check compiler support for hidden
	visibility.
	* libbfd.h: Regenerate.
	* configure: Regenerate.
	* config.in: Regenerate.


-- 
Alan Modra
Australia Development Lab, IBM

Comments

Tom Tromey May 24, 2018, 2:19 p.m. | #1
>>>>> "Alan" == Alan Modra <amodra@gmail.com> writes:


Alan> 	* libbfd-in.h (ATTRIBUTE_HIDDEN): Define and use throughout.
Alan> 	* configure.ac (HAVE_HIDDEN): Check compiler support for hidden
Alan> 	visibility.
Alan> 	* libbfd.h: Regenerate.
Alan> 	* configure: Regenerate.
Alan> 	* config.in: Regenerate.

I noticed while testing patches on the gdb buildbot that this patch
seems to have broken the mingw build.

../../binutils-gdb/bfd/archive.c:187:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]


I can reproduce this on Fedora by installing the mingw toolchain and
then doing a build like:

../binutils-gdb/configure  --disable-{binutils,gas,gold,gprof,ld,sim} --host=i686-w64-mingw32 --target=i686-w64-mingw32 --enable-targets=all

Tom
Alan Modra May 25, 2018, 12:18 a.m. | #2
On Thu, May 24, 2018 at 08:19:28AM -0600, Tom Tromey wrote:
> >>>>> "Alan" == Alan Modra <amodra@gmail.com> writes:

> 

> Alan> 	* libbfd-in.h (ATTRIBUTE_HIDDEN): Define and use throughout.

> Alan> 	* configure.ac (HAVE_HIDDEN): Check compiler support for hidden

> Alan> 	visibility.

> Alan> 	* libbfd.h: Regenerate.

> Alan> 	* configure: Regenerate.

> Alan> 	* config.in: Regenerate.

> 

> I noticed while testing patches on the gdb buildbot that this patch

> seems to have broken the mingw build.

> 

> ../../binutils-gdb/bfd/archive.c:187:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]

> 

> 

> I can reproduce this on Fedora by installing the mingw toolchain and

> then doing a build like:

> 

> ../binutils-gdb/configure  --disable-{binutils,gas,gold,gprof,ld,sim} --host=i686-w64-mingw32 --target=i686-w64-mingw32 --enable-targets=all


Thanks for the report.  I can reproduce the problem on Ubuntu too.
My configure test is broken.

configure:14046: checking compiler support for hidden visibility
configure:14064: x86_64-w64-mingw32-gcc -c -g -O2 -D__USE_MINGW_ACCESS  conftest.c >&5
conftest.c:83:1: warning: visibility attribute not supported in this configuration; ignored [-Wattributes]
 }
 ^
configure:14064: $? = 0
configure:14071: result: yes

-- 
Alan Modra
Australia Development Lab, IBM
Alan Modra May 25, 2018, 6:23 a.m. | #3
On Fri, May 25, 2018 at 09:48:35AM +0930, Alan Modra wrote:
> Thanks for the report.  I can reproduce the problem on Ubuntu too.

> My configure test is broken.

> 

> configure:14046: checking compiler support for hidden visibility

> configure:14064: x86_64-w64-mingw32-gcc -c -g -O2 -D__USE_MINGW_ACCESS  conftest.c >&5

> conftest.c:83:1: warning: visibility attribute not supported in this configuration; ignored [-Wattributes]

>  }

>  ^

> configure:14064: $? = 0

> configure:14071: result: yes


I'm committing the following.

Warnings from configure tests aren't usually checked.  gcc's
"visibility attribute not supported in this configuration" warning is
enabled by default so we don't need to add any warning flag except
-Werror.

	* configure.ac (bfd_cv_hidden): Run test with -Werror in CFLAGS.
	* configure: Regenerate.

diff --git a/bfd/configure.ac b/bfd/configure.ac
index b320828fbb..bb5c1687b4 100644
--- a/bfd/configure.ac
+++ b/bfd/configure.ac
@@ -256,12 +256,15 @@ AC_CHECK_DECLS(strnlen)
 # This is used only by compress.c.
 AM_ZLIB
 
+save_CFLAGS="$CFLAGS"
+CFLAGS="$CFLAGS -Werror"
 AC_CACHE_CHECK([compiler support for hidden visibility], bfd_cv_hidden,
 [AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
 const char hw[] __attribute__ ((__visibility__ ("hidden"))) = "Hello, World\n";
 extern void print (const char *) __attribute__ ((__visibility__ ("hidden")));]],
 	[[print (hw);]])],
   [bfd_cv_hidden=yes], [bfd_cv_hidden=no])])
+CFLAGS="$save_CFLAGS"
 if test $bfd_cv_hidden = yes; then
   AC_DEFINE(HAVE_HIDDEN, 1,
 	    [Define if your compiler supports hidden visibility.])

-- 
Alan Modra
Australia Development Lab, IBM
Tom Tromey May 25, 2018, 1:16 p.m. | #4
>>>>> "Alan" == Alan Modra <amodra@gmail.com> writes:


Alan> I'm committing the following.

Thank you.

Tom
Andreas Schwab May 31, 2018, 9:13 p.m. | #5
Breaks --enable-shared build:

/bin/sh ./libtool --tag=CC   --mode=link gcc -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -Wwrite-strings  -O2 -g  -static-libstdc++ -static-libgcc  -o as-new app.o as.o atof-generic.o compress-debug.o cond.o depend.o dwarf2dbg.o dw2gencfi.o ecoff.o ehopt.o expr.o flonum-copy.o flonum-konst.o flonum-mult.o frags.o hash.o input-file.o input-scrub.o listing.o literal.o macro.o messages.o output-file.o read.o remap.o sb.o stabs.o subsegs.o symbols.o write.o tc-i386.o obj-elf.o atof-ieee.o  ../opcodes/libopcodes.la ../bfd/libbfd.la ../libiberty/libiberty.a   -ldl 
libtool: link: gcc -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -Wwrite-strings -O2 -g -static-libstdc++ -static-libgcc -o .libs/as-new app.o as.o atof-generic.o compress-debug.o cond.o depend.o dwarf2dbg.o dw2gencfi.o ecoff.o ehopt.o expr.o flonum-copy.o flonum-konst.o flonum-mult.o frags.o hash.o input-file.o input-scrub.o listing.o literal.o macro.o messages.o output-file.o read.o remap.o sb.o stabs.o subsegs.o symbols.o write.o tc-i386.o obj-elf.o atof-ieee.o  ../opcodes/.libs/libopcodes.so -L/home/andreas/src/binutils/test/opcodes/../libiberty/pic ../bfd/.libs/libbfd.so -L/home/andreas/src/binutils/test/bfd/../libiberty/pic -liberty -lz ../libiberty/libiberty.a -ldl -Wl,-rpath -Wl,/usr/lib64
../opcodes/.libs/libopcodes.so: undefined reference to `_bfd_error_handler'

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."
Alan Modra June 1, 2018, 3:50 a.m. | #6
On Thu, May 31, 2018 at 11:13:00PM +0200, Andreas Schwab wrote:
> Breaks --enable-shared build:


bfd/
	* bfd.c (_bfd_error_handler): Arrange for this function to be
	declared in bfd-in2.h.
	* libbfd-in.h (_bfd_error_handler): Don't declare.
	* libbfd.h: Regenerate.
	* bfd-in2.h: Regenerate.
opcodes/
	* sysdep.h (_bfd_error_handler): Don't declare.
	* msp430-decode.opc: Include bfd.h.  Don't include ansidecl.h here.
	* rl78-decode.opc: Likewise.
	* msp430-decode.c: Regenerate.
	* rl78-decode.c: Regenerate.

diff --git a/bfd/bfd.c b/bfd/bfd.c
index 3bf56a6219..09c817df4f 100644
--- a/bfd/bfd.c
+++ b/bfd/bfd.c
@@ -1087,14 +1087,6 @@ _bfd_doprnt_scan (const char *format, union _bfd_doprnt_args *args)
   return arg_count;
 }
 
-/* This is the default routine to handle BFD error messages.
-   Like fprintf (stderr, ...), but also handles some extra format specifiers.
-
-   %pA section name from section.  For group components, prints group name too.
-   %pB file name from bfd.  For archive components, prints archive too.
-
-   Beware: Only supports a maximum of 9 format arguments.  */
-
 static void
 error_handler_internal (const char *fmt, va_list ap)
 {
@@ -1156,6 +1148,26 @@ error_handler_internal (const char *fmt, va_list ap)
 
 static bfd_error_handler_type _bfd_error_internal = error_handler_internal;
 
+/*
+FUNCTION
+	_bfd_error_handler
+
+SYNOPSIS
+	void _bfd_error_handler (const char *fmt, ...) ATTRIBUTE_PRINTF_1;
+
+DESCRIPTION
+	This is the default routine to handle BFD error messages.
+	Like fprintf (stderr, ...), but also handles some extra format
+	specifiers.
+
+	%pA section name from section.  For group components, prints
+	group name too.
+	%pB file name from bfd.  For archive components, prints
+	archive too.
+
+	Beware: Only supports a maximum of 9 format arguments.
+*/
+
 void
 _bfd_error_handler (const char *fmt, ...)
 {
diff --git a/bfd/libbfd-in.h b/bfd/libbfd-in.h
index 9796f2d67e..3c55adf075 100644
--- a/bfd/libbfd-in.h
+++ b/bfd/libbfd-in.h
@@ -123,9 +123,6 @@ extern void *bfd_realloc2
 extern void *bfd_zmalloc2
   (bfd_size_type, bfd_size_type) ATTRIBUTE_HIDDEN;
 
-extern void _bfd_error_handler (const char *s, ...)
-  ATTRIBUTE_PRINTF_1 ATTRIBUTE_HIDDEN;
-
 /* These routines allocate and free things on the BFD's objalloc.  */
 
 extern void *bfd_alloc2
diff --git a/opcodes/msp430-decode.opc b/opcodes/msp430-decode.opc
index 8cdae5afae..71ff762d91 100644
--- a/opcodes/msp430-decode.opc
+++ b/opcodes/msp430-decode.opc
@@ -24,7 +24,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include "ansidecl.h"
+#include "bfd.h"
 #include "opintl.h"
 #include "opcode/msp430-decode.h"
 
diff --git a/opcodes/rl78-decode.opc b/opcodes/rl78-decode.opc
index 49e9e69d95..444ced2764 100644
--- a/opcodes/rl78-decode.opc
+++ b/opcodes/rl78-decode.opc
@@ -24,7 +24,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include "ansidecl.h"
+#include "bfd.h"
 #include "opintl.h"
 #include "opcode/rl78.h"
 
diff --git a/opcodes/sysdep.h b/opcodes/sysdep.h
index 20f5828082..8e5e6af1ae 100644
--- a/opcodes/sysdep.h
+++ b/opcodes/sysdep.h
@@ -57,7 +57,6 @@ extern char *stpcpy (char *__dest, const char *__src);
 #endif
 
 #define opcodes_error_handler _bfd_error_handler
-extern void _bfd_error_handler (const char *, ...) ATTRIBUTE_PRINTF_1;
 
 /* Use sigsetjmp/siglongjmp without saving the signal mask if possible.
    It is faster than setjmp/longjmp on systems where the signal mask is

-- 
Alan Modra
Australia Development Lab, IBM

Patch

diff --git a/bfd/configure.ac b/bfd/configure.ac
index 6c1b5febd5..12974691ad 100644
--- a/bfd/configure.ac
+++ b/bfd/configure.ac
@@ -256,6 +256,17 @@  AC_CHECK_DECLS(strnlen)
 # This is used only by compress.c.
 AM_ZLIB
 
+AC_CACHE_CHECK([compiler support for hidden visibility], bfd_cv_hidden,
+[AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
+const char hw[] __attribute__ ((__visibility__ ("hidden"))) = "Hello, World\n";
+extern void print (const char *) __attribute__ ((__visibility__ ("hidden")));]],
+	[[print (hw);]])],
+  [bfd_cv_hidden=yes], [bfd_cv_hidden=no])])
+if test $bfd_cv_hidden = yes; then
+  AC_DEFINE(HAVE_HIDDEN, 1,
+	    [Define if your compiler supports hidden visibility.])
+fi
+
 # Check if linker supports --as-needed and --no-as-needed options
 AC_CACHE_CHECK(linker --as-needed support, bfd_cv_ld_as_needed,
 	[bfd_cv_ld_as_needed=no
diff --git a/bfd/libbfd-in.h b/bfd/libbfd-in.h
index a763f97faa..bb3cf48f70 100644
--- a/bfd/libbfd-in.h
+++ b/bfd/libbfd-in.h
@@ -25,6 +25,14 @@ 
 #ifndef _LIBBFD_H
 #define _LIBBFD_H 1
 
+#ifndef ATTRIBUTE_HIDDEN
+#if HAVE_HIDDEN
+#define ATTRIBUTE_HIDDEN __attribute__ ((__visibility__ ("hidden")))
+#else
+#define ATTRIBUTE_HIDDEN
+#endif
+#endif
+
 #include "hashtab.h"
 
 #ifdef __cplusplus
@@ -57,7 +65,7 @@  struct section_hash_entry
 };
 
 /* Unique section id.  */
-extern unsigned int _bfd_section_id;
+extern unsigned int _bfd_section_id ATTRIBUTE_HIDDEN;
 
 /* tdata for an archive.  For an input archive, cache
    needs to be free()'d.  For an output archive, symdefs do.  */
@@ -101,51 +109,52 @@  struct areltdata
 #define arelt_size(bfd) (((struct areltdata *)((bfd)->arelt_data))->parsed_size)
 
 extern void *bfd_malloc
-  (bfd_size_type);
+  (bfd_size_type) ATTRIBUTE_HIDDEN;
 extern void *bfd_realloc
-  (void *, bfd_size_type);
+  (void *, bfd_size_type) ATTRIBUTE_HIDDEN;
 extern void *bfd_realloc_or_free
-  (void *, bfd_size_type);
+  (void *, bfd_size_type) ATTRIBUTE_HIDDEN;
 extern void *bfd_zmalloc
-  (bfd_size_type);
+  (bfd_size_type) ATTRIBUTE_HIDDEN;
 extern void *bfd_malloc2
-  (bfd_size_type, bfd_size_type);
+  (bfd_size_type, bfd_size_type) ATTRIBUTE_HIDDEN;
 extern void *bfd_realloc2
-  (void *, bfd_size_type, bfd_size_type);
+  (void *, bfd_size_type, bfd_size_type) ATTRIBUTE_HIDDEN;
 extern void *bfd_zmalloc2
-  (bfd_size_type, bfd_size_type);
+  (bfd_size_type, bfd_size_type) ATTRIBUTE_HIDDEN;
 
-extern void _bfd_error_handler (const char *s, ...) ATTRIBUTE_PRINTF_1;
+extern void _bfd_error_handler (const char *s, ...)
+  ATTRIBUTE_PRINTF_1 ATTRIBUTE_HIDDEN;
 
 /* These routines allocate and free things on the BFD's objalloc.  */
 
 extern void *bfd_alloc2
-  (bfd *, bfd_size_type, bfd_size_type);
+  (bfd *, bfd_size_type, bfd_size_type) ATTRIBUTE_HIDDEN;
 extern void *bfd_zalloc2
-  (bfd *, bfd_size_type, bfd_size_type);
+  (bfd *, bfd_size_type, bfd_size_type) ATTRIBUTE_HIDDEN;
 extern void bfd_release
-  (bfd *, void *);
-
-bfd * _bfd_create_empty_archive_element_shell
-  (bfd *);
-bfd * _bfd_look_for_bfd_in_cache
-  (bfd *, file_ptr);
-bfd_boolean _bfd_add_bfd_to_archive_cache
-  (bfd *, file_ptr, bfd *);
-bfd_boolean _bfd_generic_mkarchive
-  (bfd *);
-char *_bfd_append_relative_path
-  (bfd *, char *);
-const bfd_target *bfd_generic_archive_p
-  (bfd *);
-bfd_boolean bfd_slurp_armap
-  (bfd *);
+  (bfd *, void *) ATTRIBUTE_HIDDEN;
+
+extern bfd * _bfd_create_empty_archive_element_shell
+  (bfd *) ATTRIBUTE_HIDDEN;
+extern bfd * _bfd_look_for_bfd_in_cache
+  (bfd *, file_ptr) ATTRIBUTE_HIDDEN;
+extern bfd_boolean _bfd_add_bfd_to_archive_cache
+  (bfd *, file_ptr, bfd *) ATTRIBUTE_HIDDEN;
+extern bfd_boolean _bfd_generic_mkarchive
+  (bfd *) ATTRIBUTE_HIDDEN;
+extern char *_bfd_append_relative_path
+  (bfd *, char *) ATTRIBUTE_HIDDEN;
+extern const bfd_target *bfd_generic_archive_p
+  (bfd *) ATTRIBUTE_HIDDEN;
+extern bfd_boolean bfd_slurp_armap
+  (bfd *) ATTRIBUTE_HIDDEN;
 #define bfd_slurp_bsd_armap bfd_slurp_armap
 #define bfd_slurp_coff_armap bfd_slurp_armap
-bfd_boolean _bfd_archive_64_bit_slurp_armap
-  (bfd *);
-bfd_boolean _bfd_archive_64_bit_write_armap
-  (bfd *, unsigned int, struct orl *, unsigned int, int);
+extern bfd_boolean _bfd_archive_64_bit_slurp_armap
+  (bfd *) ATTRIBUTE_HIDDEN;
+extern bfd_boolean _bfd_archive_64_bit_write_armap
+  (bfd *, unsigned int, struct orl *, unsigned int, int) ATTRIBUTE_HIDDEN;
 #define _bfd_archive_64_bit_slurp_extended_name_table \
   _bfd_slurp_extended_name_table
 #define _bfd_archive_64_bit_construct_extended_name_table \
@@ -164,101 +173,101 @@  bfd_boolean _bfd_archive_64_bit_write_armap
   bfd_generic_stat_arch_elt
 #define _bfd_archive_64_bit_update_armap_timestamp _bfd_bool_bfd_true
 
-bfd_boolean _bfd_slurp_extended_name_table
-  (bfd *);
+extern bfd_boolean _bfd_slurp_extended_name_table
+  (bfd *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_construct_extended_name_table
-  (bfd *, bfd_boolean, char **, bfd_size_type *);
-bfd_boolean _bfd_write_archive_contents
-  (bfd *);
-bfd_boolean _bfd_compute_and_write_armap
-  (bfd *, unsigned int);
-bfd *_bfd_get_elt_at_filepos
-  (bfd *, file_ptr);
+  (bfd *, bfd_boolean, char **, bfd_size_type *) ATTRIBUTE_HIDDEN;
+extern bfd_boolean _bfd_write_archive_contents
+  (bfd *) ATTRIBUTE_HIDDEN;
+extern bfd_boolean _bfd_compute_and_write_armap
+  (bfd *, unsigned int) ATTRIBUTE_HIDDEN;
+extern bfd *_bfd_get_elt_at_filepos
+  (bfd *, file_ptr) ATTRIBUTE_HIDDEN;
 extern bfd *_bfd_generic_get_elt_at_index
-  (bfd *, symindex);
-bfd * _bfd_new_bfd
-  (void);
-bfd_boolean _bfd_free_cached_info
-  (bfd *);
+  (bfd *, symindex) ATTRIBUTE_HIDDEN;
+extern bfd * _bfd_new_bfd
+  (void) ATTRIBUTE_HIDDEN;
+extern bfd_boolean _bfd_free_cached_info
+  (bfd *) ATTRIBUTE_HIDDEN;
 
 extern bfd_boolean _bfd_bool_bfd_false
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_bool_bfd_asymbol_false
-  (bfd *, asymbol *);
+  (bfd *, asymbol *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_bool_bfd_false_error
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_bool_bfd_link_false_error
-  (bfd *, struct bfd_link_info *);
+  (bfd *, struct bfd_link_info *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_bool_bfd_true
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_bool_bfd_link_true
-  (bfd *, struct bfd_link_info *);
+  (bfd *, struct bfd_link_info *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_bool_bfd_bfd_true
-  (bfd *, bfd *);
+  (bfd *, bfd *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_bool_bfd_uint_true
-  (bfd *, unsigned int);
+  (bfd *, unsigned int) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_bool_bfd_asection_bfd_asection_true
-  (bfd *, asection *, bfd *, asection *);
+  (bfd *, asection *, bfd *, asection *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_bool_bfd_asymbol_bfd_asymbol_true
-  (bfd *, asymbol *, bfd *, asymbol *);
+  (bfd *, asymbol *, bfd *, asymbol *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_bool_bfd_ptr_true
-  (bfd *, void *);
+  (bfd *, void *) ATTRIBUTE_HIDDEN;
 extern void *_bfd_ptr_bfd_null_error
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 extern int _bfd_int_bfd_0
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 extern unsigned int _bfd_uint_bfd_0
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 extern long _bfd_long_bfd_0
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 extern long _bfd_long_bfd_n1_error
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 extern void _bfd_void_bfd
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 extern void _bfd_void_bfd_link
-  (bfd *, struct bfd_link_info *);
+  (bfd *, struct bfd_link_info *) ATTRIBUTE_HIDDEN;
 extern void _bfd_void_bfd_asection
-  (bfd *, asection *);
+  (bfd *, asection *) ATTRIBUTE_HIDDEN;
 
-bfd *_bfd_new_bfd_contained_in
-  (bfd *);
-const bfd_target *_bfd_dummy_target
-  (bfd *);
+extern bfd *_bfd_new_bfd_contained_in
+  (bfd *) ATTRIBUTE_HIDDEN;
+extern const bfd_target *_bfd_dummy_target
+  (bfd *) ATTRIBUTE_HIDDEN;
 
-void bfd_dont_truncate_arname
-  (bfd *, const char *, char *);
-void bfd_bsd_truncate_arname
-  (bfd *, const char *, char *);
-void bfd_gnu_truncate_arname
-  (bfd *, const char *, char *);
+extern void bfd_dont_truncate_arname
+  (bfd *, const char *, char *) ATTRIBUTE_HIDDEN;
+extern void bfd_bsd_truncate_arname
+  (bfd *, const char *, char *) ATTRIBUTE_HIDDEN;
+extern void bfd_gnu_truncate_arname
+  (bfd *, const char *, char *) ATTRIBUTE_HIDDEN;
 
-bfd_boolean _bfd_bsd_write_armap
-  (bfd *, unsigned int, struct orl *, unsigned int, int);
+extern bfd_boolean _bfd_bsd_write_armap
+  (bfd *, unsigned int, struct orl *, unsigned int, int) ATTRIBUTE_HIDDEN;
 
-bfd_boolean _bfd_coff_write_armap
-  (bfd *, unsigned int, struct orl *, unsigned int, int);
+extern bfd_boolean _bfd_coff_write_armap
+  (bfd *, unsigned int, struct orl *, unsigned int, int) ATTRIBUTE_HIDDEN;
 
 extern void *_bfd_generic_read_ar_hdr
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 extern void _bfd_ar_spacepad
-  (char *, size_t, const char *, long);
+  (char *, size_t, const char *, long) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_ar_sizepad
-  (char *, size_t, bfd_size_type);
+  (char *, size_t, bfd_size_type) ATTRIBUTE_HIDDEN;
 
 extern void *_bfd_generic_read_ar_hdr_mag
-  (bfd *, const char *);
+  (bfd *, const char *) ATTRIBUTE_HIDDEN;
 
 extern bfd_boolean _bfd_generic_write_ar_hdr
-  (bfd *, bfd *);
+  (bfd *, bfd *) ATTRIBUTE_HIDDEN;
 
 extern bfd_boolean _bfd_bsd44_write_ar_hdr
-  (bfd *, bfd *);
+  (bfd *, bfd *) ATTRIBUTE_HIDDEN;
 
-bfd * bfd_generic_openr_next_archived_file
-  (bfd *, bfd *);
+extern bfd * bfd_generic_openr_next_archived_file
+  (bfd *, bfd *) ATTRIBUTE_HIDDEN;
 
-int bfd_generic_stat_arch_elt
-  (bfd *, struct stat *);
+extern int bfd_generic_stat_arch_elt
+  (bfd *, struct stat *) ATTRIBUTE_HIDDEN;
 
 #define _bfd_read_ar_hdr(abfd) \
 	BFD_SEND (abfd, _bfd_read_ar_hdr_fn, (abfd))
@@ -270,14 +279,14 @@  int bfd_generic_stat_arch_elt
 
 #define _bfd_generic_close_and_cleanup _bfd_archive_close_and_cleanup
 extern bfd_boolean _bfd_archive_close_and_cleanup
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 #define _bfd_generic_bfd_free_cached_info _bfd_bool_bfd_true
 extern bfd_boolean _bfd_generic_new_section_hook
-  (bfd *, asection *);
+  (bfd *, asection *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_generic_get_section_contents
-  (bfd *, asection *, void *, file_ptr, bfd_size_type);
+  (bfd *, asection *, void *, file_ptr, bfd_size_type) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_generic_get_section_contents_in_window
-  (bfd *, asection *, bfd_window *, file_ptr, bfd_size_type);
+  (bfd *, asection *, bfd_window *, file_ptr, bfd_size_type) ATTRIBUTE_HIDDEN;
 
 /* Generic routines to use for BFD_JUMP_TABLE_COPY.  Use
    BFD_JUMP_TABLE_COPY (_bfd_generic).  */
@@ -294,19 +303,20 @@  extern bfd_boolean _bfd_generic_get_section_contents_in_window
 #define _bfd_generic_bfd_print_private_bfd_data _bfd_bool_bfd_ptr_true
 
 extern bfd_boolean _bfd_generic_init_private_section_data
-  (bfd *, asection *, bfd *, asection *, struct bfd_link_info *);
+  (bfd *, asection *, bfd *, asection *, struct bfd_link_info *)
+  ATTRIBUTE_HIDDEN;
 
 /* Routines to use for BFD_JUMP_TABLE_CORE when there is no core file
    support.  Use BFD_JUMP_TABLE_CORE (_bfd_nocore).  */
 
 extern char *_bfd_nocore_core_file_failing_command
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 extern int _bfd_nocore_core_file_failing_signal
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_nocore_core_file_matches_executable_p
-  (bfd *, bfd *);
+  (bfd *, bfd *) ATTRIBUTE_HIDDEN;
 extern int _bfd_nocore_core_file_pid
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 
 /* Routines to use for BFD_JUMP_TABLE_ARCHIVE when there is no archive
    file support.  Use BFD_JUMP_TABLE_ARCHIVE (_bfd_noarchive).  */
@@ -314,19 +324,19 @@  extern int _bfd_nocore_core_file_pid
 #define _bfd_noarchive_slurp_armap _bfd_bool_bfd_false_error
 #define _bfd_noarchive_slurp_extended_name_table _bfd_bool_bfd_false_error
 extern bfd_boolean _bfd_noarchive_construct_extended_name_table
-  (bfd *, char **, bfd_size_type *, const char **);
+  (bfd *, char **, bfd_size_type *, const char **) ATTRIBUTE_HIDDEN;
 extern void _bfd_noarchive_truncate_arname
-  (bfd *, const char *, char *);
+  (bfd *, const char *, char *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_noarchive_write_armap
-  (bfd *, unsigned int, struct orl *, unsigned int, int);
+  (bfd *, unsigned int, struct orl *, unsigned int, int) ATTRIBUTE_HIDDEN;
 #define _bfd_noarchive_read_ar_hdr _bfd_ptr_bfd_null_error
 extern bfd_boolean _bfd_noarchive_write_ar_hdr
-  (bfd *, bfd *);
+  (bfd *, bfd *) ATTRIBUTE_HIDDEN;
 extern bfd *
 _bfd_noarchive_openr_next_archived_file
-  (bfd *, bfd *);
+  (bfd *, bfd *) ATTRIBUTE_HIDDEN;
 extern bfd * _bfd_noarchive_get_elt_at_index
-  (bfd *, symindex);
+  (bfd *, symindex) ATTRIBUTE_HIDDEN;
 #define _bfd_noarchive_generic_stat_arch_elt bfd_generic_stat_arch_elt
 #define _bfd_noarchive_update_armap_timestamp _bfd_bool_bfd_false_error
 
@@ -337,7 +347,7 @@  extern bfd * _bfd_noarchive_get_elt_at_index
 #define _bfd_archive_bsd_slurp_extended_name_table \
   _bfd_slurp_extended_name_table
 extern bfd_boolean _bfd_archive_bsd_construct_extended_name_table
-  (bfd *, char **, bfd_size_type *, const char **);
+  (bfd *, char **, bfd_size_type *, const char **) ATTRIBUTE_HIDDEN;
 #define _bfd_archive_bsd_truncate_arname bfd_bsd_truncate_arname
 #define _bfd_archive_bsd_write_armap _bfd_bsd_write_armap
 #define _bfd_archive_bsd_read_ar_hdr _bfd_generic_read_ar_hdr
@@ -348,7 +358,7 @@  extern bfd_boolean _bfd_archive_bsd_construct_extended_name_table
 #define _bfd_archive_bsd_generic_stat_arch_elt \
   bfd_generic_stat_arch_elt
 extern bfd_boolean _bfd_archive_bsd_update_armap_timestamp
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 
 /* Routines to use for BFD_JUMP_TABLE_ARCHIVE to get COFF style
    archives.  Use BFD_JUMP_TABLE_ARCHIVE (_bfd_archive_coff).  */
@@ -357,7 +367,7 @@  extern bfd_boolean _bfd_archive_bsd_update_armap_timestamp
 #define _bfd_archive_coff_slurp_extended_name_table \
   _bfd_slurp_extended_name_table
 extern bfd_boolean _bfd_archive_coff_construct_extended_name_table
-  (bfd *, char **, bfd_size_type *, const char **);
+  (bfd *, char **, bfd_size_type *, const char **) ATTRIBUTE_HIDDEN;
 #define _bfd_archive_coff_truncate_arname bfd_dont_truncate_arname
 #define _bfd_archive_coff_write_armap _bfd_coff_write_armap
 #define _bfd_archive_coff_read_ar_hdr _bfd_generic_read_ar_hdr
@@ -376,7 +386,7 @@  extern bfd_boolean _bfd_archive_coff_construct_extended_name_table
 #define _bfd_archive_bsd44_slurp_extended_name_table \
   _bfd_slurp_extended_name_table
 extern bfd_boolean _bfd_archive_bsd44_construct_extended_name_table
-  (bfd *, char **, bfd_size_type *, const char **);
+  (bfd *, char **, bfd_size_type *, const char **) ATTRIBUTE_HIDDEN;
 #define _bfd_archive_bsd44_truncate_arname bfd_bsd_truncate_arname
 #define _bfd_archive_bsd44_write_armap _bfd_bsd_write_armap
 #define _bfd_archive_bsd44_read_ar_hdr _bfd_generic_read_ar_hdr
@@ -393,7 +403,8 @@  extern bfd_boolean _bfd_archive_bsd44_construct_extended_name_table
    archives.  Use BFD_JUMP_TABLE_ARCHIVE (_bfd_vms_lib).  Some of them
    are irrelevant.  */
 
-extern bfd_boolean _bfd_vms_lib_write_archive_contents (bfd *);
+extern bfd_boolean _bfd_vms_lib_write_archive_contents
+  (bfd *) ATTRIBUTE_HIDDEN;
 #define _bfd_vms_lib_slurp_armap _bfd_noarchive_slurp_armap
 #define _bfd_vms_lib_slurp_extended_name_table \
   _bfd_noarchive_slurp_extended_name_table
@@ -403,114 +414,128 @@  extern bfd_boolean _bfd_vms_lib_write_archive_contents (bfd *);
 #define _bfd_vms_lib_write_armap _bfd_noarchive_write_armap
 #define _bfd_vms_lib_read_ar_hdr _bfd_noarchive_read_ar_hdr
 #define _bfd_vms_lib_write_ar_hdr _bfd_noarchive_write_ar_hdr
-extern bfd *_bfd_vms_lib_openr_next_archived_file (bfd *, bfd *);
-extern bfd *_bfd_vms_lib_get_elt_at_index (bfd *, symindex);
-extern int _bfd_vms_lib_generic_stat_arch_elt (bfd *, struct stat *);
+extern bfd *_bfd_vms_lib_openr_next_archived_file
+  (bfd *, bfd *) ATTRIBUTE_HIDDEN;
+extern bfd *_bfd_vms_lib_get_elt_at_index
+  (bfd *, symindex) ATTRIBUTE_HIDDEN;
+extern int _bfd_vms_lib_generic_stat_arch_elt
+  (bfd *, struct stat *) ATTRIBUTE_HIDDEN;
 #define _bfd_vms_lib_update_armap_timestamp _bfd_bool_bfd_true
 
 /* Extra routines for VMS style archives.  */
 
-extern symindex _bfd_vms_lib_find_symbol (bfd *, const char *);
-extern bfd *_bfd_vms_lib_get_imagelib_file (bfd *);
-extern const bfd_target *_bfd_vms_lib_alpha_archive_p (bfd *);
-extern const bfd_target *_bfd_vms_lib_ia64_archive_p (bfd *);
-extern bfd_boolean _bfd_vms_lib_alpha_mkarchive (bfd *);
-extern bfd_boolean _bfd_vms_lib_ia64_mkarchive (bfd *);
+extern symindex _bfd_vms_lib_find_symbol
+  (bfd *, const char *) ATTRIBUTE_HIDDEN;
+extern bfd *_bfd_vms_lib_get_imagelib_file
+  (bfd *) ATTRIBUTE_HIDDEN;
+extern const bfd_target *_bfd_vms_lib_alpha_archive_p
+  (bfd *) ATTRIBUTE_HIDDEN;
+extern const bfd_target *_bfd_vms_lib_ia64_archive_p
+  (bfd *) ATTRIBUTE_HIDDEN;
+extern bfd_boolean _bfd_vms_lib_alpha_mkarchive
+  (bfd *) ATTRIBUTE_HIDDEN;
+extern bfd_boolean _bfd_vms_lib_ia64_mkarchive
+  (bfd *) ATTRIBUTE_HIDDEN;
 
 /* Routines to use for BFD_JUMP_TABLE_SYMBOLS where there is no symbol
    support.  Use BFD_JUMP_TABLE_SYMBOLS (_bfd_nosymbols).  */
 
 #define _bfd_nosymbols_get_symtab_upper_bound _bfd_long_bfd_n1_error
 extern long _bfd_nosymbols_canonicalize_symtab
-  (bfd *, asymbol **);
+  (bfd *, asymbol **) ATTRIBUTE_HIDDEN;
 #define _bfd_nosymbols_make_empty_symbol _bfd_generic_make_empty_symbol
 extern void _bfd_nosymbols_print_symbol
-  (bfd *, void *, asymbol *, bfd_print_symbol_type);
+  (bfd *, void *, asymbol *, bfd_print_symbol_type) ATTRIBUTE_HIDDEN;
 extern void _bfd_nosymbols_get_symbol_info
-  (bfd *, asymbol *, symbol_info *);
+  (bfd *, asymbol *, symbol_info *) ATTRIBUTE_HIDDEN;
 extern const char * _bfd_nosymbols_get_symbol_version_string
-  (bfd *, asymbol *, bfd_boolean *);
+  (bfd *, asymbol *, bfd_boolean *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_nosymbols_bfd_is_local_label_name
-  (bfd *, const char *);
+  (bfd *, const char *) ATTRIBUTE_HIDDEN;
 #define _bfd_nosymbols_bfd_is_target_special_symbol _bfd_bool_bfd_asymbol_false
 extern alent *_bfd_nosymbols_get_lineno
-  (bfd *, asymbol *);
+  (bfd *, asymbol *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_nosymbols_find_nearest_line
   (bfd *, asymbol **, asection *, bfd_vma,
-   const char **, const char **, unsigned int *, unsigned int *);
+   const char **, const char **, unsigned int *, unsigned int *)
+  ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_nosymbols_find_line
-  (bfd *, asymbol **, asymbol *, const char **, unsigned int *);
+  (bfd *, asymbol **, asymbol *, const char **, unsigned int *)
+  ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_nosymbols_find_inliner_info
-  (bfd *, const char **, const char **, unsigned int *);
+  (bfd *, const char **, const char **, unsigned int *) ATTRIBUTE_HIDDEN;
 extern asymbol *_bfd_nosymbols_bfd_make_debug_symbol
-  (bfd *, void *, unsigned long);
+  (bfd *, void *, unsigned long) ATTRIBUTE_HIDDEN;
 extern long _bfd_nosymbols_read_minisymbols
-  (bfd *, bfd_boolean, void **, unsigned int *);
+  (bfd *, bfd_boolean, void **, unsigned int *) ATTRIBUTE_HIDDEN;
 extern asymbol *_bfd_nosymbols_minisymbol_to_symbol
-  (bfd *, bfd_boolean, const void *, asymbol *);
+  (bfd *, bfd_boolean, const void *, asymbol *) ATTRIBUTE_HIDDEN;
 
 /* Routines to use for BFD_JUMP_TABLE_RELOCS when there is no reloc
    support.  Use BFD_JUMP_TABLE_RELOCS (_bfd_norelocs).  */
 
-extern long _bfd_norelocs_get_reloc_upper_bound (bfd *, asection *);
-extern long _bfd_norelocs_canonicalize_reloc (bfd *, asection *,
-					      arelent **, asymbol **);
-extern void _bfd_norelocs_set_reloc (bfd *, asection *,
-				     arelent **, unsigned int);
+extern long _bfd_norelocs_get_reloc_upper_bound
+  (bfd *, asection *) ATTRIBUTE_HIDDEN;
+extern long _bfd_norelocs_canonicalize_reloc
+  (bfd *, asection *, arelent **, asymbol **) ATTRIBUTE_HIDDEN;
+extern void _bfd_norelocs_set_reloc
+  (bfd *, asection *, arelent **, unsigned int) ATTRIBUTE_HIDDEN;
 extern reloc_howto_type *_bfd_norelocs_bfd_reloc_type_lookup
-  (bfd *, bfd_reloc_code_real_type);
+  (bfd *, bfd_reloc_code_real_type) ATTRIBUTE_HIDDEN;
 extern reloc_howto_type *_bfd_norelocs_bfd_reloc_name_lookup
-  (bfd *, const char *);
+  (bfd *, const char *) ATTRIBUTE_HIDDEN;
 
 /* Routines to use for BFD_JUMP_TABLE_WRITE for targets which may not
    be written.  Use BFD_JUMP_TABLE_WRITE (_bfd_nowrite).  */
 
 extern bfd_boolean _bfd_nowrite_set_arch_mach
-  (bfd *, enum bfd_architecture, unsigned long);
+  (bfd *, enum bfd_architecture, unsigned long) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_nowrite_set_section_contents
-  (bfd *, asection *, const void *, file_ptr, bfd_size_type);
+  (bfd *, asection *, const void *, file_ptr, bfd_size_type) ATTRIBUTE_HIDDEN;
 
 /* Generic routines to use for BFD_JUMP_TABLE_WRITE.  Use
    BFD_JUMP_TABLE_WRITE (_bfd_generic).  */
 
 #define _bfd_generic_set_arch_mach bfd_default_set_arch_mach
 extern bfd_boolean _bfd_generic_set_section_contents
-  (bfd *, asection *, const void *, file_ptr, bfd_size_type);
+  (bfd *, asection *, const void *, file_ptr, bfd_size_type) ATTRIBUTE_HIDDEN;
 
 /* Routines to use for BFD_JUMP_TABLE_LINK for targets which do not
    support linking.  Use BFD_JUMP_TABLE_LINK (_bfd_nolink).  */
 
 extern int _bfd_nolink_sizeof_headers
-  (bfd *, struct bfd_link_info *);
+  (bfd *, struct bfd_link_info *) ATTRIBUTE_HIDDEN;
 extern bfd_byte *_bfd_nolink_bfd_get_relocated_section_contents
   (bfd *, struct bfd_link_info *, struct bfd_link_order *,
-   bfd_byte *, bfd_boolean, asymbol **);
+   bfd_byte *, bfd_boolean, asymbol **) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_nolink_bfd_relax_section
-  (bfd *, asection *, struct bfd_link_info *, bfd_boolean *);
+  (bfd *, asection *, struct bfd_link_info *, bfd_boolean *) ATTRIBUTE_HIDDEN;
 #define _bfd_nolink_bfd_gc_sections _bfd_bool_bfd_link_false_error
 extern bfd_boolean _bfd_nolink_bfd_lookup_section_flags
-  (struct bfd_link_info *, struct flag_info *, asection *);
+  (struct bfd_link_info *, struct flag_info *, asection *) ATTRIBUTE_HIDDEN;
 #define _bfd_nolink_bfd_merge_sections _bfd_bool_bfd_link_false_error
 extern bfd_boolean _bfd_nolink_bfd_is_group_section
-  (bfd *, const asection *);
+  (bfd *, const asection *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_nolink_bfd_discard_group
-  (bfd *, asection *);
+  (bfd *, asection *) ATTRIBUTE_HIDDEN;
 extern struct bfd_link_hash_table *_bfd_nolink_bfd_link_hash_table_create
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 #define _bfd_nolink_bfd_link_add_symbols _bfd_bool_bfd_link_false_error
 extern void _bfd_nolink_bfd_link_just_syms
-  (asection *, struct bfd_link_info *);
+  (asection *, struct bfd_link_info *) ATTRIBUTE_HIDDEN;
 extern void _bfd_nolink_bfd_copy_link_hash_symbol_type
-  (bfd *, struct bfd_link_hash_entry *, struct bfd_link_hash_entry *);
+  (bfd *, struct bfd_link_hash_entry *, struct bfd_link_hash_entry *)
+  ATTRIBUTE_HIDDEN;
 #define _bfd_nolink_bfd_final_link _bfd_bool_bfd_link_false_error
 extern bfd_boolean _bfd_nolink_bfd_link_split_section
-  (bfd *, struct bfd_section *);
+  (bfd *, struct bfd_section *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_nolink_section_already_linked
-  (bfd *, asection *, struct bfd_link_info *);
+  (bfd *, asection *, struct bfd_link_info *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_nolink_bfd_define_common_symbol
-  (bfd *, struct bfd_link_info *, struct bfd_link_hash_entry *);
+  (bfd *, struct bfd_link_info *, struct bfd_link_hash_entry *)
+  ATTRIBUTE_HIDDEN;
 extern struct bfd_link_hash_entry *_bfd_nolink_bfd_define_start_stop
-  (struct bfd_link_info *, const char *, asection *);
+  (struct bfd_link_info *, const char *, asection *) ATTRIBUTE_HIDDEN;
 #define _bfd_nolink_bfd_link_check_relocs \
   _bfd_generic_link_check_relocs
 
@@ -522,31 +547,31 @@  extern struct bfd_link_hash_entry *_bfd_nolink_bfd_define_start_stop
 #define _bfd_nodynamic_canonicalize_dynamic_symtab \
   _bfd_nosymbols_canonicalize_symtab
 extern long _bfd_nodynamic_get_synthetic_symtab
-  (bfd *, long, asymbol **, long, asymbol **, asymbol **);
+  (bfd *, long, asymbol **, long, asymbol **, asymbol **) ATTRIBUTE_HIDDEN;
 #define _bfd_nodynamic_get_dynamic_reloc_upper_bound _bfd_long_bfd_n1_error
 extern long _bfd_nodynamic_canonicalize_dynamic_reloc
-  (bfd *, arelent **, asymbol **);
+  (bfd *, arelent **, asymbol **) ATTRIBUTE_HIDDEN;
 
 /* Generic routine to determine of the given symbol is a local
    label.  */
 extern bfd_boolean bfd_generic_is_local_label_name
-  (bfd *, const char *);
+  (bfd *, const char *) ATTRIBUTE_HIDDEN;
 
 /* Generic minisymbol routines.  */
 extern long _bfd_generic_read_minisymbols
-  (bfd *, bfd_boolean, void **, unsigned int *);
+  (bfd *, bfd_boolean, void **, unsigned int *) ATTRIBUTE_HIDDEN;
 extern asymbol *_bfd_generic_minisymbol_to_symbol
-  (bfd *, bfd_boolean, const void *, asymbol *);
+  (bfd *, bfd_boolean, const void *, asymbol *) ATTRIBUTE_HIDDEN;
 
 /* Find the nearest line using .stab/.stabstr sections.  */
 extern bfd_boolean _bfd_stab_section_find_nearest_line
   (bfd *, asymbol **, asection *, bfd_vma, bfd_boolean *,
-   const char **, const char **, unsigned int *, void **);
+   const char **, const char **, unsigned int *, void **) ATTRIBUTE_HIDDEN;
 
 /* Find the nearest line using DWARF 1 debugging information.  */
 extern bfd_boolean _bfd_dwarf1_find_nearest_line
   (bfd *, asymbol **, asection *, bfd_vma,
-   const char **, const char **, unsigned int *);
+   const char **, const char **, unsigned int *) ATTRIBUTE_HIDDEN;
 
 struct dwarf_debug_section
 {
@@ -557,39 +582,41 @@  struct dwarf_debug_section
 /* Map of uncompressed DWARF debug section name to compressed one.  It
    is terminated by NULL uncompressed_name.  */
 
-extern const struct dwarf_debug_section dwarf_debug_sections[];
+extern const struct dwarf_debug_section dwarf_debug_sections[] ATTRIBUTE_HIDDEN;
 
 /* Find the nearest line using DWARF 2 debugging information.  */
 extern bfd_boolean _bfd_dwarf2_find_nearest_line
   (bfd *, asymbol **, asymbol *, asection *, bfd_vma,
    const char **, const char **, unsigned int *, unsigned int *,
-   const struct dwarf_debug_section *, unsigned int, void **);
+   const struct dwarf_debug_section *, unsigned int, void **) ATTRIBUTE_HIDDEN;
 
 /* Find the bias between DWARF addresses and real addresses.  */
 extern bfd_signed_vma _bfd_dwarf2_find_symbol_bias
-  (asymbol **, void **);
+  (asymbol **, void **) ATTRIBUTE_HIDDEN;
 
 /* Find inliner info after calling bfd_find_nearest_line. */
 extern bfd_boolean _bfd_dwarf2_find_inliner_info
-  (bfd *, const char **, const char **, unsigned int *, void **);
+  (bfd *, const char **, const char **, unsigned int *, void **)
+  ATTRIBUTE_HIDDEN;
 
 /* Read DWARF 2 debugging information. */
 extern bfd_boolean _bfd_dwarf2_slurp_debug_info
   (bfd *, bfd *, const struct dwarf_debug_section *, asymbol **, void **,
-   bfd_boolean);
+   bfd_boolean) ATTRIBUTE_HIDDEN;
 
 /* Clean up the data used to handle DWARF 2 debugging information. */
 extern void _bfd_dwarf2_cleanup_debug_info
-  (bfd *, void **);
+  (bfd *, void **) ATTRIBUTE_HIDDEN;
 
 /* Create a new section entry.  */
 extern struct bfd_hash_entry *bfd_section_hash_newfunc
-  (struct bfd_hash_entry *, struct bfd_hash_table *, const char *);
+  (struct bfd_hash_entry *, struct bfd_hash_table *, const char *)
+  ATTRIBUTE_HIDDEN;
 
 /* A routine to create entries for a bfd_link_hash_table.  */
 extern struct bfd_hash_entry *_bfd_link_hash_newfunc
   (struct bfd_hash_entry *entry, struct bfd_hash_table *table,
-   const char *string);
+   const char *string) ATTRIBUTE_HIDDEN;
 
 /* Initialize a bfd_link_hash_table.  */
 extern bfd_boolean _bfd_link_hash_table_init
@@ -597,26 +624,26 @@  extern bfd_boolean _bfd_link_hash_table_init
    struct bfd_hash_entry *(*) (struct bfd_hash_entry *,
 			       struct bfd_hash_table *,
 			       const char *),
-   unsigned int);
+   unsigned int) ATTRIBUTE_HIDDEN;
 
 /* Generic link hash table creation routine.  */
 extern struct bfd_link_hash_table *_bfd_generic_link_hash_table_create
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 
 /* Generic link hash table destruction routine.  */
 extern void _bfd_generic_link_hash_table_free
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 
 /* Generic add symbol routine.  */
 extern bfd_boolean _bfd_generic_link_add_symbols
-  (bfd *, struct bfd_link_info *);
+  (bfd *, struct bfd_link_info *) ATTRIBUTE_HIDDEN;
 
 /* Generic archive add symbol routine.  */
 extern bfd_boolean _bfd_generic_link_add_archive_symbols
   (bfd *, struct bfd_link_info *,
    bfd_boolean (*) (bfd *, struct bfd_link_info *,
 		    struct bfd_link_hash_entry *, const char *,
-		    bfd_boolean *));
+		    bfd_boolean *)) ATTRIBUTE_HIDDEN;
 
 /* Forward declaration to avoid prototype errors.  */
 typedef struct bfd_link_hash_entry _bfd_link_hash_entry;
@@ -625,124 +652,131 @@  typedef struct bfd_link_hash_entry _bfd_link_hash_entry;
 extern bfd_boolean _bfd_generic_link_add_one_symbol
   (struct bfd_link_info *, bfd *, const char *name, flagword,
    asection *, bfd_vma, const char *, bfd_boolean copy,
-   bfd_boolean constructor, struct bfd_link_hash_entry **);
+   bfd_boolean constructor, struct bfd_link_hash_entry **) ATTRIBUTE_HIDDEN;
 
 /* Generic routine to mark section as supplying symbols only.  */
 extern void _bfd_generic_link_just_syms
-  (asection *, struct bfd_link_info *);
+  (asection *, struct bfd_link_info *) ATTRIBUTE_HIDDEN;
 
 /* Generic routine that does nothing.  */
 extern void _bfd_generic_copy_link_hash_symbol_type
-  (bfd *, struct bfd_link_hash_entry *, struct bfd_link_hash_entry *);
+  (bfd *, struct bfd_link_hash_entry *, struct bfd_link_hash_entry *)
+  ATTRIBUTE_HIDDEN;
 
 /* Generic link routine.  */
 extern bfd_boolean _bfd_generic_final_link
-  (bfd *, struct bfd_link_info *);
+  (bfd *, struct bfd_link_info *) ATTRIBUTE_HIDDEN;
 
 extern bfd_boolean _bfd_generic_link_split_section
-  (bfd *, struct bfd_section *);
+  (bfd *, struct bfd_section *) ATTRIBUTE_HIDDEN;
 
 extern bfd_boolean _bfd_generic_section_already_linked
-  (bfd *, asection *, struct bfd_link_info *);
+  (bfd *, asection *, struct bfd_link_info *) ATTRIBUTE_HIDDEN;
 
 /* Generic reloc_link_order processing routine.  */
 extern bfd_boolean _bfd_generic_reloc_link_order
-  (bfd *, struct bfd_link_info *, asection *, struct bfd_link_order *);
+  (bfd *, struct bfd_link_info *, asection *, struct bfd_link_order *)
+  ATTRIBUTE_HIDDEN;
 
 /* Default link order processing routine.  */
 extern bfd_boolean _bfd_default_link_order
-  (bfd *, struct bfd_link_info *, asection *, struct bfd_link_order *);
+  (bfd *, struct bfd_link_info *, asection *, struct bfd_link_order *)
+  ATTRIBUTE_HIDDEN;
 
 /* Count the number of reloc entries in a link order list.  */
 extern unsigned int _bfd_count_link_order_relocs
-  (struct bfd_link_order *);
+  (struct bfd_link_order *) ATTRIBUTE_HIDDEN;
 
 /* Final link relocation routine.  */
 extern bfd_reloc_status_type _bfd_final_link_relocate
   (reloc_howto_type *, bfd *, asection *, bfd_byte *,
-   bfd_vma, bfd_vma, bfd_vma);
+   bfd_vma, bfd_vma, bfd_vma) ATTRIBUTE_HIDDEN;
 
 /* Relocate a particular location by a howto and a value.  */
 extern bfd_reloc_status_type _bfd_relocate_contents
-  (reloc_howto_type *, bfd *, bfd_vma, bfd_byte *);
+  (reloc_howto_type *, bfd *, bfd_vma, bfd_byte *) ATTRIBUTE_HIDDEN;
 
 /* Clear a given location using a given howto.  */
-extern void _bfd_clear_contents (reloc_howto_type *howto, bfd *input_bfd,
-				 asection *input_section, bfd_byte *location);
+extern void _bfd_clear_contents
+  (reloc_howto_type *, bfd *, asection *, bfd_byte *) ATTRIBUTE_HIDDEN;
 
 /* Link stabs in sections in the first pass.  */
 
 extern bfd_boolean _bfd_link_section_stabs
   (bfd *, struct stab_info *, asection *, asection *, void **,
-   bfd_size_type *);
+   bfd_size_type *) ATTRIBUTE_HIDDEN;
 
 /* Eliminate stabs for discarded functions and symbols.  */
 extern bfd_boolean _bfd_discard_section_stabs
-  (bfd *, asection *, void *, bfd_boolean (*) (bfd_vma, void *), void *);
+  (bfd *, asection *, void *, bfd_boolean (*) (bfd_vma, void *), void *)
+  ATTRIBUTE_HIDDEN;
 
 /* Write out the .stab section when linking stabs in sections.  */
 
 extern bfd_boolean _bfd_write_section_stabs
-  (bfd *, struct stab_info *, asection *, void **, bfd_byte *);
+  (bfd *, struct stab_info *, asection *, void **, bfd_byte *)
+  ATTRIBUTE_HIDDEN;
 
 /* Write out the .stabstr string table when linking stabs in sections.  */
 
 extern bfd_boolean _bfd_write_stab_strings
-  (bfd *, struct stab_info *);
+  (bfd *, struct stab_info *) ATTRIBUTE_HIDDEN;
 
 /* Find an offset within a .stab section when linking stabs in
    sections.  */
 
 extern bfd_vma _bfd_stab_section_offset
-  (asection *, void *, bfd_vma);
+  (asection *, void *, bfd_vma) ATTRIBUTE_HIDDEN;
 
 /* Register a SEC_MERGE section as a candidate for merging.  */
 
 extern bfd_boolean _bfd_add_merge_section
-  (bfd *, void **, asection *, void **);
+  (bfd *, void **, asection *, void **) ATTRIBUTE_HIDDEN;
 
 /* Attempt to merge SEC_MERGE sections.  */
 
 extern bfd_boolean _bfd_merge_sections
-  (bfd *, struct bfd_link_info *, void *, void (*) (bfd *, asection *));
+  (bfd *, struct bfd_link_info *, void *, void (*) (bfd *, asection *))
+  ATTRIBUTE_HIDDEN;
 
 /* Write out a merged section.  */
 
 extern bfd_boolean _bfd_write_merged_section
-  (bfd *, asection *, void *);
+  (bfd *, asection *, void *) ATTRIBUTE_HIDDEN;
 
 /* Find an offset within a modified SEC_MERGE section.  */
 
 extern bfd_vma _bfd_merged_section_offset
-  (bfd *, asection **, void *, bfd_vma);
+  (bfd *, asection **, void *, bfd_vma) ATTRIBUTE_HIDDEN;
 
 /* Tidy up when done.  */
 
-extern void _bfd_merge_sections_free (void *);
+extern void _bfd_merge_sections_free (void *) ATTRIBUTE_HIDDEN;
 
 /* Create a string table.  */
 extern struct bfd_strtab_hash *_bfd_stringtab_init
-  (void);
+  (void) ATTRIBUTE_HIDDEN;
 
 /* Create an XCOFF .debug section style string table.  */
 extern struct bfd_strtab_hash *_bfd_xcoff_stringtab_init
-  (void);
+  (void) ATTRIBUTE_HIDDEN;
 
 /* Free a string table.  */
 extern void _bfd_stringtab_free
-  (struct bfd_strtab_hash *);
+  (struct bfd_strtab_hash *) ATTRIBUTE_HIDDEN;
 
 /* Get the size of a string table.  */
 extern bfd_size_type _bfd_stringtab_size
-  (struct bfd_strtab_hash *);
+  (struct bfd_strtab_hash *) ATTRIBUTE_HIDDEN;
 
 /* Add a string to a string table.  */
 extern bfd_size_type _bfd_stringtab_add
-  (struct bfd_strtab_hash *, const char *, bfd_boolean hash, bfd_boolean copy);
+  (struct bfd_strtab_hash *, const char *, bfd_boolean hash, bfd_boolean copy)
+  ATTRIBUTE_HIDDEN;
 
 /* Write out a string table.  */
 extern bfd_boolean _bfd_stringtab_emit
-  (bfd *, struct bfd_strtab_hash *);
+  (bfd *, struct bfd_strtab_hash *) ATTRIBUTE_HIDDEN;
 
 /* Macros to tell if bfds are read or write enabled.
 
@@ -758,8 +792,8 @@  extern bfd_boolean _bfd_stringtab_emit
 #define	bfd_write_p(abfd) \
   ((abfd)->direction == write_direction || (abfd)->direction == both_direction)
 
-void bfd_assert
-  (const char*,int);
+extern void bfd_assert
+  (const char*,int) ATTRIBUTE_HIDDEN;
 
 #define BFD_ASSERT(x) \
   do { if (!(x)) bfd_assert(__FILE__,__LINE__); } while (0)
@@ -768,7 +802,7 @@  void bfd_assert
   do { bfd_assert(__FILE__,__LINE__); } while (0)
 
 extern void _bfd_abort
-  (const char *, int, const char *) ATTRIBUTE_NORETURN;
+  (const char *, int, const char *) ATTRIBUTE_NORETURN ATTRIBUTE_HIDDEN;
 
 /* if gcc >= 2.6, we can give a function name, too */
 #if __GNUC__ < 2 || (__GNUC__ == 2 && __GNUC_MINOR__ < 6)
@@ -780,17 +814,20 @@  extern void _bfd_abort
 
 /* Manipulate a system FILE but using BFD's "file_ptr", rather than
    the system "off_t" or "off64_t", as the offset.  */
-extern file_ptr _bfd_real_ftell (FILE *file);
-extern int _bfd_real_fseek (FILE *file, file_ptr offset, int whence);
-extern FILE *_bfd_real_fopen (const char *filename, const char *modes);
+extern file_ptr _bfd_real_ftell
+  (FILE *) ATTRIBUTE_HIDDEN;
+extern int _bfd_real_fseek
+  (FILE *, file_ptr, int) ATTRIBUTE_HIDDEN;
+extern FILE *_bfd_real_fopen
+  (const char *, const char *) ATTRIBUTE_HIDDEN;
 
 /* List of supported target vectors, and the default vector (if
    bfd_default_vector[0] is NULL, there is no default).  */
-extern const bfd_target * const *bfd_target_vector;
-extern const bfd_target *bfd_default_vector[];
+extern const bfd_target * const *bfd_target_vector ATTRIBUTE_HIDDEN;
+extern const bfd_target *bfd_default_vector[] ATTRIBUTE_HIDDEN;
 
 /* List of associated target vectors.  */
-extern const bfd_target * const *bfd_associated_vector;
+extern const bfd_target * const *bfd_associated_vector ATTRIBUTE_HIDDEN;
 
 /* Functions shared by the ECOFF and MIPS ELF backends, which have no
    other common header files.  */
@@ -802,18 +839,18 @@  struct ecoff_find_line;
 extern bfd_boolean _bfd_ecoff_locate_line
   (bfd *, asection *, bfd_vma, struct ecoff_debug_info * const,
    const struct ecoff_debug_swap * const, struct ecoff_find_line *,
-   const char **, const char **, unsigned int *);
+   const char **, const char **, unsigned int *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_ecoff_get_accumulated_pdr
-  (void *, bfd_byte *);
+  (void *, bfd_byte *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_ecoff_get_accumulated_sym
-  (void *, bfd_byte *);
+  (void *, bfd_byte *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean _bfd_ecoff_get_accumulated_ss
-  (void *, bfd_byte *);
+  (void *, bfd_byte *) ATTRIBUTE_HIDDEN;
 
 extern bfd_vma _bfd_get_gp_value
-  (bfd *);
+  (bfd *) ATTRIBUTE_HIDDEN;
 extern void _bfd_set_gp_value
-  (bfd *, bfd_vma);
+  (bfd *, bfd_vma) ATTRIBUTE_HIDDEN;
 
 /* Function shared by the COFF and ELF SH backends, which have no
    other common header files.  */
@@ -822,7 +859,7 @@  extern void _bfd_set_gp_value
 extern bfd_boolean _bfd_sh_align_load_span
   (bfd *, asection *, bfd_byte *,
    bfd_boolean (*) (bfd *, asection *, void *, bfd_byte *, bfd_vma),
-   void *, bfd_vma **, bfd_vma *, bfd_vma, bfd_vma, bfd_boolean *);
+   void *, bfd_vma **, bfd_vma *, bfd_vma, bfd_vma, bfd_boolean *) ATTRIBUTE_HIDDEN;
 #endif
 
 /* This is the shape of the elements inside the already_linked hash
@@ -842,14 +879,18 @@  struct bfd_section_already_linked
 };
 
 extern struct bfd_section_already_linked_hash_entry *
-  bfd_section_already_linked_table_lookup (const char *);
+  bfd_section_already_linked_table_lookup (const char *) ATTRIBUTE_HIDDEN;
 extern bfd_boolean bfd_section_already_linked_table_insert
-  (struct bfd_section_already_linked_hash_entry *, asection *);
+  (struct bfd_section_already_linked_hash_entry *, asection *)
+  ATTRIBUTE_HIDDEN;
 extern void bfd_section_already_linked_table_traverse
   (bfd_boolean (*) (struct bfd_section_already_linked_hash_entry *,
-		    void *), void *);
-
-extern bfd_vma _bfd_read_unsigned_leb128 (bfd *, bfd_byte *, unsigned int *);
-extern bfd_signed_vma _bfd_read_signed_leb128 (bfd *, bfd_byte *, unsigned int *);
-extern bfd_vma _bfd_safe_read_leb128 (bfd *, bfd_byte *, unsigned int *,
-				      bfd_boolean, const bfd_byte * const);
+		    void *), void *) ATTRIBUTE_HIDDEN;
+
+extern bfd_vma _bfd_read_unsigned_leb128
+  (bfd *, bfd_byte *, unsigned int *) ATTRIBUTE_HIDDEN;
+extern bfd_signed_vma _bfd_read_signed_leb128
+  (bfd *, bfd_byte *, unsigned int *) ATTRIBUTE_HIDDEN;
+extern bfd_vma _bfd_safe_read_leb128
+  (bfd *, bfd_byte *, unsigned int *, bfd_boolean, const bfd_byte * const)
+  ATTRIBUTE_HIDDEN;