i386: Append ".p2align 4,0" to gas tests

Message ID 20180507021115.10250-1-hjl.tools@gmail.com
State New
Headers show
Series
  • i386: Append ".p2align 4,0" to gas tests
Related show

Commit Message

H.J. Lu May 7, 2018, 2:11 a.m.
Append ".p2align 4,0" to i386 assembler tests to support mingw targets.

	* testsuite/gas/i386/avx512f-plain.s: Append ".p2align 4,0".
	* testsuite/gas/i386/avx512vl-plain.s: Likewise.
	* testsuite/gas/i386/bnd.s: Likewise.
	* testsuite/gas/i386/stN.s: Likewise.
	* testsuite/gas/i386/avx512f-plain.l: Updated.
	* testsuite/gas/i386/avx512vl-plain.l: Likewise.
	* testsuite/gas/i386/bnd.l: Likewise.
	* testsuite/gas/i386/stN.l: Likewise.
---
 gas/ChangeLog                           | 11 +++++++++++
 gas/testsuite/gas/i386/avx512f-plain.l  |  2 ++
 gas/testsuite/gas/i386/avx512f-plain.s  |  1 +
 gas/testsuite/gas/i386/avx512vl-plain.l |  2 ++
 gas/testsuite/gas/i386/avx512vl-plain.s |  1 +
 gas/testsuite/gas/i386/bnd.l            |  2 ++
 gas/testsuite/gas/i386/bnd.s            |  1 +
 gas/testsuite/gas/i386/stN.l            |  2 ++
 gas/testsuite/gas/i386/stN.s            |  1 +
 9 files changed, 23 insertions(+)

-- 
2.17.0

Comments

Jan Beulich May 7, 2018, 6:40 a.m. | #1
>>> On 07.05.18 at 04:11, <hjl.tools@gmail.com> wrote:

> Append ".p2align 4,0" to i386 assembler tests to support mingw targets.

> 

> 	* testsuite/gas/i386/avx512f-plain.s: Append ".p2align 4,0".

> 	* testsuite/gas/i386/avx512vl-plain.s: Likewise.

> 	* testsuite/gas/i386/bnd.s: Likewise.

> 	* testsuite/gas/i386/stN.s: Likewise.

> 	* testsuite/gas/i386/avx512f-plain.l: Updated.

> 	* testsuite/gas/i386/avx512vl-plain.l: Likewise.

> 	* testsuite/gas/i386/bnd.l: Likewise.

> 	* testsuite/gas/i386/stN.l: Likewise.


Thanks here too for taking care of it, but if this is a recurring thing that all
tests need, is this really something each and every test should repeat?

Jan
H.J. Lu May 7, 2018, 11:17 a.m. | #2
On Sun, May 6, 2018 at 11:40 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 07.05.18 at 04:11, <hjl.tools@gmail.com> wrote:

>> Append ".p2align 4,0" to i386 assembler tests to support mingw targets.

>>

>>       * testsuite/gas/i386/avx512f-plain.s: Append ".p2align 4,0".

>>       * testsuite/gas/i386/avx512vl-plain.s: Likewise.

>>       * testsuite/gas/i386/bnd.s: Likewise.

>>       * testsuite/gas/i386/stN.s: Likewise.

>>       * testsuite/gas/i386/avx512f-plain.l: Updated.

>>       * testsuite/gas/i386/avx512vl-plain.l: Likewise.

>>       * testsuite/gas/i386/bnd.l: Likewise.

>>       * testsuite/gas/i386/stN.l: Likewise.

>

> Thanks here too for taking care of it, but if this is a recurring thing that all

> tests need, is this really something each and every test should repeat?

>


We need it for tests with error or waning.   Do you have any suggestions?

-- 
H.J.
Jan Beulich May 7, 2018, 11:59 a.m. | #3
>>> On 07.05.18 at 13:17, <hjl.tools@gmail.com> wrote:

> On Sun, May 6, 2018 at 11:40 PM, Jan Beulich <JBeulich@suse.com> wrote:

>>>>> On 07.05.18 at 04:11, <hjl.tools@gmail.com> wrote:

>>> Append ".p2align 4,0" to i386 assembler tests to support mingw targets.

>>>

>>>       * testsuite/gas/i386/avx512f-plain.s: Append ".p2align 4,0".

>>>       * testsuite/gas/i386/avx512vl-plain.s: Likewise.

>>>       * testsuite/gas/i386/bnd.s: Likewise.

>>>       * testsuite/gas/i386/stN.s: Likewise.

>>>       * testsuite/gas/i386/avx512f-plain.l: Updated.

>>>       * testsuite/gas/i386/avx512vl-plain.l: Likewise.

>>>       * testsuite/gas/i386/bnd.l: Likewise.

>>>       * testsuite/gas/i386/stN.l: Likewise.

>>

>> Thanks here too for taking care of it, but if this is a recurring thing that all

>> tests need, is this really something each and every test should repeat?

> 

> We need it for tests with error or waning.   Do you have any suggestions?


Well, I'm not a DejaGnu/expect specialist, but I would think it ought to be
possible to have run_dump_test / run_list_test deal with this, e.g. by adding
an extra small assembly file to the end of respective "as" command lines (it
allows for multiple inputs after all).

Jan
H.J. Lu May 7, 2018, 12:28 p.m. | #4
On Mon, May 7, 2018 at 4:59 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 07.05.18 at 13:17, <hjl.tools@gmail.com> wrote:

>> On Sun, May 6, 2018 at 11:40 PM, Jan Beulich <JBeulich@suse.com> wrote:

>>>>>> On 07.05.18 at 04:11, <hjl.tools@gmail.com> wrote:

>>>> Append ".p2align 4,0" to i386 assembler tests to support mingw targets.

>>>>

>>>>       * testsuite/gas/i386/avx512f-plain.s: Append ".p2align 4,0".

>>>>       * testsuite/gas/i386/avx512vl-plain.s: Likewise.

>>>>       * testsuite/gas/i386/bnd.s: Likewise.

>>>>       * testsuite/gas/i386/stN.s: Likewise.

>>>>       * testsuite/gas/i386/avx512f-plain.l: Updated.

>>>>       * testsuite/gas/i386/avx512vl-plain.l: Likewise.

>>>>       * testsuite/gas/i386/bnd.l: Likewise.

>>>>       * testsuite/gas/i386/stN.l: Likewise.

>>>

>>> Thanks here too for taking care of it, but if this is a recurring thing that all

>>> tests need, is this really something each and every test should repeat?

>>

>> We need it for tests with error or waning.   Do you have any suggestions?

>

> Well, I'm not a DejaGnu/expect specialist, but I would think it ought to be

> possible to have run_dump_test / run_list_test deal with this, e.g. by adding

> an extra small assembly file to the end of respective "as" command lines (it

> allows for multiple inputs after all).


Can you give it a try?

-- 
H.J.
Jan Beulich May 7, 2018, 12:37 p.m. | #5
>>> On 07.05.18 at 14:28, <hjl.tools@gmail.com> wrote:

> On Mon, May 7, 2018 at 4:59 AM, Jan Beulich <JBeulich@suse.com> wrote:

>>>>> On 07.05.18 at 13:17, <hjl.tools@gmail.com> wrote:

>>> On Sun, May 6, 2018 at 11:40 PM, Jan Beulich <JBeulich@suse.com> wrote:

>>>>>>> On 07.05.18 at 04:11, <hjl.tools@gmail.com> wrote:

>>>>> Append ".p2align 4,0" to i386 assembler tests to support mingw targets.

>>>>>

>>>>>       * testsuite/gas/i386/avx512f-plain.s: Append ".p2align 4,0".

>>>>>       * testsuite/gas/i386/avx512vl-plain.s: Likewise.

>>>>>       * testsuite/gas/i386/bnd.s: Likewise.

>>>>>       * testsuite/gas/i386/stN.s: Likewise.

>>>>>       * testsuite/gas/i386/avx512f-plain.l: Updated.

>>>>>       * testsuite/gas/i386/avx512vl-plain.l: Likewise.

>>>>>       * testsuite/gas/i386/bnd.l: Likewise.

>>>>>       * testsuite/gas/i386/stN.l: Likewise.

>>>>

>>>> Thanks here too for taking care of it, but if this is a recurring thing that all

>>>> tests need, is this really something each and every test should repeat?

>>>

>>> We need it for tests with error or waning.   Do you have any suggestions?

>>

>> Well, I'm not a DejaGnu/expect specialist, but I would think it ought to be

>> possible to have run_dump_test / run_list_test deal with this, e.g. by adding

>> an extra small assembly file to the end of respective "as" command lines (it

>> allows for multiple inputs after all).

> 

> Can you give it a try?


I'll see to get to this eventually.

Jan

Patch

diff --git a/gas/ChangeLog b/gas/ChangeLog
index a46492ba9a..dc1d25a0a6 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,14 @@ 
+2018-05-06  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* testsuite/gas/i386/avx512f-plain.s: Append ".p2align 4,0".
+	* testsuite/gas/i386/avx512vl-plain.s: Likewise.
+	* testsuite/gas/i386/bnd.s: Likewise.
+	* testsuite/gas/i386/stN.s: Likewise.
+	* testsuite/gas/i386/avx512f-plain.l: Updated.
+	* testsuite/gas/i386/avx512vl-plain.l: Likewise.
+	* testsuite/gas/i386/bnd.l: Likewise.
+	* testsuite/gas/i386/stN.l: Likewise.
+
 2018-05-04  Alan Modra  <amodra@gmail.com>
 
 	* config/obj-evax.c (shorten_identifier): Use memcpy in place
diff --git a/gas/testsuite/gas/i386/avx512f-plain.l b/gas/testsuite/gas/i386/avx512f-plain.l
index d910b762bf..3c7ce91020 100644
--- a/gas/testsuite/gas/i386/avx512f-plain.l
+++ b/gas/testsuite/gas/i386/avx512f-plain.l
@@ -24,3 +24,5 @@  GAS LISTING .*
 [ 	]*15[ 	]+\.arch \.vpclmulqdq
 [ 	]*16[ 	]+\?\?\?\? 62F36D48[ 	]+vpclmulqdq[ 	]+\$0, %zmm1, %zmm2, %zmm3
 [ 	]*16[ 	]+44D900
+[ 	]*17[ 	]+\?\?\?\? 00000000 		\.p2align 4,0
+#...
diff --git a/gas/testsuite/gas/i386/avx512f-plain.s b/gas/testsuite/gas/i386/avx512f-plain.s
index d295d70f5b..03a0ed7b8d 100644
--- a/gas/testsuite/gas/i386/avx512f-plain.s
+++ b/gas/testsuite/gas/i386/avx512f-plain.s
@@ -14,3 +14,4 @@  _start:
 
 	.arch .vpclmulqdq
 	vpclmulqdq	$0, %zmm1, %zmm2, %zmm3
+	.p2align 4,0
diff --git a/gas/testsuite/gas/i386/avx512vl-plain.l b/gas/testsuite/gas/i386/avx512vl-plain.l
index 447c615c98..c2dee22022 100644
--- a/gas/testsuite/gas/i386/avx512vl-plain.l
+++ b/gas/testsuite/gas/i386/avx512vl-plain.l
@@ -24,3 +24,5 @@  GAS LISTING .*
 [ 	]*15[ 	]+\.arch \.vpclmulqdq
 [ 	]*16[ 	]+\?\?\?\? 62F36D28[ 	]+\{evex\} vpclmulqdq[ 	]+\$0, %ymm1, %ymm2, %ymm3
 [ 	]*16[ 	]+44D900
+[ 	]*17[ 	]+\?\?\?\? 00000000 		\.p2align 4,0
+#...
diff --git a/gas/testsuite/gas/i386/avx512vl-plain.s b/gas/testsuite/gas/i386/avx512vl-plain.s
index 711f13a9ef..75e356158a 100644
--- a/gas/testsuite/gas/i386/avx512vl-plain.s
+++ b/gas/testsuite/gas/i386/avx512vl-plain.s
@@ -14,3 +14,4 @@  _start:
 
 	.arch .vpclmulqdq
 	{evex} vpclmulqdq	$0, %ymm1, %ymm2, %ymm3
+	.p2align 4,0
diff --git a/gas/testsuite/gas/i386/bnd.l b/gas/testsuite/gas/i386/bnd.l
index 422289660d..c9377d8c4b 100644
--- a/gas/testsuite/gas/i386/bnd.l
+++ b/gas/testsuite/gas/i386/bnd.l
@@ -10,3 +10,5 @@  GAS LISTING .*
 [ 	]*5[ 	]+\?\?\?\? A1000000[ 	]+mov	eax, bnd0
 [ 	]*5[ 	]+00
 [ 	]*6[ 	]+bndmov	bnd0, bnd0
+[ 	]*7[ 	]+\?\?\?\? 00000000 		\.p2align 4,0
+#...
diff --git a/gas/testsuite/gas/i386/bnd.s b/gas/testsuite/gas/i386/bnd.s
index 9ca4ce7322..e2c61bf4ed 100644
--- a/gas/testsuite/gas/i386/bnd.s
+++ b/gas/testsuite/gas/i386/bnd.s
@@ -4,3 +4,4 @@ 
 bnd:
 	mov	eax, bnd0
 	bndmov	bnd0, bnd0
+	.p2align 4,0
diff --git a/gas/testsuite/gas/i386/stN.l b/gas/testsuite/gas/i386/stN.l
index 5885686e7e..8769004dc3 100644
--- a/gas/testsuite/gas/i386/stN.l
+++ b/gas/testsuite/gas/i386/stN.l
@@ -14,3 +14,5 @@  GAS LISTING .*
 [ 	]*6[ 	]+mov	eax, st\(7\)
 [ 	]*7[ 	]+mov	eax, st \( 7 \)
 [ 	]*8[ 	]+mov	eax, x\(7\)
+[ 	]*9[ 	]+\?\?\?\? 00000000 		\.p2align 4,0
+#...
diff --git a/gas/testsuite/gas/i386/stN.s b/gas/testsuite/gas/i386/stN.s
index 6a1512e526..ef6177e8af 100644
--- a/gas/testsuite/gas/i386/stN.s
+++ b/gas/testsuite/gas/i386/stN.s
@@ -6,3 +6,4 @@  stN:
 	mov	eax, st(7)
 	mov	eax, st ( 7 )
 	mov	eax, x(7)
+	.p2align 4,0