[RFA] Use gdb_bfd_ref_ptr in target_bfd

Message ID 20180504173412.13030-1-tom@tromey.com
State New
Headers show
Series
  • [RFA] Use gdb_bfd_ref_ptr in target_bfd
Related show

Commit Message

Tom Tromey May 4, 2018, 5:34 p.m.
I noticed that target_bfd was using manual reference counting for the
BFD it held.  This patch changes it to use gdb_bfd_ref_ptr instead.

Tested by the buildbot.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
	(target_bfd::target_bfd, target_bfd::~target_bfd): Update.
---
 gdb/ChangeLog    | 5 +++++
 gdb/bfd-target.c | 6 ++----
 2 files changed, 7 insertions(+), 4 deletions(-)

-- 
2.13.6

Comments

Pedro Alves May 4, 2018, 5:52 p.m. | #1
On 05/04/2018 06:34 PM, Tom Tromey wrote:
> I noticed that target_bfd was using manual reference counting for the

> BFD it held.  This patch changes it to use gdb_bfd_ref_ptr instead.

> 

> Tested by the buildbot.

> 

> ChangeLog

> 2018-05-04  Tom Tromey  <tom@tromey.com>

> 

> 	* bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.

> 	(target_bfd::target_bfd, target_bfd::~target_bfd): Update.


OK.

Thanks,
Pedro Alves

Patch

diff --git a/gdb/bfd-target.c b/gdb/bfd-target.c
index ba194d7b04..6138d450d9 100644
--- a/gdb/bfd-target.c
+++ b/gdb/bfd-target.c
@@ -53,7 +53,7 @@  public:
 
 private:
   /* The BFD we're wrapping.  */
-  struct bfd *m_bfd;
+  gdb_bfd_ref_ptr m_bfd;
 
   /* The section table build from the ALLOC sections in BFD.  Note
      that we can't rely on extracting the BFD from a random section in
@@ -90,10 +90,9 @@  target_bfd::get_section_table ()
 }
 
 target_bfd::target_bfd (struct bfd *abfd)
+  : m_bfd (gdb_bfd_ref_ptr::new_reference (abfd))
 {
   this->to_stratum = file_stratum;
-  m_bfd = abfd;
-  gdb_bfd_ref (abfd);
   m_table.sections = NULL;
   m_table.sections_end = NULL;
   build_section_table (abfd, &m_table.sections, &m_table.sections_end);
@@ -101,7 +100,6 @@  target_bfd::target_bfd (struct bfd *abfd)
 
 target_bfd::~target_bfd ()
 {
-  gdb_bfd_unref (m_bfd);
   xfree (m_table.sections);
 }