Enabled _CS* defines for RTEMS

Message ID 20200821192735.23958-1-eshandhawan51@gmail.com
State Superseded
Headers show
Series
  • Enabled _CS* defines for RTEMS
Related show

Commit Message

Corinna Vinschen via Newlib Aug. 21, 2020, 7:27 p.m.
Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>

---
 newlib/libc/include/sys/unistd.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.17.1

Comments

Corinna Vinschen via Newlib Aug. 24, 2020, 9:59 a.m. | #1
On Aug 22 00:57, Eshan dhawan via Newlib wrote:
> Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>

> ---

>  newlib/libc/include/sys/unistd.h | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)

> 

> diff --git a/newlib/libc/include/sys/unistd.h b/newlib/libc/include/sys/unistd.h

> index 5386bd49d..ca92f8b87 100644

> --- a/newlib/libc/include/sys/unistd.h

> +++ b/newlib/libc/include/sys/unistd.h

> @@ -533,7 +533,8 @@ int	unlinkat (int, const char *, int);

>   *  confstr values per IEEE Std 1003.1, 2004 Edition

>   */

>  

> -#ifdef __CYGWIN__	/* Only defined on Cygwin for now. */

> +/* Only defined on Cygwin and RTEMS for now. */

> +#if defined (__CYGWIN__) || (__rtems__)


Shouldn't this be a `defined (__rtems__)'?


Thanks,
Corinna
Corinna Vinschen via Newlib Aug. 24, 2020, 11:38 a.m. | #2
> On 24-Aug-2020, at 3:30 PM, Corinna Vinschen via Newlib <newlib@sourceware.org> wrote:

> 

> ´╗┐On Aug 22 00:57, Eshan dhawan via Newlib wrote:

>> Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>

>> ---

>> newlib/libc/include/sys/unistd.h | 3 ++-

>> 1 file changed, 2 insertions(+), 1 deletion(-)

>> 

>> diff --git a/newlib/libc/include/sys/unistd.h b/newlib/libc/include/sys/unistd.h

>> index 5386bd49d..ca92f8b87 100644

>> --- a/newlib/libc/include/sys/unistd.h

>> +++ b/newlib/libc/include/sys/unistd.h

>> @@ -533,7 +533,8 @@ int    unlinkat (int, const char *, int);

>>  *  confstr values per IEEE Std 1003.1, 2004 Edition

>>  */

>> 

>> -#ifdef __CYGWIN__    /* Only defined on Cygwin for now. */

>> +/* Only defined on Cygwin and RTEMS for now. */

>> +#if defined (__CYGWIN__) || (__rtems__)

> 

> Shouldn't this be a `defined (__rtems__)'?

Apologies sent the wrong patch 
I will send the v2 today :) 
> 

> 

> Thanks,

> Corinna

>

Patch

diff --git a/newlib/libc/include/sys/unistd.h b/newlib/libc/include/sys/unistd.h
index 5386bd49d..ca92f8b87 100644
--- a/newlib/libc/include/sys/unistd.h
+++ b/newlib/libc/include/sys/unistd.h
@@ -533,7 +533,8 @@  int	unlinkat (int, const char *, int);
  *  confstr values per IEEE Std 1003.1, 2004 Edition
  */
 
-#ifdef __CYGWIN__	/* Only defined on Cygwin for now. */
+/* Only defined on Cygwin and RTEMS for now. */
+#if defined (__CYGWIN__) || (__rtems__)
 #define _CS_PATH                               0
 #define _CS_POSIX_V7_ILP32_OFF32_CFLAGS        1
 #define _CS_POSIX_V6_ILP32_OFF32_CFLAGS       _CS_POSIX_V7_ILP32_OFF32_CFLAGS