[RFA,5/9] Add fall-through comment to i386-tdep.c

Message ID 20180421183056.29292-6-tom@tromey.com
State New
Headers show
Series
  • Enable -Wimplicit-fallthrough
Related show

Commit Message

Tom Tromey April 21, 2018, 6:30 p.m.
This adds a fall-through comment in i386-tdep.c.  I am not sure if
this should be a fall-through or a break (it's possible even that it
does not matter), so I elected to preserve the status quo.

ChangeLog
2018-04-21  Tom Tromey  <tom@tromey.com>

	* i386-tdep.c (i386_process_record): Add fall-through comment.
---
 gdb/ChangeLog   | 4 ++++
 gdb/i386-tdep.c | 1 +
 2 files changed, 5 insertions(+)

-- 
2.13.6

Comments

John Baldwin April 24, 2018, 8:31 p.m. | #1
On Saturday, April 21, 2018 12:30:52 PM Tom Tromey wrote:
> This adds a fall-through comment in i386-tdep.c.  I am not sure if

> this should be a fall-through or a break (it's possible even that it

> does not matter), so I elected to preserve the status quo.

> 

> ChangeLog

> 2018-04-21  Tom Tromey  <tom@tromey.com>

> 

> 	* i386-tdep.c (i386_process_record): Add fall-through comment.

> ---

>  gdb/ChangeLog   | 4 ++++

>  gdb/i386-tdep.c | 1 +

>  2 files changed, 5 insertions(+)

> 

> diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c

> index bf4ca54303..8ab7b005b8 100644

> --- a/gdb/i386-tdep.c

> +++ b/gdb/i386-tdep.c

> @@ -7130,6 +7130,7 @@ Do you want to stop the program?"),

>  	      else if (ir.rm == 1)

>  		break;

>  	    }

> +	  /* Fall through.  */

>  	case 3:  /* lidt */

>  	  if (ir.mod == 3)

>  	    {


I believe this is correct based on the diff that added the special cases
for xgetbv and xsetbv as previously ldgt and lidt were treated the same:

diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
index b4dc646b37..b354462cb9 100644
--- a/gdb/i386-tdep.c
+++ b/gdb/i386-tdep.c
@@ -5172,6 +5172,19 @@ reswitch:
 	  break;
 	  /* lgdt */
 	case 2:
+	  if (ir.mod == 3)
+	    {
+	      /* xgetbv */
+	      if (ir.rm == 0)
+		{
+		  I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_REAX_REGNUM);
+		  I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_REDX_REGNUM);
+		  break;
+		}
+	      /* xsetbv */
+	      else if (ir.rm == 1)
+		break;
+	    }
 	  /* lidt */
 	case 3:
 	  if (ir.mod == 3)

-- 
John Baldwin

Patch

diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
index bf4ca54303..8ab7b005b8 100644
--- a/gdb/i386-tdep.c
+++ b/gdb/i386-tdep.c
@@ -7130,6 +7130,7 @@  Do you want to stop the program?"),
 	      else if (ir.rm == 1)
 		break;
 	    }
+	  /* Fall through.  */
 	case 3:  /* lidt */
 	  if (ir.mod == 3)
 	    {