[RFA,4/9] Add a fall-through comment to stabsread.c

Message ID 20180421183056.29292-5-tom@tromey.com
State New
Headers show
Series
  • Enable -Wimplicit-fallthrough
Related show

Commit Message

Tom Tromey April 21, 2018, 6:30 p.m.
This adds a fall-through comment to stabsread.c.  I skimmed the stabs
manual a bit and it seems that 'p' and 'P' are similar enough that
this makes sense.  Also, stabs is mostly deprecated, and the code has
been this way for a long time, so it seemed safest to keep the status
quo.

ChangeLog
2018-04-21  Tom Tromey  <tom@tromey.com>

	* stabsread.c (define_symbol) <case 'p'>: Add fall-through
	comment.
---
 gdb/ChangeLog   | 5 +++++
 gdb/stabsread.c | 1 +
 2 files changed, 6 insertions(+)

-- 
2.13.6

Patch

diff --git a/gdb/stabsread.c b/gdb/stabsread.c
index 8d39290642..a56702aa1d 100644
--- a/gdb/stabsread.c
+++ b/gdb/stabsread.c
@@ -1100,6 +1100,7 @@  define_symbol (CORE_ADDR valu, const char *string, int desc, int type,
 	    }
 	  break;
 	}
+      /* Fall through.  */
 
     case 'P':
       /* acc seems to use P to declare the prototypes of functions that